From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8465DC3ABC3 for ; Tue, 13 May 2025 01:41:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 019706B000A; Mon, 12 May 2025 21:41:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE25C6B0083; Mon, 12 May 2025 21:41:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAB0B6B0085; Mon, 12 May 2025 21:41:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BE8EE6B000A for ; Mon, 12 May 2025 21:41:17 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C16B380FB9 for ; Tue, 13 May 2025 01:41:18 +0000 (UTC) X-FDA: 83436181836.14.2F7F644 Received: from out30-101.freemail.mail.aliyun.com (out30-101.freemail.mail.aliyun.com [115.124.30.101]) by imf06.hostedemail.com (Postfix) with ESMTP id 05327180002 for ; Tue, 13 May 2025 01:41:14 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=P4HKo9M+; spf=pass (imf06.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747100477; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LRpiP2bt97CwKundx+6bXZICHtp/Usmu8g4owh1FF6A=; b=do/04EyLx0d0byDezP6Ih383NjyNzjJwfp0A/OEYTrvqOdpbdZDQSOpZYX1FwrAt961AV1 x5TefHkGZtGfvBde6lguNVJiDvpITEiEbefGa5IxJcI5D7anKEMQZPvFwY3O0mOneHIARL w6LC/m5AAGH+C+FhEYJ4GKwaM7/XF3U= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=P4HKo9M+; spf=pass (imf06.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.101 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747100477; a=rsa-sha256; cv=none; b=u+4rmsYSieSi7xi9J/Jm1zR1v2p/RhoXYuCNPprW6hyWL6yqub0y7iCWLgrppTr4V5NTpc aaCxL39JtVz8ec8YyPIci447bTu8hNxDLmpkiHdHZjyUrhYR5lZmWl6agwR/mHT/q5hPwO Be2YPAD0TKh/lX/ukOqHsLQ2FdztRQ4= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1747100472; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; bh=LRpiP2bt97CwKundx+6bXZICHtp/Usmu8g4owh1FF6A=; b=P4HKo9M+22VeTQsgTfUaehytEDls1AQWoJzb2LXSf+ilrJfGR4QstDqBEoiA2RaZSVHG/hBlKyMe5caXZBxraaCO7a/e9bzKOCBPB6VWmBUE6ypCgRVTaXaprErvJLa+5ZfPolhKo3/+qk+IOtCbXlu621HccKebRJK9v/EmtTo= Received: from DESKTOP-5N7EMDA(mailfrom:ying.huang@linux.alibaba.com fp:SMTPD_---0WaQDtSb_1747100469 cluster:ay36) by smtp.aliyun-inc.com; Tue, 13 May 2025 09:41:10 +0800 From: "Huang, Ying" To: Joshua Hahn Cc: Andrew Morton , gourry@gourry.net, honggyu.kim@sk.com, yunjeong.mun@sk.com, gregkh@linuxfoundation.org, rafael@kernel.org, lenb@kernel.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, dave.jiang@intel.com, horen.chuang@linux.dev, hannes@cmpxchg.org, osalvador@suse.de, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, kernel-team@meta.com Subject: Re: [PATCH v8] mm/mempolicy: Weighted Interleave Auto-tuning In-Reply-To: <20250512142511.3959833-1-joshua.hahnjy@gmail.com> (Joshua Hahn's message of "Mon, 12 May 2025 07:25:10 -0700") References: <20250512142511.3959833-1-joshua.hahnjy@gmail.com> Date: Tue, 13 May 2025 09:41:10 +0800 Message-ID: <87tt5puw21.fsf@DESKTOP-5N7EMDA> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: 4ipbxqxyei6gunu3zm5i7t8rzkakhywt X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 05327180002 X-HE-Tag: 1747100474-997167 X-HE-Meta: U2FsdGVkX1++SADsRFuSMz8K8OXpySdcIExFQrTZw27AxYYTJswcg8k1xloEQjg0YscI7VjXDAtQZYsZVDFnaZboaQfIN/8CciLQfEY9GY4ayFf181lPrVXzk6hPQhAoSADheHfNtnt0TscYm1Zp16Yj3waLiZ7KTC0rx2dDvJ4Y7rv7XSlpWnJR3M6OHwzFmAOEFx1byzAuAZzLJk51QpPy0pOl5wP3dTRVSYSpbBoS1j8CTAL6n4FAMzkevTS+aWS2q/vos8S1ZePHpS4kaGcHi4A3V2GL/PFEozWrBYJRogm6xyK6TgwUwChXZxbFXSWjc1rc1JMBT35gQDRmg9X23QWh2LUF08OPZv0o7TjRabRlZ+f62qrHIfuoNbUdeTiaYnquytYXqaXLXL67LNeJrx+SsIXWu6AlealTnX6tOYTA2xtXM4MdyF29xjyfMbDjN0JX/MNG8DWmEM3vDa7dr9UuQbnuEmeKK2gZE32aWf9irEJurLF+B1IQ9xfiC5KcAZprt9KC0LZWI7lDIxlDxTfe1YAaXsYOCd3IdCKq+Xrm2eCimLT00t4ZL4Oy2ij0vWXf1Smtmfof65Cqo/hVWh4KNrd1SQWBfJeQOvaBfBX4GgOhuN8w8kIfPXqZQYfe0FIJN2jwIyugWGe4Vi/HvT2o5lnhxtJWVriS/ct8Ne9+XXF8AYn5DxqEupCNKZzxACgvEvK4cIC5EviW5DixIlP1EbNaXxXiOlHKdltwm4Y3Ir53zVgkOolHWUeOGwXrmG21LSR8bVPrHTCj1scLktQK4NpRPmPGDo4xQXcGXZlE2kpwyLo0DdBnH0pDl/IKfyQQHIrcrQJ9we5hqVFVbl1ACI3+Tbem49M1qzamLj9gZn2xd9XfTc3IrgQ86vFebM8Cy0QTx9E2yO51SJZ7dXc4zAx6sgnlS4Gn8VEvwiWOn2ClAsEJzQNrOtJj44Uvy4Th6TQdtgayLiz gdFUFc10 gyIbtpsgdL1D6PYcxI4dcc8ZXozGDRYTPfU3l2HJM3aho2tcnPuSk1vobHP25J/2yKrnLl2HDF/EcocyyunUAqz/mL/UCeCZvTpDnL28jTkGsykT+xW+aN/K8hZbPU5/R/v3axNq9F/7tLrrO7VATpFEEgCgYomZI2rmAH5NLJXAD+J2Bz0Njt4S45Ay1DaPfVw5b9+oMld0IgJmX3YIawWFcHdK3aVMG25c87hCXyZpFikK8x/u1TqJ1S3USwfp7W9vZksIqE/ViW6vQYqVL3ncfIGM4NEvkp8RgJWOJateNWgsx7HaZpqVbmgLnYcrOs2ghQxGyWq3Rzpw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Joshua Hahn writes: > On Mon, 12 May 2025 09:35:16 +0800 "Huang, Ying" wrote: > >> Hi, Joshua, >> >> Joshua Hahn writes: >> >> [snip] >> >> > @@ -3707,8 +3720,12 @@ static void wi_state_free(void) >> > kfree(&wi_group->wi_kobj); >> > } >> > >> > +static struct kobj_attribute wi_auto_attr = >> > + __ATTR(auto, 0664, weighted_interleave_auto_show, >> > + weighted_interleave_auto_store); >> > + >> > static void wi_cleanup(void) { >> > - sysfs_remove_file(&wi_group->wi_kobj, &wi_group->auto_kobj_attr.attr); >> > + sysfs_remove_file(&wi_group->wi_kobj, &wi_auto_attr.attr); >> >> If we use wi_auto_attr directly here, we can remove auto_kobj_attr field >> from struct sysfs_wi_group? > > Hi Ying, thank you for this comment. I should have caught it as well. > Removing the last users / setters doesn't seem complicated. > > Andrew, I'm very sorry -- do you think you can fold this fixlet in as well? > This is a minor change that removes the only users of this variable. > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index d5ae36d2eda8..8581cc861945 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -3543,7 +3543,6 @@ struct iw_node_attr { > struct sysfs_wi_group { > struct kobject wi_kobj; > struct mutex kobj_lock; > - struct kobj_attribute auto_kobj_attr; > struct iw_node_attr *nattrs[]; > }; > > @@ -3833,7 +3832,6 @@ static int __init add_weighted_interleave_group(struct kobject *mempolicy_kobj) > err = sysfs_create_file(&wi_group->wi_kobj, &wi_auto_attr.attr); > if (err) > goto err_put_kobj; > - wi_group->auto_kobj_attr = wi_auto_attr > > for_each_online_node(nid) { > if (!node_state(nid, N_MEMORY)) > > Thank you both, I hope you have a great day! Thanks! LGTM, please feel free to add my Reviewed-by: Huang Ying --- Best Regards, Huang, Ying