From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C573C71130 for ; Tue, 8 Jul 2025 01:14:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6CBF6B03BF; Mon, 7 Jul 2025 21:14:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E44496B03C0; Mon, 7 Jul 2025 21:14:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5A146B03C1; Mon, 7 Jul 2025 21:14:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C31836B03BF for ; Mon, 7 Jul 2025 21:14:16 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6151F10B0B7 for ; Tue, 8 Jul 2025 01:14:16 +0000 (UTC) X-FDA: 83639326512.23.2A5CC3C Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf05.hostedemail.com (Postfix) with ESMTP id 99232100009 for ; Tue, 8 Jul 2025 01:14:13 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=hSXvYdwi; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf05.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751937254; a=rsa-sha256; cv=none; b=p8ysd+F/+lFAsAP+pRG49WHWGMRjhhmWJLx6BciVfII+KCLs8gHEbIwH4KtsHsbytDd16B voEEv9djC2S/N2+Zzk2ym4Nal6nDLf0bjQLe2KtnRsbDQfGbF+dRN5KxwKBi0E77IVUIbd pHZsLZIhKbY19ED394YoMra1yJwBuik= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=hSXvYdwi; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf05.hostedemail.com: domain of ying.huang@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=ying.huang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751937254; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=81k2TnA3ySuIrcjJ0C2twsaCPzS1HHoYg9nA+iYe+As=; b=wbniVYGIFjDoJlRRKRycCNFFYzFWv8FCpLTouCoSNsltZiv4n9IUbDJ48WPthX4JpupH+g Cw0VxK7IGWjzKk+HerOggn0NVFF7fF0uo5Y3R+V4+J0TLYbx93kkJUr5iABxrb/aADPW4W MFZX6lfb6Ckfcw+MQDyKpKp/++lO4NY= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1751937250; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; bh=81k2TnA3ySuIrcjJ0C2twsaCPzS1HHoYg9nA+iYe+As=; b=hSXvYdwi87kyF07xumYFfzevEth82QdjlkUhNXqWXLW8FeQhQDteTFybWuhQEUjFJlIA/OwXOWP2khEnOv1sNw6iO5D0X+5IpNH+9d7DwFTVPE4HT4GtsHaqBkopTFdGn+ZUQLYoU+h3VA+9vXPEljxvIZIppGC/0Gk994EfY64= Received: from DESKTOP-5N7EMDA(mailfrom:ying.huang@linux.alibaba.com fp:SMTPD_---0WiIL1OC_1751937247 cluster:ay36) by smtp.aliyun-inc.com; Tue, 08 Jul 2025 09:14:08 +0800 From: "Huang, Ying" To: "Zhijian Li (Fujitsu)" Cc: "linux-mm@kvack.org" , "Huang, Ying" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "Yasunori Gotou (Fujitsu)" , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , "lkp@intel.com" Subject: Re: [PATCH RFC v2] mm: memory-tiering: Fix PGPROMOTE_CANDIDATE accounting In-Reply-To: (Zhijian Li's message of "Mon, 30 Jun 2025 02:11:30 +0000") References: <20250625021352.2291544-1-lizhijian@fujitsu.com> Date: Tue, 08 Jul 2025 09:14:06 +0800 Message-ID: <87tt3nxz4x.fsf@DESKTOP-5N7EMDA> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 99232100009 X-Stat-Signature: un8qjd571xgqz1chafn7xi7zffjsrbh7 X-Rspam-User: X-HE-Tag: 1751937253-597255 X-HE-Meta: U2FsdGVkX18W/racOSCywbZBy3opgW0FGFDta5BFKAU7RbngdPHb/WGb5JArpQ5WodS3DUL6XINedI2UHS1iOjB2zoapCXE9SwyBG/xlrDiQUy7qNcktm3X6gekNWx+i/yptzieRCSYnIk8tMCsnRqEmSCCCAtIRLzifKM7BXJ6m0pVX5yD5OwiSNr8+rQ94LNGeMCe2f2E8zxtBwfwVNF99XIyv/eGHMtZPgYISYLuQhyFfSTCOhhPA+l1KNUpIi7MFdXbmfu/FnBM6uwTtDL4w0pAAqayfRd0PvvxBBEAePPGK5VIpo/NyNNpjiDz9a2i9axutlS/om6RrgP8l5D/vWt3jE10KM2OfnZHM25kGCmVIcC4pLWUNfKapXwZeI6C3lqqikKJiYNATwBShEel7ZtaPnyoj9Um+wNM2Ba8oMyVfNtTx3DpsF1aMNddid4DvuqGAlwCg3nhY5/EILvJ8QWzqrhk3ozYPOlkMWy/7CrbSmd6p/Nswpm94c6mwBcXlFGGhNKHv3x6F3ufUueextCavA+ZCoPlqGR9J95eaMZanU4drXdYU5UlkjIHzynjFP5eoKVtvZng08Qnkl1HDVSZ562EE0xbao/vVx03X2s99YStVmipXi1P7jYvn8CHaTI6LL/Jo3T8RCh3QJHclTGmYbxu7ioL6hT2MU5E9jXmuVw37XrVpZBnbLAxhSqJNKAPzsWWhdJpk+ourfyN8lX9vh+4tJS7wIDj6ygp/vyhDpo+wL85VrYFZ7T6afhstcUO1kALb7miG7Ji9DAYHz5oQ4v7KZavypNEyOKoqBCJJQR23TDYiA766z7u3dfvMgi3bRpwWuTa76pJAUIgTMmaqTvBDMBEZ3Me9fxgACD40LPyvOFTSkEVNXa+DrJJ9yEqLbBN2+/B3GS06JBUaRIxY6SBAhjEj9QG7cN9u29eJTxMO4SDwoqde+V8loDVwhP4pcUfrNBLTtkV 3RJKYY/U UhPKatJO1kvU2XZw0WAzM7WBGHOuZ+RE3RXjZCYKHpLrzlU3fadpIDlj44XMvqrmXg7WYz5VKlRYs4t15giJHcjYcNZNW3ThH+tb+dqjka4uS4HTT28jHTaCxkSdqye7+R8SdatvMTAN9q1CiKPQNdwVgLTmG0O8U26t41VamULQe0smrpDkDYgUMP9Ha/E48YziUZQYHNUDy+V00j9d3l3iD2EqDiAlMblwx4Q/q7QbLG6ytyxctqLuSt0bN/xdfxVQd+1svhlRkYl26VJsodI54Y9xTyWe3v/+yovbsqU5DkJBoGCWPjUex9JOCsmL8WXgJ5XeOKZukvkR7zKBmBvMKo3JWGngx4XUFUjovN10NGF0cOhUJ2/t8sumBpROmvTQbpbE37vigHKTfoN1SG4EOMgIOhhxaan20 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: "Zhijian Li (Fujitsu)" writes: > Hi, > > > On 25/06/2025 10:13, Li Zhijian wrote: >> V2: >> Fix compiling error # Reported by LKP >> >> As Ying suggested, we need to assess whether this change causes regression. >> However, considering the stringent conditions this patch involves, >> properly evaluating it may be challenging, as the outcomes depend on your >> perspective. Much like in a zero-sum game, if someone benefits, another >> might lose. >> >> If there are subsequent results, I will update them here. > > I ran memhog + pmbench to evaluate the impact of the patch(3 runs [1] for each kernel). > > The results show an approximate 4% performance increase in pmbench after applying this patch. > > Average pmbench-access max-promotion-rate > Before: 7956805 pages/sec 168301 pages/sec > After: 8313666 pages/sec (+4.4%) 207149 pages/sec It's hard for me to understand why performance increases because of higher promotion rate, while the expected behavior is more promotion rate limiting. > The detailed logs are available at [2]. > > [1] https://github.com/zhijianli88/misc/blob/main/20250627/promotion-evaluation/reproduce.sh > [2] https://github.com/zhijianli88/misc/tree/main/20250627/promotion-evaluation [snip] --- Best Regards, Huang, Ying