From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id B34B69000BD for ; Mon, 26 Sep 2011 06:35:35 -0400 (EDT) From: Rusty Russell Subject: Re: [PATCH 1/2] oom: do not live lock on frozen tasks In-Reply-To: <20110926082837.GC10156@tiehlicka.suse.cz> References: <20110825091920.GA22564@tiehlicka.suse.cz> <20110825151818.GA4003@redhat.com> <20110825164758.GB22564@tiehlicka.suse.cz> <20110826070946.GA7280@tiehlicka.suse.cz> <20110826085610.GA9083@tiehlicka.suse.cz> <20110826095356.GB9083@tiehlicka.suse.cz> <20110926082837.GC10156@tiehlicka.suse.cz> Date: Mon, 26 Sep 2011 19:58:50 +0930 Message-ID: <87sjnjk36l.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko , David Rientjes Cc: Oleg Nesterov , Konstantin Khlebnikov , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, KOSAKI Motohiro , KAMEZAWA Hiroyuki , "Rafael J. Wysocki" , Tejun Heo On Mon, 26 Sep 2011 10:28:37 +0200, Michal Hocko wrote: > On Fri 26-08-11 11:13:40, David Rientjes wrote: > > I'd love to be able to do a thaw on a PF_FROZEN task in the oom killer > > followed by a SIGKILL if that task is selected for oom kill without an > > heuristic change. Not sure if that's possible, so we'll wait for Rafael > > to chime in. > > We have discussed that with Rafael and it should be safe to do that. See > the patch bellow. > The only place I am not entirely sure about is run_guest > (drivers/lguest/core.c). It seems that the code is able to cope with > signals but it also calls lguest_arch_run_guest after try_to_freeze. Yes; if you want to kill things in the refrigerator(), then will a if (cpu->lg->dead || task_is_dead(current)) break; Work? That break means we return to the read() syscall pretty much immediately. Thanks for the CC, Rusty. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org