From: ebiederm@xmission.com (Eric W. Biederman)
To: David Hildenbrand <david@redhat.com>
Cc: James Morse <james.morse@arm.com>,
kexec@lists.infradead.org, linux-mm@kvack.org,
linux-arm-kernel@lists.infradead.org,
Dave Young <dyoung@redhat.com>, Baoquan He <bhe@redhat.com>
Subject: Re: [PATCH] kexec: Discard loaded image on memory hotplug
Date: Tue, 12 May 2020 06:59:38 -0500 [thread overview]
Message-ID: <87sgg5s6s5.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <4d5f69b6-fdfd-a461-0ac9-6d05636508f1@redhat.com> (David Hildenbrand's message of "Tue, 12 May 2020 09:45:16 +0200")
David Hildenbrand <david@redhat.com> writes:
>>
>> Maybe we have enough information to fixup the loaded kexec image
>> in the kexec_file_load case, we certainly don't in the ordinary
>> kexec_load case.
>
> Yes, that's also what I mentioned in my reply to Baoquan.
>
>>
>> For now I want to stick to the simplest thing we can do which is either
>> blocking the memory hotplug operation (if that is possible) or
>> dropping the loaded kexec image.
>
> Yes, the latter is the best for now. It's simple.
>
> I am suggesting to add explicit callbacks to
> add_memory()/remove_memory(), and calling the invalidation from there -
> because I see various issues with the memory notifier approach (racy,
> false positives, never called if memory is not onlined).
Ok so we are in agreement. Correct patch. Wrong trigger condition.
Eric
next prev parent reply other threads:[~2020-05-12 12:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 16:57 James Morse
2020-05-01 17:26 ` David Hildenbrand
2020-05-09 15:14 ` Eric W. Biederman
2020-05-11 8:19 ` David Hildenbrand
2020-05-11 11:27 ` Baoquan He
2020-05-11 11:55 ` David Hildenbrand
2020-05-12 10:34 ` Baoquan He
2020-05-12 10:54 ` David Hildenbrand
2020-05-12 14:11 ` Baoquan He
2020-05-11 17:05 ` Eric W. Biederman
2020-05-12 7:45 ` David Hildenbrand
2020-05-12 11:59 ` Eric W. Biederman [this message]
2020-05-10 13:06 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgg5s6s5.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=bhe@redhat.com \
--cc=david@redhat.com \
--cc=dyoung@redhat.com \
--cc=james.morse@arm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox