From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AB19C001B0 for ; Mon, 24 Jul 2023 06:02:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45F378D0001; Mon, 24 Jul 2023 02:02:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 40F5A6B0074; Mon, 24 Jul 2023 02:02:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2AF368D0001; Mon, 24 Jul 2023 02:02:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1B22B6B0071 for ; Mon, 24 Jul 2023 02:02:28 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 34CC21208F3 for ; Mon, 24 Jul 2023 06:02:27 +0000 (UTC) X-FDA: 81045460734.19.05B62EF Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf09.hostedemail.com (Postfix) with ESMTP id AB312140004 for ; Mon, 24 Jul 2023 06:02:24 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=d4XF99La; spf=pass (imf09.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690178545; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ryhz3mbx2XFWeoGwOGZ32Tcpi8SY5JJxpHU3GUI3ZDI=; b=1zUxhMvXcmdDWP1xjeSQZmEWGUXyXk4tegCDZKncftcjXmxKYVLNPIeEbDTuQdodt6IKBK rij8bzAf0DiRzRpO2lpJb31EFTm9CYfhmRbdXx0NKOyC3aMsDCQ9Vz5otgqDjs/TB3hIbu IoHnSsjrY5VcOwzmhQkpEQgF4Ym1yKA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=d4XF99La; spf=pass (imf09.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690178545; a=rsa-sha256; cv=none; b=mDk4Cv4pUhlBCTAG5IVX5RrGLCeW7jWxf7bXewseNf/1FQbsC2ON39aSqxqFpLE+k7fNAd C49LWcBl7Elsa2vBC9jR0gP5xXsMPCrjzqBaShAsM+KFn0ybKPtsrtcZ01zx03hhy6gCQU htiwfA0dayskWBcM8Nf9ro7GECean7U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690178544; x=1721714544; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=hJeqyaPA2/UiA3SdbIjwXePXzRG8vLnfEgD/5hSNAoM=; b=d4XF99LanMXM3NugG2/BA4D1W8X0sCY50va/AfUY+idTPXJ/LPVedVgM sxkowNNYmr2g7j3isQ/GjZKFIuvE/kTlWTVqbh2caU80um9cWG9tHrzsu lDihJMXphhXEzwYpIuo0r+CXThmgh8v1aRxd9b6UcUloG9C+32ahIkmgN ueLgfGMdB6hGdylWApg/ZWYxeYRiqrLqoZhYR72vmnfnhkbISh63TBZr1 rRVC3ZlgMhl7DYm/J0AUunuhd4DmG3WS+SGP6ZmHVfTQm8x8EgP+m8Nu2 UM9SXmbImy6gaB1e9guJvXJEgR57QhsU/5T3eJhB8FcVGe3eOkWqqPk79 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="366243577" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="366243577" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2023 23:02:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="849500142" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="849500142" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2023 23:02:11 -0700 From: "Huang, Ying" To: Vishal Verma Cc: Andrew Morton , David Hildenbrand , Oscar Salvador , Dan Williams , Dave Jiang , , , , , Dave Hansen , "Aneesh Kumar K.V" , Jonathan Cameron , Jeff Moyer Subject: Re: [PATCH v2 1/3] mm/memory_hotplug: Export symbol mhp_supports_memmap_on_memory() References: <20230720-vv-kmem_memmap-v2-0-88bdaab34993@intel.com> <20230720-vv-kmem_memmap-v2-1-88bdaab34993@intel.com> Date: Mon, 24 Jul 2023 14:00:34 +0800 In-Reply-To: <20230720-vv-kmem_memmap-v2-1-88bdaab34993@intel.com> (Vishal Verma's message of "Thu, 20 Jul 2023 01:14:22 -0600") Message-ID: <87sf9d26il.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: AB312140004 X-Rspam-User: X-Stat-Signature: ng1z61buk9q5swgc6bkzd4a74wug9z8j X-Rspamd-Server: rspam01 X-HE-Tag: 1690178544-219829 X-HE-Meta: U2FsdGVkX1/m9rk25Ty9/HQvtPMjPeE9q3jZZ+a5FVIuxMzWllkz/AhuQZAudjpfSkf9WeCHN9L6XMWsh30DsPohjpkjiZeUSeQCs9ZQxMTCfvk2cvcg79GxyX3FS6M2P+JFh6u1dLfL9ZomXONCtS0r0eaNAyjXl/hD5uj5PRTZB67PM1K3aHueWIJIj1hWwNNVLePew7PmoePSR9L5Us9RCfId4nm4xK4GOfhg87chofmIWcvR58FfHft98fX0CCkwZDpOx1i/iueCGxwd3J99lJl6B/4CYl2Dg0+Zlr1YMmD0mFB1N2WQdFeBpRydtyAvMraXJBe9IjwzmUcIOtYqXhkOuK4IggsDXRo0mEX42f+afOdxjQSTRrkm5h+t40XpVg5XrMkmVPjqw/V43U00x973bQSjAXmP4JDZsuLV4nyxyaMVd3bgL9zwl7A5K1qFFmBwxTFn4GjB1bKFhtDscme92Udp+t/LVq2mrDIs2o4ti4FlXioK7YcaheSkaxJZWaICr44c51UMKTsoiErmDGBF8kmWPWg0JwQ16IuINTPGnWCBNnOPuXMGOODYY6mL5Sm8bjuPCw94pCg1NKRC89qpSrROcfJwllo2JFeleg7qDLiI0xda4jAqOPvpDNspkoioqvb4tY5d4I4IZobQXgKzy4D7j7GTbV9SgZ32uGB+MXrMP0eoCoCoLNx03vzgBGh1SaypfxQ6TpBbwn6sMVR/kODheSR/1N03+dhEB2utQQSD3rNXNKRcZQ7+1oTiq0u68tjBPoMB19/8Qk7AlrLnO1cGyr04WQ23MUrAuKZmPZ6RYJyUQbuzD267CyyTZSmCi1F/dFO4bU3diGrWUdbiTQ3BTVCnM7Ie6y6Smwk+Hha6r7W4ZbpIxz0U6L7i9otgLWiMTtHfMop/SSfbb7EuriobuNbAwJ5uJ28I/RriIDumELLIy5/v8fRNtae4ANT/8Lt9YwurvPb Ac4mxdr6 MG2gRRTG66368C5xOa1sG2jjV5SzxZYdnKhFhjdPN4AI5JCRIkNXf8DblSdKhGW996fzQZGqufBwHndJ3pwNDme4/dIYcVjwTBXv5YNyYfwSmDi6y84n658yWD+C0i02/6OM4u/rgeGvxT6YaxG5T+YGuDrJ872cijpunJctaumh9UAI9u7Hz1YVOK1ZtY0mYY5AOETnBAyOV/W2LURA4//3uu4Hblx5Ow8h2qvS/7cRsBO07nx6SaqPg+wp9V+a0AqQlITRNDxih52Ytdq7tGzN+bbQ2FItSIV7acS+LSE975lk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Vishal Verma writes: > In preparation for dax drivers, which can be built as modules, > to use this interface, export it with EXPORT_SYMBOL_GPL(). Add a #else > case for the symbol for builds without CONFIG_MEMORY_HOTPLUG. > > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: Oscar Salvador > Cc: Dan Williams > Cc: Dave Jiang > Cc: Dave Hansen > Cc: Huang Ying > Reviewed-by: David Hildenbrand > Signed-off-by: Vishal Verma > --- > include/linux/memory_hotplug.h | 5 +++++ > mm/memory_hotplug.c | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h > index 013c69753c91..fc5da07ad011 100644 > --- a/include/linux/memory_hotplug.h > +++ b/include/linux/memory_hotplug.h > @@ -355,6 +355,11 @@ extern int arch_create_linear_mapping(int nid, u64 start, u64 size, > struct mhp_params *params); > void arch_remove_linear_mapping(u64 start, u64 size); > extern bool mhp_supports_memmap_on_memory(unsigned long size); > +#else > +static inline bool mhp_supports_memmap_on_memory(unsigned long size) > +{ > + return false; > +} > #endif /* CONFIG_MEMORY_HOTPLUG */ It appears that there is no user of mhp_supports_memmap_on_memory() that may be compiled with !CONFIG_MEMORY_HOTPLUG? -- Best Regards, Huang, Ying > #endif /* __LINUX_MEMORY_HOTPLUG_H */ > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 3f231cf1b410..e9bcacbcbae2 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1284,6 +1284,7 @@ bool mhp_supports_memmap_on_memory(unsigned long size) > IS_ALIGNED(vmemmap_size, PMD_SIZE) && > IS_ALIGNED(remaining_size, (pageblock_nr_pages << PAGE_SHIFT)); > } > +EXPORT_SYMBOL_GPL(mhp_supports_memmap_on_memory); > > /* > * NOTE: The caller must call lock_device_hotplug() to serialize hotplug