From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5974BC4345F for ; Fri, 12 Apr 2024 01:36:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B55566B0083; Thu, 11 Apr 2024 21:36:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B056D6B0087; Thu, 11 Apr 2024 21:36:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97E686B0088; Thu, 11 Apr 2024 21:36:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 798796B0083 for ; Thu, 11 Apr 2024 21:36:31 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 233C0A0D3B for ; Fri, 12 Apr 2024 01:36:31 +0000 (UTC) X-FDA: 81999164982.11.3086B3C Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2047.outbound.protection.outlook.com [40.107.94.47]) by imf23.hostedemail.com (Postfix) with ESMTP id 6B93F140006 for ; Fri, 12 Apr 2024 01:36:28 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=I+28cKG6; spf=pass (imf23.hostedemail.com: domain of apopple@nvidia.com designates 40.107.94.47 as permitted sender) smtp.mailfrom=apopple@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712885788; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7L1gEjY33BMy1U80OmaWIID7Jiaud48obFFkVz7G0Ms=; b=OcTXFY5PVwuo3naUeHqlD+yLIoZTrrJUCt6uccsqPsHY8tIGxLAZ/CxwVQ69jaPgCzdu4F 4+0YDHAuPgzUzEjQJ/aRxoGVyyShVmLhwoIpcHgkGn2u3UMml/PqOovmoDYFGFIENGUk2u P2i2gLoxS1fUl4iQm485NyrO07oiNM0= ARC-Authentication-Results: i=2; imf23.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=I+28cKG6; spf=pass (imf23.hostedemail.com: domain of apopple@nvidia.com designates 40.107.94.47 as permitted sender) smtp.mailfrom=apopple@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712885788; a=rsa-sha256; cv=pass; b=6vLfdiTN4qNtEH9VJDvmS7cZwz1belcg+fvoTq+wYbZMLbwOZygNl+B8d9UoACHqB/QBk4 KA+BKdkqlrdHaM0+QfDxpoDPkB9XxiREkacJatk/REGRnAGExiCcKwOVgAFy6+0/MEHZ7w /j5Z9XGoOmuiw8q6Wu2LRsVTscdN7G8= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TPecBQQG2/AySmILIj5L7KCcgYITEZGakxgHPq2omdcK+YyMHWI3no2/9PLbBVeU6F9CrhYuiYjxs+HbbXwyVEBnEWgaKGpE97Y9sNoSu5utB5Alpum8ExbP0F+2cUD6laWSBvMxFMd628gwJbom4W9KY95/8LNcm9AtsUNSaRnxfl6GjDTJqb4WIYkED92jroxAeqTZoDaafSdXIaQr9ILLrnfBk9vsG57SuP971YkxTHoft3oixWT/SapR7lEkfeHNeRHaB+k7zq5JUxSvp9i3Iq3vl92l7vmdPRmaHCvniAUz9sVhcvvgJagmQGesTKZ2UFe4cD99zA4fLInLBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7L1gEjY33BMy1U80OmaWIID7Jiaud48obFFkVz7G0Ms=; b=DfY8XvP0SgNF6WEr+13qDEBs6M41cD8O6CmXaIowrKr32pId9g+QrssIvCTWVcWNcciSVyj2w9W0sbJugmqJy6WbMAnDIieqNWzvNl9KVIktmNCJ5kFRUIP7hEieLsOTBTuZF5YZn8qdJs7HugmDxf0JtQ9oBlNP6nx12D2Sff0Hw54lefcW3H52viNtjC3uHpkFHq9Rj846/w+zeJhW0xz4OfoKA7HQKzc9q/JHh8cwyEJR7DrJS3ILG2C1Z2HZxvI6yNvzRKMa4TD69YgcmSd20ruJO0nfmoaMjbkMDQKYf7xhAqO4sui+AVXI8bDEfC+Bqluv5uD0bZMqZNwfWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7L1gEjY33BMy1U80OmaWIID7Jiaud48obFFkVz7G0Ms=; b=I+28cKG6h8AdLGayY7Z+5RmhZF9M7APU8Vk7/mYs4JxbDTDsJZNlL6Dw2BHShTpA7Jtxz3Dlod/DekEY4NeoQNbQz2vHfq1WzS8NNVFrv39KWzK1x6VeVMEXn9EzMHA4J1CdWSgCNeaWDzp1fQiNiF3kJNyn11HBHwohngTF5Vd7SyxkHizVhpjV34jgK8qUGSJCxAul/bFZnr+6Tn1axv4liHqMq7jvFy089O4tjQV74nzkPyz5RcI+CDq44yd3GsBzgzCVeE5fzyChNQjuol4/mwWu7XUOb7gOsR/2u26ijvhH7tJ9cZAV/JuHoyP0UJFj+wDAyJrhF7XLWGKBmQ== Received: from CY8PR12MB7705.namprd12.prod.outlook.com (2603:10b6:930:84::9) by MW4PR12MB7440.namprd12.prod.outlook.com (2603:10b6:303:223::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.26; Fri, 12 Apr 2024 01:36:25 +0000 Received: from CY8PR12MB7705.namprd12.prod.outlook.com ([fe80::e71d:1645:cee5:4d61]) by CY8PR12MB7705.namprd12.prod.outlook.com ([fe80::e71d:1645:cee5:4d61%7]) with mapi id 15.20.7409.042; Fri, 12 Apr 2024 01:36:25 +0000 References: <68427031c58645ba4b751022bf032ffd6b247427.1712796818.git-series.apopple@nvidia.com> User-agent: mu4e 1.10.8; emacs 29.1 From: Alistair Popple To: David Hildenbrand Cc: linux-mm@kvack.org, david@fromorbit.com, dan.j.williams@intel.com, jhubbard@nvidia.com, rcampbell@nvidia.com, willy@infradead.org, jgg@nvidia.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, djwong@kernel.org, hch@lst.de, ruansy.fnst@fujitsu.com, nvdimm@lists.linux.dev, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, jglisse@redhat.com Subject: Re: [RFC 09/10] mm/khugepage.c: Warn if trying to scan devmap pmd Date: Fri, 12 Apr 2024 11:34:11 +1000 In-reply-to: Message-ID: <87sezr5pm3.fsf@nvdebian.thelocal> Content-Type: text/plain X-ClientProxiedBy: SY5P300CA0060.AUSP300.PROD.OUTLOOK.COM (2603:10c6:10:1fe::15) To CY8PR12MB7705.namprd12.prod.outlook.com (2603:10b6:930:84::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB7705:EE_|MW4PR12MB7440:EE_ X-MS-Office365-Filtering-Correlation-Id: 8630557b-a176-4b74-034e-08dc5a90f741 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lQCKsggHJmQJN7mFKGY3oWKo3RDscLZZfnF8CYqtVlQUWONdd7/Ht3acirrD32Ejn2SamBQdAFb46iFV0ifruuFKlI4+5I2Aqq8SzilH5nRxdyytfvaLgKnYEdO7m0YsXuFeU6Lztp0nLQledytg1VsvjMp3o/vxZZ9E7pED169S42RY1rfcmZQeXZK4rVqQnZUoeYUXNLd97LoGNpsgMEm7Ei66/l4vJdDRWc91iFgzwmHSepigc0GJ2k+kLNAyqPaQzK0RS3Z2lf7xJk01dhvs/gFd6v31haaUGQImH1Q28l33jaeo1USCWZ2fWsINC6JqQ736+oXIwuU5U5EJ9kE+xImSkQloMIL7+fQAwAT3/cyYb3dXvVto0OtZdbVq//b1imsBDCK5PMn7ggvK0ZRjBpNl8Z3wJo0/FgimpGe1lMdLis5VfDhNuTX2ZU+Cf5TLz/mjYt1QdX1k3WiWBifeGTs2RQMFlY8cGgPoItkRJQQ6ZDJqd4jYC6p/vX1IC9b/KGGFzEJ+vQXG+S4J+AK+2MJ3aKf3MynGDu3G6lEJ6xK18s25ILEFce7e5cuTRdHzcMCYyX+p7SyoRbrrU4LKojcMJED1NHDptwrWI6slKvCvarG2kO6LFV6beg+vXtmB++2G/mWrack8M0tDXgWbduAOglkKLUQctPotPjI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB7705.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(7416005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?btcZdRBcRAIiSR6KDm0qqTdTqc5g66Rv6iVm0hrRvzwXo5Wfxi6cV7/vdUnC?= =?us-ascii?Q?AmdnH0ljHN0ipmS9uNz3Iv6LhMYLUQWKqM5+ty0GIRYjXjkWT06LVnDmQhe3?= =?us-ascii?Q?eSSsfjBsGuckSZysx/+ywrCrYTZzr2bXJHEjZnWE6zAB2LJr8EmXTlo9CPHK?= =?us-ascii?Q?pDfjBaqfv2mNf6LW46whwT1oO8nVe/y44mkHPQnWIDUCzC1NbHGYd5aTfrf9?= =?us-ascii?Q?5DibneJGy0YKFIkNf8HCstDGnKs/IkTz77Ks4rGKdw0rAOaW95qlhSkLSSwb?= =?us-ascii?Q?6zYzfWTUbV2IosB1iduZsOxFWk2/xwq8Gnf/+dX8Kc5U265gnVcpCs/lVWHf?= =?us-ascii?Q?sP4ns2u2iO0JhQqpgRiO+W5cMOkPQ4/3/Yru+KYLD+JQy5bReAJpkn923Prg?= =?us-ascii?Q?0+41rgZ7K+FVzFQYugmOZJpqcbn63oavY3IFdr1uqVIit7WhudZULSfTdbIG?= =?us-ascii?Q?vRhCzUlq6g4She3MmzNGdzOPMnfHHHa/lVw/OugzR3XPpvgCUZuG7gl13n+U?= =?us-ascii?Q?iKzsz8KXmNNXWiD80qrBW9UA3WN+YIlzoEICNRDsBVquAo48/VLjwHNi0x/Y?= =?us-ascii?Q?M1ORBE1jzv4co/5b1eHfKkyKduqL4A65BF4r7j0xFXoWwkJ0IShbhPu2jxGj?= =?us-ascii?Q?cGvX8swti9eqtPL2otVsPUxG+TwDewJ8yWYV/8Xzqvzohn+RfKn1no2y1ZUl?= =?us-ascii?Q?SvCLhvoIshDUiogKk8rZVcOLP1E1xH3yG4RzKEjdBO2SZtYO4UE3og/0E2rq?= =?us-ascii?Q?5HcnXJanp82zeSZvGa9mtdTiArIoZ2hAA+046hizxqKFs1W1sKGRLowi3NIc?= =?us-ascii?Q?vsE8kKaErtsxwluFBkQ+Ckn++9+dSqe2Jv56hrqX69Y2wJnoVGdt12H2aCpb?= =?us-ascii?Q?jNFmhMbKakN73P+O+RS9RfarMQ/GvKN0QZ2MvSlBZxLqgh9gg30CGPO7rSOG?= =?us-ascii?Q?+QwxCL/FwYFyspzJw2F4iRdKRvw+u7qStIaTSavuJShKGIz4jFRBO+VfJwxX?= =?us-ascii?Q?rvSBO+dnqzJFGr+sjxSSTFddnx5B0y2bl28FhvtouscqQJsVtx8koaMrhAFQ?= =?us-ascii?Q?Z2mlPklAOO4zCX3gJuTq+RFcRDNwQJM80B7g1TK5+UGXkw2f5Cb/RrWzlpK1?= =?us-ascii?Q?pateu7s5pjREq6AmMeSRqFK4yTS2PDfqK6VL7KK4bOQBq0ffo91/lNiRc93k?= =?us-ascii?Q?odVlgMCTOEelQVGaDW16ExGZdFbMVEUKkM50FVY22ZDcQnOgjqrs3QX01XBh?= =?us-ascii?Q?aInegVPFJWdhYANfuU3vNIDamptA93DLv53bI6Vjvcj5NZDfZLyLASYsR4dX?= =?us-ascii?Q?83K3f7c7tRtNbq+x/hv9l31HS0ubYOsJf2OEBUBn1UzUAJoOkDtEiDJT9c80?= =?us-ascii?Q?FGlleGCyCEN1MPKrPUka3U9zQDlBV++q3NC0/UU8cLdJvIQ8YKFqgTa4iWIj?= =?us-ascii?Q?DdtGEBGogW/NFTCiyKwuGrfrMoSLb77tZWhUeAvjedYB2J+y45g7Nd8M7yra?= =?us-ascii?Q?pImsBqd5I6/bMmePgGB9OjrU7QovSmA870Rne9/dPkk7dJ/z/Fd+dkAdba6T?= =?us-ascii?Q?hdAaEYi7UM9x0gCaVlSWBmVaqYp9Ryl24vudyMKJ?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8630557b-a176-4b74-034e-08dc5a90f741 X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB7705.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 01:36:25.0811 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DxC2j/PJgv4OOlfmR8fn3n+0PT9Y/fYiboYc6QKZhB/HfCosxSLm5+tAaYSNEd0wPTp7etzPZCzFwioq9OhEPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7440 X-Rspamd-Queue-Id: 6B93F140006 X-Rspam-User: X-Stat-Signature: bnmwdwks75wf3x4spppgrtyu8xw8rogz X-Rspamd-Server: rspam01 X-HE-Tag: 1712885788-628696 X-HE-Meta: U2FsdGVkX1/YRrd2WKtLGg3lfktLnWfEReJ8dPIWhfLcSoaGjakdPqtnSh2tb+wdXvF8LtKuRcah3AnXIGKfckVYGurpPgnUkHjfkOJQAedPzJY1Xjx97uAVAc9Bcpu56GnpJF1KZf1xijncmUkd3jtMzAHytOe2ir4t90itKLLFwvNfESlxHDNH+XObQkjqHC/O4vcg3/BaYjOxwb+1LV3/Cp+sd0E4yKRUoaBInoAD4XC06Ey6R0q87XQhmGsqjCk72iXVdslPITTU8zSssBcJLdWCRHLbKll1KSQb2IapOPcNt0xeGwmMK2JuQTSctStPondlub1eKRK4Zq/zYbJtWeD3skntJ9qFujweLm81bX9o59EMuu6jsiBvZcCtMFmJw215DOR48t7mwqKrWMu1KDTuT0NvHIpF416c+6BEKfxS9bCxHRmQPxyJifA728JXRyKJwtQuupScG6IW53VJpQOoaE7WPjVL9kpaVz1254x0qqZhtn9t14fzJSfR/WCCJkPJzah3bR9isSjpY7qrhZluBqRElm/5EpGEFZIoWrEdd1fH1+01b/G8K5xoF6aVg7+39sHPjf6jLekC7LJwYxuHR9LtaTxYpdphR1LGcyplKZF7oUPNGapLCimTKjjZmEJmwKaxwYySdlH/VOcllS0ZeMRebUVF4rvIlLyZCus9SFPvQYdODUvkwl60i8gQl+7sqmP4CVQ0RIWldcpAL74KMHrSwlq32ejxLhE1G2XN9YE3lYrvOPHuna4R2R6fvQetT6l202/zTkzUwvVRHjiDyZfl82UilYiXgrPp9lhj7sSq+nNTPoTsDlsPz1nsNmqx57a1yhSelaZWslSTqexl/Uw2C9bui3GhtZuwtAKRe47rgjmQvbe93fNdcclKAJoj8RKPPiUsmKQcQ4gkORdE7nZ728SnG9wW2Bh7UXYyllllSN34jp14I9xthmUBGGKeFE4gBwXAZ3W ok0dJ60m 0kMtc2f5zEniYzkb5mgVPEOA2Ut2REaTMt6AokBAaQu1ZLr3lKnmFyfMmj5/7vHM6b1gNW6iDMVuNab6MtC4EJRokRfZU3cJtdBNKYNd2dHi2eT0wdF1xdRGkEoTgh6CreqDi7xaAosTL3NyHCI0X0Z6IAG/L2AWx6O8LTcI17CWvJ9Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Hildenbrand writes: > On 11.04.24 02:57, Alistair Popple wrote: >> The only user of devmap PTEs is FS DAX, and khugepaged should not be >> scanning these VMAs. This is checked by calling >> hugepage_vma_check. Therefore khugepaged should never encounter a >> devmap PTE. Warn if this occurs. >> Signed-off-by: Alistair Popple >> --- >> Note this is a transitory patch to test the above assumption both at >> runtime and during review. I will likely remove it as the whole thing >> gets deleted when pXX_devmap is removed. > > Yes, doesn't make sense for this patch to exist if it would go > upstream along with the next patch that removes that completely. Yep. I'd had it to sanity check my own understanding and figured I'd leave it in the RFC series to see if it provoked a reaction from anyone. Will drop it in the next version.