From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9B49C2BA18 for ; Fri, 21 Jun 2024 02:35:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E31F6B048E; Thu, 20 Jun 2024 22:35:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 494176B0491; Thu, 20 Jun 2024 22:35:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 333C06B0492; Thu, 20 Jun 2024 22:35:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1565E6B048E for ; Thu, 20 Jun 2024 22:35:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C806814075A for ; Fri, 21 Jun 2024 02:35:39 +0000 (UTC) X-FDA: 82253329998.28.9BA2C4C Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by imf26.hostedemail.com (Postfix) with ESMTP id E4EDE140010 for ; Fri, 21 Jun 2024 02:35:36 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ccaQTAtB; spf=pass (imf26.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718937328; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Bf1hAF/PrnPDIYkDb77hh5EhckWpbBcVi8DfjQNfPis=; b=FaUcOD2UsY0F+CjRlIT32w/6js7uo13sfpXYkB6v/8Tb+MOGvN+y5xSfPl0z61x1ItNUX2 mkht2WGpt2XFxC9CoxQF7x3GqmuMWKUKpRCAN+3ANbiomHkTnT+TZgwTCkI3KhKe9ZhFr2 gWYTtrlvCVNalBZ6ss0O4nS+4tSegTU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718937328; a=rsa-sha256; cv=none; b=AiJnWdBJ/hY7QsTLsacfGqbOPI6V8djrKa14BoRWB9OaSqvd+B694GDNbiuD02COOAYzZc l7XduHj2syPc4ps2MCSsv1o6FoXbPUE7Mf/anCNGeyIH9EK5M9XQEDCwRlidGlaq+2KhNR khhczRNUVQ894THOCxEagEyBhZ/TN84= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ccaQTAtB; spf=pass (imf26.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.15 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718937337; x=1750473337; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=cFrj54EHqVH+PxtlDbxJQZRdDgSVfzfm3iOshhgQvNI=; b=ccaQTAtBzyB6vCSR6Nl6wVvV07mCa+i3rqRdffQeDHuYEROXYWOYmyIx eQhByZdSzbBeDkcLTZp763DmcHU0fxGzj9g4ZjmXRK0tYseqZYk/LEc6R L9itjYcHLEl5GxzuPfjmZd3lh1jpNvh5rHR7EsQTRAGAYmlS3tbWDvz3U d/PxKuxCrYQAfecGvctQDl/ZSXFYTp+D9a3PUCeCJXZvlsc+RxPhuVKQm zYCbgYj4b6ieYxhyNjAZW+ReTA7ytwmfSodbiAgplnOMiJpeqCiwt5+h8 UzBf8eS3ELqfxWo2lHjtKzNGsL8I0qW8c4jd4a0ByYBy2l19TqsO76exP g==; X-CSE-ConnectionGUID: 8sB4/j5wQi+QpHCHiZfl1A== X-CSE-MsgGUID: /Lv8AFs3TlGPTfNaDSce1w== X-IronPort-AV: E=McAfee;i="6700,10204,11109"; a="16098516" X-IronPort-AV: E=Sophos;i="6.08,253,1712646000"; d="scan'208";a="16098516" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2024 19:35:36 -0700 X-CSE-ConnectionGUID: JQ6mUdRcRLC0P+eh/BlGEA== X-CSE-MsgGUID: 4Dt0LsHsSR28BkTekb6V7Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,253,1712646000"; d="scan'208";a="42526110" Received: from unknown (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2024 19:35:32 -0700 From: "Huang, Ying" To: David Hildenbrand Cc: Ryan Roberts , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, shuah@kernel.org, linux-mm@kvack.org, chrisl@kernel.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Barry Song , Philip Li Subject: Re: [PATCH] selftests/mm: Introduce a test program to assess swap entry allocation for thp_swapout In-Reply-To: (David Hildenbrand's message of "Thu, 20 Jun 2024 13:34:02 +0200") References: <20240620002648.75204-1-21cnbao@gmail.com> Date: Fri, 21 Jun 2024 10:33:41 +0800 Message-ID: <87sex710u2.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: E4EDE140010 X-Stat-Signature: ny1oyinhxrbqpkdugdbzyrnmbhwtx17q X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1718937336-433250 X-HE-Meta: U2FsdGVkX1/fuHb/GHDVAkXJWg9Q8ctcbaJcJRXbR3rJG+lg4R5oMvEy+khy3KrFk39Nd65uBa4VOJoPOjLXj5q7Qbn8EoQEVX879T8F8e9HlNQBdwRzzyeU80RRg53h623PtyFONa2WJoeW2q166OOy7hiGEDq8MmliWQAqE0zKGk5zhu/j6M+OR0QKUJ9bGnB3Je/WWYp/IJDrJGRqFpKtheZ+L7z8KSfw/wF0/u+vmls35V+P7TR7w2wNHnifsfUAKyt9+3CTe8/ZKP7+kZuMCg3cHe/siQvKWlzFZB+056oanAxxxYAroFG59G3BohH9WmSDf/Rszh2JGoZfoyhkucmHozSnbAeUkCbWgGlaDvykD4mdws6/oW3pFaNzaxGADc/wSF7St3aosDKwrIIBvLMvIeH1FcAFSuRhcDPuOtT4v9psR3vEM2q+eNuEMBJ6wSGyng7ZrMgNm3TgoUcq9/TpmOZUk67LBvajLzwaQo4XpzhTbYQpnYdMNd1xp1fLGi9l7Ga+kFiZykRwzC+a/yJiaYgyqv9D59T3q7nLc/Svqf+URpGriDXNGml0B4ad9XMHKaCYDkrBrSJcP4IXBmJxirRmRr05AcSIO651PZlIN1MTqJkF/YCF/cIkmhE+KDqhvQNF/JYJRLo7bPAePbIsZ4v+IpLKMPreAzVqi0gqOiL8ybrRT5rRQtzgkpCyGcq9da7mptYPUIOUbKLYe+9RYPxUa7zI1Rdh8NFG2C1cX7s+2FZSwah8qnGCcO6E2+f3zfi0edydJkXxd2Nar6c85aAN51PJhcJzOtRbWMV/ikT7NwikiDipan6L1Gk/2znZiWqu7h7n7umQO0kiuDIwUAHjmeXT/D9sjmHj+o9k7miWd8UOtkjvPtIxyrOXQxMLGzfNWH+FPHSqqckEgB/sHSqgoJeNvKzqcCT3DRFx/SygRjy3xkKnloDqKv+zc44UR9EMjY4pg0g dHyWVGbB Fqzh29mw9VFUxjQeX1sqYUOImT5yFpNJ0pBstmfZr5C0giQbYKmHwW6VTokUvtMZilP90Y8XYDLyVCdjFNJKi2fPoGBCcjV8Zo85Yfl3F8W2RAqZUW+Lr6RDMbDzCoOrBncSzbuw7AXRQgoInx34P0fjQQEWI6qcV91sCsYn4jzku0tvLKUjxliknccQkqeaGuPJUDpBldpN9hr/6iIMSOK3UPS8TetjqdCjPcfbxIJAWnqwsqfXEBvY9F98s/G/CHA1+2CMZRKH/ILJ1G1NAQsZ9ug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Hildenbrand writes: > On 20.06.24 11:04, Ryan Roberts wrote: >> On 20/06/2024 01:26, Barry Song wrote: >>> From: Barry Song >>> >>> Both Ryan and Chris have been utilizing the small test program to aid >>> in debugging and identifying issues with swap entry allocation. While >>> a real or intricate workload might be more suitable for assessing the >>> correctness and effectiveness of the swap allocation policy, a small >>> test program presents a simpler means of understanding the problem and >>> initially verifying the improvements being made. >>> >>> Let's endeavor to integrate it into the self-test suite. Although it >>> presently only accommodates 64KB and 4KB, I'm optimistic that we can >>> expand its capabilities to support multiple sizes and simulate more >>> complex systems in the future as required. >> I'll try to summarize the thread with Huang Ying by suggesting this >> test program >> is "neccessary but not sufficient" to exhaustively test the mTHP swap-out path. >> I've certainly found it useful and think it would be a valuable addition to the >> tree. >> That said, I'm not convinced it is a selftest; IMO a selftest should >> provide a >> clear pass/fail result against some criteria and must be able to be run >> automatically by (e.g.) a CI system. > > Likely we should then consider moving other such performance-related > thingies out of the selftests? I think that it's good to distinguish between functionality and performance tests. For example, 0-day test system will use virtual machines to do some functionality tests to improve efficiency. But it's not good to run performance tests in such kind of virtual machines. -- Best Regards, Huang, Ying