From: ebiederm@xmission.com (Eric W. Biederman)
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
netdev@vger.kernel.org, linux-mm@kvack.org,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH] fdtable: Avoid triggering OOMs from alloc_fdmem
Date: Tue, 04 Feb 2014 10:57:05 -0800 [thread overview]
Message-ID: <87r47ik8ou.fsf@xmission.com> (raw)
In-Reply-To: <1391539464.10160.1.camel@edumazet-glaptop2.roam.corp.google.com> (Eric Dumazet's message of "Tue, 04 Feb 2014 10:44:24 -0800")
Eric Dumazet <eric.dumazet@gmail.com> writes:
> On Tue, 2014-02-04 at 09:22 -0800, Eric W. Biederman wrote:
>
>> The two code paths below certainly look good canidates for having
>> __GFP_NORETRY added to them. The same issues I ran into with
>> alloc_fdmem are likely to show up there as well.
>
> Yes, this is what I thought : a write into TCP socket should be more
> frequent than the alloc_fdmem() case ;)
>
> But then, maybe your workload was only using UDP ?
As I have heard it described one tcp connection per small requestion,
and someone goofed and started creating new connections when the server
was bogged down. But since all of the requests and replies were small I
don't expect even TCP would allocate more than a 4KiB page in that
worload.
I had oodles of 4KiB and 8KiB pages. What size of memory allocation did
you see failing?
Eric
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-02-04 18:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 5:26 Eric W. Biederman
2014-02-04 16:18 ` Eric Dumazet
2014-02-04 17:22 ` Eric W. Biederman
2014-02-04 18:44 ` Eric Dumazet
2014-02-04 18:57 ` Eric W. Biederman [this message]
2014-02-04 22:48 ` Eric Dumazet
2014-02-04 21:27 ` David Rientjes
2014-02-04 18:25 ` Cong Wang
2014-02-04 18:53 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r47ik8ou.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox