From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F9D8C49EA4 for ; Wed, 23 Jun 2021 08:00:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D7EFE60FEE for ; Wed, 23 Jun 2021 08:00:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7EFE60FEE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D63748D0005; Wed, 23 Jun 2021 04:00:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D39F68D0002; Wed, 23 Jun 2021 04:00:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8D568D0005; Wed, 23 Jun 2021 04:00:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id 81F0B8D0002 for ; Wed, 23 Jun 2021 04:00:02 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B1D2F82E5929 for ; Wed, 23 Jun 2021 08:00:02 +0000 (UTC) X-FDA: 78284240244.14.7BD5C74 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf29.hostedemail.com (Postfix) with ESMTP id 5103C7AE for ; Wed, 23 Jun 2021 08:00:02 +0000 (UTC) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D83F611BF; Wed, 23 Jun 2021 08:00:01 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lvxnj-009KoG-E4; Wed, 23 Jun 2021 08:59:59 +0100 Date: Wed, 23 Jun 2021 08:59:59 +0100 Message-ID: <87r1gtau4g.wl-maz@kernel.org> From: Marc Zyngier To: kernel test robot , Paolo Bonzini , Vitaly Kuznetsov , Ricardo Koller Cc: kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 12154/12271] tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception' In-Reply-To: <202106230606.sNbagz4E-lkp@intel.com> References: <202106230606.sNbagz4E-lkp@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lkp@intel.com, pbonzini@redhat.com, vkuznets@redhat.com, ricarkol@google.com, kbuild-all@lists.01.org, linux-mm@kvack.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of maz@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=maz@kernel.org X-Stat-Signature: 3hfhqwar187ct4m6a1tidiq9aryrqdkr X-Rspamd-Queue-Id: 5103C7AE X-Rspamd-Server: rspam06 X-HE-Tag: 1624435202-800002 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: + Paolo, Vitaly, Ricardo, On Tue, 22 Jun 2021 23:54:17 +0100, kernel test robot wrote: > > Hi Stephen, > > First bad commit (maybe != root cause): > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 4238b1710eadd18dd16de0288a2bc5bb84614b4e > commit: 954e285eafdd4ac36b114a7f6abce3f792591ea8 [12154/12271] Merge remote-tracking branch 'kvm-arm/next' > config: x86_64-rhel-8.3-kselftests (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > reproduce (this is a W=1 build): > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=954e285eafdd4ac36b114a7f6abce3f792591ea8 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 954e285eafdd4ac36b114a7f6abce3f792591ea8 > # save the attached .config to linux build tree > make W=1 ARCH=x86_64 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All error/warnings (new ones prefixed by >>): > > x86_64/hyperv_features.c: In function 'main': > >> x86_64/hyperv_features.c:618:2: warning: implicit declaration of function 'vm_handle_exception' [-Wimplicit-function-declaration] > 618 | vm_handle_exception(vm, GP_VECTOR, guest_gp_handler); > | ^~~~~~~~~~~~~~~~~~~ > /usr/bin/ld: /tmp/ccIBsVo3.o: in function `main': > >> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception' > collect2: error: ld returned 1 exit status > -- > x86_64/hyperv_features.c: In function 'main': > >> x86_64/hyperv_features.c:618:2: warning: implicit declaration of function 'vm_handle_exception' [-Wimplicit-function-declaration] > 618 | vm_handle_exception(vm, GP_VECTOR, guest_gp_handler); > | ^~~~~~~~~~~~~~~~~~~ > /usr/bin/ld: /tmp/cc7zqGvp.o: in function `main': > >> tools/testing/selftests/kvm/x86_64/hyperv_features.c:618: undefined reference to `vm_handle_exception' > collect2: error: ld returned 1 exit status > This stems from the following commit: commit b78f4a596692f6805e796a4c13f2d921b8a95166 Author: Ricardo Koller Date: Thu Jun 10 18:10:15 2021 -0700 KVM: selftests: Rename vm_handle_exception Rename the vm_handle_exception function to a name that indicates more clearly that it installs something: vm_install_exception_handler. Reported-by: kernel test robot Suggested-by: Marc Zyngier Suggested-by: Andrew Jones Signed-off-by: Ricardo Koller Reviewed-by: Andrew Jones Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20210611011020.3420067-2-ricarkol@google.com If there is a stable branch with this patch on it, I can take it in the kvmarm tree and fix it up myself. Otherwise, Paolo could take the stable branch at [1] (or even that particular commit which is right on top of v5.13-rc4) and do a similar fixup. Just let me know. Thanks, M. [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=kvm-arm64/selftest/debug -- Without deviation from the norm, progress is not possible.