From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83B92C433F5 for ; Fri, 4 Mar 2022 16:14:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F10578D0002; Fri, 4 Mar 2022 11:14:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E97F28D0001; Fri, 4 Mar 2022 11:14:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D609A8D0002; Fri, 4 Mar 2022 11:14:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id C05BF8D0001 for ; Fri, 4 Mar 2022 11:14:14 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 7ED78121EFD for ; Fri, 4 Mar 2022 16:14:14 +0000 (UTC) X-FDA: 79207200828.09.AF67C68 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by imf16.hostedemail.com (Postfix) with ESMTP id 9605818002C for ; Fri, 4 Mar 2022 16:14:13 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id F19981F46AE7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1646410452; bh=E2LGBSxjIQabf0bhUjv3Mh0qf9oY5wW2xSYGdoaQSxE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=J9MMbjEO8Vy4G1dcC7G1yQdRQ9ENG/jVUp0O6noQk/Ma9SU0TLw8UG8CkNW2jzY5b veOgEMQBVj9OJM1zt6lBrNmxVrWnsBgnUSoWp8GUf5DT7cQYXjUQRj0pGetcZX+kEw 21ju2TRlhS+XJIr3CEVqM4YYBBNA68UdKjiI97IhBvVbBOqzpvtqCsDgZB83MFvyuY 1RJyljs9KALlkEydSHqQo0YtWxP1+RAK+EZZIEiiULoAbrgWRWdFWMHvHe3DBrYx5c eIsqA8VwNkmev52sWjJzCbJdrjnJqHeXHxms2Vxfb+I/NvDZw7ZQ49br7OGtWBx4ic Dxl2RU/jOHsCg== From: Gabriel Krisman Bertazi To: Shuah Khan Cc: David Hildenbrand , Muhammad Usama Anjum , Andrew Morton , Shuah Khan , kernel@collabora.com, kernelci@groups.io, Will Deacon , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH V3] selftests: vm: Add test for Soft-Dirty PTE bit Organization: Collabora References: <20220224212335.3045905-1-usama.anjum@collabora.com> <3b7c068b-ac7e-62fc-f0cd-a8dbf8642876@redhat.com> <6133317f-4da0-3aae-f352-b75f0f94dbd4@linuxfoundation.org> <87o82mkhif.fsf@collabora.com> Date: Fri, 04 Mar 2022 11:14:08 -0500 In-Reply-To: (Shuah Khan's message of "Thu, 3 Mar 2022 14:46:08 -0700") Message-ID: <87r17hg0fj.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 9605818002C X-Stat-Signature: qtjc1447fzrqo5rnzao68rjfc9zztn1s X-Rspam-User: Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=J9MMbjEO; spf=pass (imf16.hostedemail.com: domain of krisman@collabora.com designates 46.235.227.227 as permitted sender) smtp.mailfrom=krisman@collabora.com; dmarc=pass (policy=none) header.from=collabora.com X-Rspamd-Server: rspam07 X-HE-Tag: 1646410453-938295 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Shuah Khan writes: > On 3/3/22 11:39 AM, Gabriel Krisman Bertazi wrote: >> Shuah Khan writes: >> >>> On 2/28/22 2:37 AM, David Hildenbrand wrote: >>>> On 24.02.22 22:23, Muhammad Usama Anjum wrote: >>>>> This introduces three tests: >>>>> 1) Sanity check soft dirty basic semantics: allocate area, clean, dirty, >>>>> check if the SD bit flipped. >>>>> 2) Check VMA reuse: validate the VM_SOFTDIRTY usage >>>>> 3) Check soft-dirty on huge pages >>>>> >>>>> This was motivated by Will Deacon's fix commit 912efa17e512 ("mm: proc: >>>>> Invalidate TLB after clearing soft-dirty page state"). I was tracking the >>>>> same issue that he fixed, and this test would have caught it. >>>>> >>>> A note that madv_populate.c already contains some SOFTDIRTY tests >>>> regarding MADV_POPULATE. Eventually we want to factor out >>>> softdirty/pagemap handling+checks for easier reuse. >>>> >>> >>> Is this patch unnecessary then? >> It is not unnecessary since the madv test doesn't cover the bug tested >> here, afaik. But, as mentioned when I originally submitted this patch, >> it should be merged into selftests/vm/madv_populate.c or, at least, >> reuse that existing infrastructure. >> https://lore.kernel.org/lkml/87lf553z5g.fsf@collabora.com/ >> > > Oops this one came in a few months ago and appears to have slipped > through and didn't get the right attention. Sorry about that. > > Please resend the patch and cc all the everybody on this thread. > > I would like to have your patch reviewed and looked at first. This > patch needs rework sine it has several comments to be addressed. Hi Shuah, The patch being discussed in that thread is the same that Usama is proposing here, minus a few modifications. Usama has taken over the work to upstream it. We just spoke, and he will follow up with a new version that addresses the coding issues and reuses the infrastructure from madv_populate.c Sorry for the noise. -- Gabriel Krisman Bertazi