From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B4F2C433EF for ; Fri, 22 Apr 2022 14:42:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D5806B0080; Fri, 22 Apr 2022 10:42:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 285696B0081; Fri, 22 Apr 2022 10:42:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 127836B0082; Fri, 22 Apr 2022 10:42:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id F09226B0080 for ; Fri, 22 Apr 2022 10:42:55 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D1AF2248B2 for ; Fri, 22 Apr 2022 14:42:55 +0000 (UTC) X-FDA: 79384781910.17.C09AB41 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf09.hostedemail.com (Postfix) with ESMTP id 895C3140023 for ; Fri, 22 Apr 2022 14:42:53 +0000 (UTC) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1650638573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5ab1B9xAubV3zZLLUQejgYIXK0dy0QH0QGOT/yEDKvw=; b=a0jKXGBB05Wms0CsvBuwLt0SWse/M2Cfy6qwtqtqn1QZxAXKAaoeifkiJtABRWHlf6geJh KlRBPORdqhDY6DZKejJQxsg70PqSMcXXJwMamN9zuVPewbA3ykr3f0ur0aLXaObfLeua0p 69n1YIn9VeZFM0j5AqOA2oca7E8X6Bxk/vuOPyaCaGRWgf3EQUNsg/i34HFxshdS5yGjiZ +S2AU2c/vDIix5rwwwRP+mwPBTQjVONXWZts8ETS7arRbkJ4W/Hk8lO9LQ5zfZJj2waQOj gMCufq8fpm936wCmsvJ2q7BeYx0SGeZEo0LJr5v9WV2qzeGUiJ9LGoJ0QcPwmQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1650638573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5ab1B9xAubV3zZLLUQejgYIXK0dy0QH0QGOT/yEDKvw=; b=fZ3WO591Dbl4IIhNV9yo29PTdXOG3vfQqufJ5DX1cdJowXaOalC9ivx2rOgYkKMnQhyxaU GXBCQf2Dp3Sy7+Ag== To: Nico Pache Cc: Andrew Morton , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?utf-8?Q?An?= =?utf-8?Q?dr=C3=A9?= Almeida , Arjan van de Ven , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox Subject: Re: [RFC 2/3] futex: exit: Print a warning when futex_cleanup fails In-Reply-To: <90124b02-76b5-d775-ac7d-a2e9d7677fa1@redhat.com> References: <20220421190533.1601879-1-npache@redhat.com> <20220421190533.1601879-3-npache@redhat.com> <87r15qrwdt.ffs@tglx> <90124b02-76b5-d775-ac7d-a2e9d7677fa1@redhat.com> Date: Fri, 22 Apr 2022 16:42:52 +0200 Message-ID: <87r15p5gcz.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=a0jKXGBB; dkim=pass header.d=linutronix.de header.s=2020e header.b=fZ3WO591; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf09.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 895C3140023 X-Stat-Signature: cjq5ekjpk4k7nqhu4514m95t3sq1kee4 X-HE-Tag: 1650638573-706458 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 22 2022 at 10:23, Nico Pache wrote: > On 4/21/22 16:53, Thomas Gleixner wrote: >> On Thu, Apr 21 2022 at 15:05, Nico Pache wrote: >> Robust futexes are best effort as I explained you before and spamming >> dmesg won't help anything. > It would have helped find the OOM/Robust Futex issue more quickly. It may also > help detect breakages in the pthread code (or any other users of robust futex) > if someone is doing something incorrectly. If we follow that line of argumentation then we have to sprinkle printks en masse all over the place as there are a gazillion ways to create hard to debug issues. Thanks, tglx