From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47DFBC67871 for ; Tue, 25 Oct 2022 03:02:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7F5D80008; Mon, 24 Oct 2022 23:02:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2E8C80007; Mon, 24 Oct 2022 23:02:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9451B80008; Mon, 24 Oct 2022 23:02:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8876180007 for ; Mon, 24 Oct 2022 23:02:25 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 599A51401BC for ; Tue, 25 Oct 2022 03:02:25 +0000 (UTC) X-FDA: 80057973450.03.6854630 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf15.hostedemail.com (Postfix) with ESMTP id BC220A0002 for ; Tue, 25 Oct 2022 03:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666666943; x=1698202943; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=yPVWbqvt8PmA0e6igOZGTVuQxkZttukiozMYejSHZqY=; b=gRkVEKT2YkahgEjbbAb4v2918bCxolooxwRYPJv6LbezgV+tlr08UrSe nFekT1eG70WsslNewrRn1eNeHPJsrkfKFdyyrdYsbiXvCkId9UO8srVoT WIO12fT4MZ7hW5Jfcd7A1feDt5B80CuuY1h/dtmebC0cQdTmDklEJ6fgg 9iFqiH43YSQTsSMrWxrFPoCSqvq9RtzUEbZyvDAGfd/9rbYGx8AWEyl8j gwTsS9dd2FWTJfgTxXCRhIZvCIhDsvv2TzO58ybP4cRAjJVxxA0PRfwNY LCl5EF78VaZKqrERfwtnE1HqDv5ZVxixOCtB9Wt5xnxr17HZkJaB/fSOQ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="287294230" X-IronPort-AV: E=Sophos;i="5.95,210,1661842800"; d="scan'208";a="287294230" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 20:02:22 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="664761478" X-IronPort-AV: E=Sophos;i="5.95,210,1661842800"; d="scan'208";a="664761478" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 20:02:19 -0700 From: "Huang, Ying" To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , HORIGUCHI NAOYA , Miaohe Lin , David Hildenbrand , Andrea Arcangeli Subject: Re: [PATCH RFC 0/2] mm: Use pte marker for swapin errors References: <20221024204830.1342169-1-peterx@redhat.com> Date: Tue, 25 Oct 2022 11:01:32 +0800 In-Reply-To: <20221024204830.1342169-1-peterx@redhat.com> (Peter Xu's message of "Mon, 24 Oct 2022 16:48:28 -0400") Message-ID: <87r0ywli7n.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666666944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w5k3QiX4FpvhE78kFF454m6w1O24yRPRSZ1SOaXTRLk=; b=EcjpuZdZ0kRr8N8cVRqjts71CAu1qL/E90h727ZNNm1kOf3Rseo4g/B4RBERld7WbdYYn5 qnAIxkl9BR1Ne6r3YbKZQVcxOpfcm3Z9Gu1vYnc5F2dcoR8ilUe3K2A9mWzfH8d8FbkDwx NyoA6/Ai1Xyw644Dye9dAmmMWbqio5M= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=gRkVEKT2; spf=pass (imf15.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666666944; a=rsa-sha256; cv=none; b=D46QIv4X0Nh/3YcPHjzE6UjqwrzRfUqT/OkLRxGF5n6dlKgN3lB2ldG6TJhx4YORLA+6Ir dSM6owPDAqf5lIjbXuneBYZxLTF9qjZqZg21qKZtHCkd9lr1g2lTdT0voX1fnbSI7FMKH5 GXQlbWIM2Vy1+nsa7Jic6EWI0O3EnwQ= Authentication-Results: imf15.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=gRkVEKT2; spf=pass (imf15.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Stat-Signature: d8tnpdpsjk6hppgcx6rwy1eswh7k1qcd X-Rspamd-Queue-Id: BC220A0002 X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1666666943-767619 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Peter Xu writes: > Hi, > > This series uses the pte marker to replace the swapin error swap entry, > then we safe one more swap entry. A new pte marker bit is defined. ~~~~ ~~~~~ save? file? It's good to save one swap file. Thanks for your patch! Please feel free to add my Reviewed-by: "Huang, Ying" for the whole series. Best Regards, Huang, Ying > One thing worth mentioning: we need the pte marker to be always built to > make sure it works like before, so I made an attempt in patch 1 to drop > CONFIG_PTE_MARKER and always compile pte marker in. Since pte markers are > enabled in many distributions by default already, meanwhile the codeset is > really small I assume it's fine. But still I'm tagging with RFC for this > initial version. > > Smoke tested on anonymous mem on a fake swap failure. Please have a look, > thanks. > > Peter Xu (2): > mm: Always compile in pte markers > mm: Use pte markers for swap errors > > include/linux/swap.h | 16 ++++---------- > include/linux/swapops.h | 49 +++++++++-------------------------------- > mm/Kconfig | 7 ------ > mm/memory.c | 13 ++++++----- > mm/shmem.c | 2 +- > mm/swapfile.c | 2 +- > 6 files changed, 23 insertions(+), 66 deletions(-)