From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F3FBC4332F for ; Fri, 18 Nov 2022 08:51:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEC386B0072; Fri, 18 Nov 2022 03:51:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A9B248E0002; Fri, 18 Nov 2022 03:51:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 963518E0001; Fri, 18 Nov 2022 03:51:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 886D66B0072 for ; Fri, 18 Nov 2022 03:51:51 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 64D4A160497 for ; Fri, 18 Nov 2022 08:51:51 +0000 (UTC) X-FDA: 80145945222.10.AE7CF60 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf01.hostedemail.com (Postfix) with ESMTP id 12EEE40005 for ; Fri, 18 Nov 2022 08:51:48 +0000 (UTC) Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AI8PSTT011070; Fri, 18 Nov 2022 08:51:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type; s=pp1; bh=MRx/zDrHRgWsZBss4/35ee8M+fYQkLk2Zhdg4e5ju7U=; b=CJ0LNubE4Iz+mtYhKXVPBSFjHk+6eJEbQL/mVDMhz3cu4oMKXaHuG4bB/cmIScJB26WR ScewYnbh/5IO6mSW3ujTcqqbDubaU+UO1hGKtiqt6qdp/K1zpEUiI0IggipmS2YH8rqJ fiEXo2mS14zDCqfA5aHftDc4qmHiQBGG6XPXfCAgqKuNziINTAw/Ji7tdWCcPqUcTw66 sr+UzdDjZJyiVfQlG8iJlkvpokXD4w3zLGLZh7BAlOmhfk43S61DsIdUf2v6ftRXvmsJ puZYT++jz6ejepiy3VLFTx2nr2+qgZKpcFVuwKF18Z2W1GXMhYrIKo3ihj3CUV75YnL7 hg== Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3kx6hd0fr8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Nov 2022 08:51:47 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2AI8YxXe015406; Fri, 18 Nov 2022 08:51:47 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma03wdc.us.ibm.com with ESMTP id 3kt34apfpg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Nov 2022 08:51:47 +0000 Received: from smtpav03.wdc07v.mail.ibm.com ([9.208.128.112]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2AI8pjpQ5112404 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Nov 2022 08:51:46 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BFC2858062; Fri, 18 Nov 2022 08:51:45 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 24CF958054; Fri, 18 Nov 2022 08:51:44 +0000 (GMT) Received: from skywalker.linux.ibm.com (unknown [9.43.38.233]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 18 Nov 2022 08:51:43 +0000 (GMT) X-Mailer: emacs 29.0.50 (via feedmail 11-beta-1 I) From: "Aneesh Kumar K.V" To: Mike Kravetz Cc: tsahu@linux.ibm.com, linux-mm@kvack.org Subject: Re: VM_BUG_ON in __prep_compound_gigantic_page In-Reply-To: <87tu2wfxye.fsf@linux.ibm.com> References: <87tu2wfxye.fsf@linux.ibm.com> Date: Fri, 18 Nov 2022 14:21:41 +0530 Message-ID: <87r0y0fxwi.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 1jYiR4kawEF5sON4_2qxB23BHTycRj0J X-Proofpoint-ORIG-GUID: 1jYiR4kawEF5sON4_2qxB23BHTycRj0J X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-17_06,2022-11-17_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 malwarescore=0 clxscore=1015 mlxscore=0 adultscore=0 impostorscore=0 mlxlogscore=980 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211180054 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668761509; a=rsa-sha256; cv=none; b=FqF61ncojH7M6o+75tdtEZ+QGMErlSa57Ww/fm2oREv7ggimBeJhEFYj+Nbj+G67iDe/7S OD0QisdYwLoAa9ES8ygUwEecDONC8V7rHgX1TNbKmyYZORlT/3RddsUFpQf0H3CiB9/2cg b3OcuOobWo8yqTxKNqiGbpAC5CD5++Y= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=CJ0LNubE; spf=pass (imf01.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668761509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MRx/zDrHRgWsZBss4/35ee8M+fYQkLk2Zhdg4e5ju7U=; b=kDDIp2WYvna/EQAYXlQ1/NB7gmlasllA5KzBGO5JeNbm3HzFQuqX+IA3fkNtKBjqFd8rCx aDMCx7Bk02zHxcmVuapdszJBTnlyrj1IslwuT2C+Acbwh3jAfJcow74hHuGPOHcttOGiR2 1Z1UTy1rOIjI7SvKxlGjing8bQpav7Q= Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=CJ0LNubE; spf=pass (imf01.hostedemail.com: domain of aneesh.kumar@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=aneesh.kumar@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 12EEE40005 X-Rspam-User: X-Stat-Signature: ckbzcm8xmp45wbctmb7gu5nscg435m3e X-HE-Tag: 1668761508-482826 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: "Aneesh Kumar K.V" writes: > Hi Mike, > > With latest upstream I am finding the below: > > [ 0.246646] page dumped because: VM_BUG_ON_PAGE(1 && PageCompound(page)) > [ 0.246671] ------------[ cut here ]------------ > [ 0.246679] kernel BUG at include/linux/page-flags.h:500! > cpu 0x6: Vector: 700 (Program Check) at [c00000000fe5b700] > pc: c0000000005e9984: __prep_compound_gigantic_page+0xd4/0x3e0 > lr: c0000000005e9980: __prep_compound_gigantic_page+0xd0/0x3e0 > sp: c00000000fe5b9a0 > msr: 8000000000029033 > current = 0xc00000000fdf9880 > paca = 0xc00000001ec7f480 irqmask: 0x03 irq_happened: 0x01 > pid = 1, comm = swapper/0 > kernel BUG at e)):500! > Linux version 6.1.0-rc5-00518-ge0951d75adc4 (kvaneesh@ltczz75-lp2) (gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0, GNU ld (GNU Binutils for Ubuntu) 2.34) #395 SMP Fri Nov 18 00:44:21 CST 2022 > enter ? for help > [c00000000fe5ba60] c000000001bddd74 hugetlb_init+0x60c/0xa10 > [c00000000fe5bb60] c0000000000121c0 do_one_initcall+0xa0/0x550 > [c00000000fe5bc40] c000000001b94b90 do_basic_setup+0x1f4/0x254 > [c00000000fe5bd20] c000000001b94f38 kernel_init_freeable+0x2ac/0x32c > [c00000000fe5bda0] c000000000012cf0 kernel_init+0x44/0x184 > [c00000000fe5be10] c00000000000cdec ret_from_kernel_thread+0x5c/0x64 > 6:mon> > > > IIUC that is because we are doing __SetPageHead() before doing > __ClearPageReserved(). The original commit that added compound head > check in set/clear page reserved did have the change to take care of > this. > Adding the correct commit details commit de09d31dd38a ("page-flags: define PG_reserved behavior on compound pages") -aneesh