From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9432C05027 for ; Thu, 26 Jan 2023 18:19:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15ABC6B0072; Thu, 26 Jan 2023 13:19:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E4D18E0001; Thu, 26 Jan 2023 13:19:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC6B26B0074; Thu, 26 Jan 2023 13:19:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D5D786B0072 for ; Thu, 26 Jan 2023 13:19:21 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9FE73809E3 for ; Thu, 26 Jan 2023 18:19:21 +0000 (UTC) X-FDA: 80397762522.21.BA8409B Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) by imf03.hostedemail.com (Postfix) with ESMTP id F298320010 for ; Thu, 26 Jan 2023 18:19:18 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=lwn.net header.s=20201203 header.b=PJSOhdl9; dmarc=none; spf=pass (imf03.hostedemail.com: domain of corbet@lwn.net designates 45.79.88.28 as permitted sender) smtp.mailfrom=corbet@lwn.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674757159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uUHe/yXy7xcAjN0XD1xm8zwwZxvs4eNmBcGRwrOYI7k=; b=aI4sc4BtGroLDV1zRky0fgg27ilt2UY3eXPu21SJb6y9z6Cnp2aPIox2yd4/6RjKwFiueU aJyJj41NgtvzV1omD1pi5squKZuMUghurwUUVwewRFFNtqh7g5Y3ma7J0zyJs6twyGgdLl ZWgXcekM5N9paYh+VEBC0AIKpI3afgU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=lwn.net header.s=20201203 header.b=PJSOhdl9; dmarc=none; spf=pass (imf03.hostedemail.com: domain of corbet@lwn.net designates 45.79.88.28 as permitted sender) smtp.mailfrom=corbet@lwn.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674757159; a=rsa-sha256; cv=none; b=uGJw2KWqdt1z5kIAZks1Cmvi1bXIDm23h44VgsuymghkivW9D0UedqujMkgN6i10IOfj8s VZvvKCGazbpg4KGyBBm+Mvm5B+q+ttuD8hgGahXiqJtnoMzarYYrDjK7hMyj6kzGV8j/G0 qdOIGeS65lQUazYgQPW/sEifeMA4O48= Received: from localhost (unknown [IPv6:2601:281:8300:73::5f6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id 08A16381; Thu, 26 Jan 2023 18:19:16 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net 08A16381 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1674757157; bh=uUHe/yXy7xcAjN0XD1xm8zwwZxvs4eNmBcGRwrOYI7k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PJSOhdl9GjEzPANxW9cqfUMkasqCiYKqU1VML76NpJnTyTkQSGNNPVWbWOxzHlqh5 cdfigy3J/rDz484djEK7R7xxLkYpN2HTkN+Pk8sF4iTCSkq/dHZC5EA/8KyxiZSlXQ 8sT25q7ILoaGAvu5Gwt5pNNR8DJSrfkSESumwXPHrxwgtLbl5yXf+AEJIGEVN0Yxez rpGwBuzsxg+pPeaN1NbCKMZTYR81vPS0IM2nXn6hsoeo8VEE/5X3UchdLpjsEso6wI ag5362TC3K3hIORUpUBgbWzEV9ADPJv8nZZFGvR2z4DdnLc6Hj/Odp6pIDlp5pjrxF YWrQ3lTAkHHiA== From: Jonathan Corbet To: Mike Rapoport Cc: Andrew Morton , Bagas Sanjaya , David Hildenbrand , Johannes Weiner , Lorenzo Stoakes , "Matthew Wilcox (Oracle)" , Mel Gorman , Michal Hocko , Mike Rapoport , Vlastimil Babka , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko Subject: Re: [PATCH v5 1/1] docs/mm: Physical Memory: add structure, introduction and nodes description In-Reply-To: <20230125192841.25342-2-rppt@kernel.org> References: <20230125192841.25342-1-rppt@kernel.org> <20230125192841.25342-2-rppt@kernel.org> Date: Thu, 26 Jan 2023 11:19:16 -0700 Message-ID: <87r0vh9n17.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: F298320010 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: nyp5kahe5myzwzum5w38smkzekqt4dfq X-HE-Tag: 1674757158-411996 X-HE-Meta: U2FsdGVkX1/sJe8I4QeWgzBBngej2OI72LaKGkgOjF5kHDtGBb3xEcZxWqej12cO1qiMrRcY1JfPRIlh1M82oiDnAQjsFtg438SJuJflIbLS/MpOBXumx6FFaFrZ8KYi1Xi3ZqscEEJN8ejWtYgXHJUJf4cedloSU4s9pUYagwaPFm59aNYGMt5w0eptuP9Dd8SUn7VeICpHiALVsOVKArambz3NZdZUJtDKG5SzZHxtmKo3nvtlI0MXX1t40KO1HtDYWvLY77Q2OSCT+WC6tR8JtUvKl7LOuIptvpeLT+XemaMPp7oGd8KOpGtg0XrIdqn65ozZ3608ftK2vk9Xt6+1cuUonbfSattm0PQE/BbH31Dry3HxEvJWpxHQmFzpc+E6GLpfuE9I6kDvzHsKXR+TbzDQTf+wGwVjCGY8U4elppJg24uM1sbUJ+X0b7s6qLU+t1ZDa14S0DACI9e9LrmKa5CmkQtK+tLtCUeCNR63J6goQcugwRlNBsmI8ZwKnZGdz1EEqpMciTvSbDu6XGKHYcyAWtsOZ/hR0F1x1RzTAtOW2K46Lr5NViGO9ohXBuXSTG2mUPlQHGGBsIV2PjscZblLtL6btfOH9K1S11rCSIANmHAgpm1jdjciwRCj4acfg9eN+T3TJV4CYaYjHJDXjDYyh6CddbmDvEq0JKn31YLkF6nwWLPMbMfahaGbAnNNhpdo+HjwDuTyeeIfE7OMhxOvt67zQqBAvpKuCu73EKrKTEM0rRozEvH/kCAO8rS5L5QxpSd1uBoe5PJ726UKxnqqnFtZ9p97YXJ3m5WqjdsHU50+RIISQfT7Dk4i8oNSXq+iMNXRHULOk2KB00nD84tAwI0BVS8DlnwRoKvA96v49dGiHesWLqXIrThkNKTEB8qFUTXkXqPwTMQUXqvGQpi2nICGmXL8zDxbcEbt+zlSJA5KKl0g1+NVM9WkX8lvqe34uupI6sLN63m aRRuiuef aJ5ahUeHzidkK21UqjuuFD6OcOKsCK4Cu1WLXAMxlFIBoFgVdxhp87ycfWiroFU+3KNoMef1YhDfwSZ0qYFG2XD1rXri1bHbrKFyGVHVyvW9Yn1E1C40AcESV3yevPKEAir//klHMG/bHf851RvUZUCJtthw/JQz68IFCLwp3drUdgWBltis1RXUGhvKhHPPp+C1vIx2TnrxJeG4lUYvaYR8d0MPbSi81mxbU0WoNSlFSloFcSzWOf7xHiCOt6YOr620pT/XzGQ+7XEIhLI435wivMgYajuI3rtdVVZTVME0IjRtxrC9wPyc7zQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Mike Rapoport writes: > From: "Mike Rapoport (IBM)" > > Add structure, introduction and Nodes section to Physical Memory > chapter. > > As the new documentation references core-api/dma-api and mm/page_reclaim, > add page labels to those documents. > > Reviewed-by: Bagas Sanjaya > Reviewed-by: Lorenzo Stoakes > Acked-by: Michal Hocko > Acked-by: Vlastimil Babka > Signed-off-by: Mike Rapoport (IBM) I've gone ahead and applied this, but I do have one little gripe... > Documentation/core-api/dma-api.rst | 2 + > Documentation/mm/page_reclaim.rst | 2 + > Documentation/mm/physical_memory.rst | 347 +++++++++++++++++++++++++++ > 3 files changed, 351 insertions(+) > > diff --git a/Documentation/core-api/dma-api.rst b/Documentation/core-api/dma-api.rst > index 829f20a193ca..c847a5b0a0d3 100644 > --- a/Documentation/core-api/dma-api.rst > +++ b/Documentation/core-api/dma-api.rst > @@ -1,3 +1,5 @@ > +.. _dma_api: > + Top-of-file labels like this one... > ============================================ > Dynamic DMA mapping using the generic device > ============================================ > diff --git a/Documentation/mm/page_reclaim.rst b/Documentation/mm/page_reclaim.rst > index 50a30b7f8ac3..3fccde066436 100644 > --- a/Documentation/mm/page_reclaim.rst > +++ b/Documentation/mm/page_reclaim.rst > @@ -1,5 +1,7 @@ > .. SPDX-License-Identifier: GPL-2.0 > > +.. _page_reclaim: ...and this one really just add noise without bringing any value. Something like: > +Reclaim control > +~~~~~~~~~~~~~~~ > + > +See also :ref:`Page Reclaim `. Can also just be "See also Documentation/mm/page_reclaim.rst". The right things will happen in the HTML output, readers of the plain-text will know immediately where to go, and we don't have to add the label clutter. :) Thanks, jon