From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13A18CD4938 for ; Thu, 21 Sep 2023 02:12:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F2976B01F5; Wed, 20 Sep 2023 22:12:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97BFF6B01F7; Wed, 20 Sep 2023 22:12:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81D486B01F8; Wed, 20 Sep 2023 22:12:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7424F6B01F5 for ; Wed, 20 Sep 2023 22:12:32 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 475AC40746 for ; Thu, 21 Sep 2023 02:12:32 +0000 (UTC) X-FDA: 81258980544.07.A8FCB5B Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf01.hostedemail.com (Postfix) with ESMTP id 7B30940009 for ; Thu, 21 Sep 2023 02:12:29 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=4aQW4w2u; dkim=pass header.d=linutronix.de header.s=2020e header.b="sO/9/fIS"; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf01.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695262349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zGsXb59mheAvf0K/E0GO3/Bp/8mZXCu36PHW8K2vlxI=; b=VO3gwhiuiIr0uJD3f+ShS4FRjFHChHBLAH2iSG81yq34aA6GQdpaYvbj5NUgLSa5FIG1Ut fEegQVCiZZeF+V+THwE/BaF/PBR/rRBDV00oosHIYY4plnaNcwTt94A1JCD8ZGKUreZ0UQ 9yn03wDpHDjsee4ILsI500svF5N3xwQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=4aQW4w2u; dkim=pass header.d=linutronix.de header.s=2020e header.b="sO/9/fIS"; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf01.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695262349; a=rsa-sha256; cv=none; b=FI/W77oYFVHwpQGj4ELuQ0Zm6th6dV7oOGUiDghb48zIfPR5TfMKdRPOhT4SbFF4g3/rwf GQz9sU72HkX5bXSE71e/9zw8rIGk/H5c6bCI66g9GtIVDaMA+dOOlACZcZExqMAEtJetur Z/6dQyP93wIGI30zhkOnQT6WF896X5I= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1695262347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zGsXb59mheAvf0K/E0GO3/Bp/8mZXCu36PHW8K2vlxI=; b=4aQW4w2uUjAKLLA6iOdyat5+SCt1rP/XPruRshfBLZMyyz/uU/1fO/sKn0Irl5vexExvji zJJnqqH3YsCaEuZqb+q4bEntoeYsp1xYDng9TUXHuMJgMTMfwFRQYr0orDJoR/wOxaSCxQ AoDXS9VVwYTCAVBkgzHC0oscSF1EkN3gTvrI4IJ5spFelSSCtqKBiE5aHioWUV3rbdsMim G8Hx+AX1upPFu9TC+vKCdRnyGBt1uygWDZWvmXuu3U+Sw6gdkfvXBk9/i/hKEXRqaJwwRL rQsdgaoFwC32fuD3aCS+8tMgnfJoOEeDaciNMMoH451sm8mhVNiwwuxsXfiCyA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1695262347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zGsXb59mheAvf0K/E0GO3/Bp/8mZXCu36PHW8K2vlxI=; b=sO/9/fISUk77aPbQ2sgJ2s84yiEHYYsGdaG620hmsx1tZu4FTAjI7ObUu0kwFasGSwfcVv 212YTsmnxSsObHAg== To: Ankur Arora Cc: Linus Torvalds , Peter Zijlstra , Ankur Arora , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, rostedt@goodmis.org, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com Subject: Re: [PATCH v2 7/9] sched: define TIF_ALLOW_RESCHED In-Reply-To: <875y44ibow.fsf@oracle.com> References: <20230830184958.2333078-8-ankur.a.arora@oracle.com> <20230908070258.GA19320@noisy.programming.kicks-ass.net> <87zg1v3xxh.fsf@oracle.com> <87edj64rj1.fsf@oracle.com> <87zg1u1h5t.fsf@oracle.com> <20230911150410.GC9098@noisy.programming.kicks-ass.net> <87h6o01w1a.fsf@oracle.com> <20230912082606.GB35261@noisy.programming.kicks-ass.net> <87cyyfxd4k.ffs@tglx> <87led2wdj0.ffs@tglx> <878r90lyai.fsf@oracle.com> <875y44va9t.ffs@tglx> <875y44ibow.fsf@oracle.com> Date: Thu, 21 Sep 2023 04:12:27 +0200 Message-ID: <87r0mstgtw.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7B30940009 X-Stat-Signature: otx43keextxxygtgqsjcpbs5jz11hbjt X-HE-Tag: 1695262349-863657 X-HE-Meta: U2FsdGVkX1+/U8wtrlyxxW2lGj4MX1HAavgrzt/3Mz5CuYQwndnhG8MtSCAJ5xUQUeWSN7pa4zVPTzGoVtIMng9xBsvNL89dwFzyI1rsBmxFx7MIVbXk3Af6+Xn7knTQPud4LbvFHz+5Hagzo0CpcnfMXMWyu5JIwtTX61dJ3RHpUnhbduVov0ywff2RvTWed8/Kua23WyEZ1rOTwHEaTMYG1tEmkWJhSZZylIRvcZeBIVRJ3kXX+YjbdhFxPvxhhOiKKVPn5cYO2puR3bMR2qfxNCJWKDFN6G9q1CrSr99CqXlDgJ9wmOkqQjTNronk2ZBshgDIDVj/0O/z4NPVuFcfCIs9u02EMlh0jS2SkCCJsbOLOafnS3VV6xvZH6IrOGT0YUlGeIe099M43fE29Iz9GmYc2wlhbkDiRXn0ntSSwOOIC1BmDKJD4zWtJcJlodLzrUOgxd2QuJ8SHa+TPMVN1nhYDrheP+yGGXHIuVf2b9S+N1bgieck+nOZhUCNa71tMczOwxE31nQnpRJdcMgabT3WrlD3vNEtOavz4C7xx5kNrIbIMMolSnAiPVRYaincnP0H8W7IKTE0FnH/dc3QW9XsOqvTeizXNxdf2lOh5Ge6tW8cve0TQe66J/zV/4ezsU9BNk8NA/Jy1bZ8VNNcNreZ32JiOdAbdD1S0u6ZhPDyvUvBV/VYXzdlkd+gAW5IAj4RxAWH3nbvY/P+TelKGSpkAfhvJgsDSZbYxk6HuQq/5+N3ukp7WL20tISYGGNqg048xEqwMyHlxLdEHR995KEH4xjAevDh/TqTTYR+feqsQ1P1e1rubKC9z3BlBMmMGw/8jSriPoCFPH7Edr/gBk8MNx7mLZPOGsWU+AvDOVsTDFcgZO9lVyQFBf5nyqpfppZnaopqENxLE4YU95hQ20tDeVY0DioJaShFpTieV3loaDp5F/qrEnd6+3bDzVxuBOVjXODuFl+OTjR LFpfpbRx bSkE/mIUr2kIgGy10YgadXH3Xjs8q3brTvc+9U5rcDaAKr46TATlJuxsqv3FaJDFc9UvctcMWRFE51NEK2LA3T6lQFtPlX9aGMpf4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 20 2023 at 17:58, Ankur Arora wrote: > Thomas Gleixner writes: >> So no, we don't need yet another knob. We keep them chucking along and >> if they really want they can adopt to the new world order. :) > > Will they chuckle along, or die trying ;)? Either way is fine :) > I grepped for "preempt_enable|preempt_disable" for all the archs and > hexagon and m68k don't seem to do any explicit accounting at all. > (Though, neither do nios2 and openrisc, and both csky and microblaze > only do it in the tlbflush path.) > > arch/hexagon 0 > arch/m68k 0 ... > arch/s390 91 > arch/mips 115 > arch/x86 146 > arch/powerpc 201 > > My concern is given that we preempt on timeslice expiration for all > three preemption models, we could end up preempting at an unsafe > location. As I said in my reply to Linus, that count is not really conclusive. arch/m68k has a count of 0 and supports PREEMPT for the COLDFIRE sub-architecture and I know for sure that at some point in the past PREEMPT_RT was supported on COLDFIRE with minimal changes to the architecture code. That said, I'm pretty sure that quite some of these preempt_disable/enable pairs in arch/* are subject to voodoo programming, but that's a different problem to analyze. > Still, not the most pressing of problems. Exactly :) Thanks, tglx