From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30EDBC25B75 for ; Wed, 15 May 2024 05:40:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B6F96B0179; Wed, 15 May 2024 01:40:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A1EF6B017B; Wed, 15 May 2024 01:40:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51A8A6B0181; Wed, 15 May 2024 01:40:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 229306B0179 for ; Wed, 15 May 2024 01:40:05 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3EFA31C0FF8 for ; Wed, 15 May 2024 05:40:04 +0000 (UTC) X-FDA: 82119529128.17.90E0518 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 8F59980012 for ; Wed, 15 May 2024 05:40:02 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ca5UtmZX; spf=pass (imf02.hostedemail.com: domain of bjorn@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=bjorn@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715751602; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qgfgtIkQYgpjWNOudfdaNpbRMK6rSZI+kLjU1IbLZdk=; b=6uYA4UwGJAaj8FPFtQHQlKl7vbPwBkCUC9I/ucd+Ga4fEJX1s/tswRacK7HQg9mqPSf0Um 4JZVeiSa5qlcNk5RttWNc6kPpglclhMD9Sm7AqnZEUuEfSRZtoqquViZTEzynfOFF7WSxZ h9ZH3gbEIPwgbNUszZbrA96I/r7msGI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715751602; a=rsa-sha256; cv=none; b=sWCo571W0YdKl1/WnoyfIF6pSW2ApiJfnDQGGDMyigeGJCqXXRly/dvdcOZVjU13GAPdLa nXyOtv+Ran8pwO7ebDapOPlpaP5CKzYt0PzdtNfhrPtVngNtGrYW/vE+YpgelK1GbVylo1 aIDbmoIFMjO/PeTDUMHP63Uh/UOD3go= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ca5UtmZX; spf=pass (imf02.hostedemail.com: domain of bjorn@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=bjorn@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 46E0461297; Wed, 15 May 2024 05:40:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D1DDC116B1; Wed, 15 May 2024 05:40:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715751600; bh=qFeWv8GsFEP94NiH8hpu0MILQkrgqqI5f7XEUQ/bekw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ca5UtmZXO0PHjPXUUdc+VZYnkPVpb5jib4ktCpzzV3ZhA546YhW9UHk5pBrTsB8fs 5OCudtSHCOl3d3tTP3zo7RdBrJ8iHRR/KdAfFY0cca7m/EF0pacW8X7Wpz3cWwdto7 QOq82dcN4g4o9WbzMkFB9Q12wjhuxcMlhN5k61iDy/Hdzzp2lWztAOY+rqK8b1NDji 7PoAKLqCS0xjrsOBxo4Pjl81GboukdaMGq7BdQUF1nz0FsP8sokZnjlqgS/O9SKSKy ASyYdWBijdb1z+6/2VB4SVQs5vdkkYQlveAVRDdcnzToprQ2NzuYIZYWyPJQVwjBm2 +I5sghOxb1v1A== From: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= To: Oscar Salvador Cc: Alexandre Ghiti , Albert Ou , David Hildenbrand , Palmer Dabbelt , Paul Walmsley , linux-riscv@lists.infradead.org, =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Andrew Bresticker , Chethan Seshadri , Lorenzo Stoakes , Santosh Mamila , Sivakumar Munnangi , Sunil V L , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 2/8] riscv: mm: Change attribute from __init to __meminit for page functions In-Reply-To: References: <20240514140446.538622-1-bjorn@kernel.org> <20240514140446.538622-3-bjorn@kernel.org> Date: Wed, 15 May 2024 07:39:57 +0200 Message-ID: <87r0e3k502.fsf@all.your.base.are.belong.to.us> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 5hxm9f9fy8fjjg14e3f9sggaggs8wkou X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8F59980012 X-HE-Tag: 1715751602-702536 X-HE-Meta: U2FsdGVkX19swXgR7BbODXK9UtIrx3ySCXBcRrctlnUA8FhBowjV5+xdcqkzchEwMMqpzcZe52r7CQIfma1DeCGuzd11GRd4PVS0u3KiekMtxfnQMD2chaiqXqorPDpEK3OxMm8Q7Tjzl/PIwGKMCyRF78WsEXJ5q7SagUcAarDjz5Wchw0Oz7ihxcXtQiCsclIL6AorZ8ux39JK4tlwRuXiAsiEXU+RkfwUt/uYmEAAaNs2ybNpYMhNTREYXTSN8Uy3ewC89zH65RgLlEtBD2TriOXplHBI/a+KtO0FHjikdOUBvrPEKl5JVsY9rVX0f6pjCCIKhRmHBEBTSauxFOavy8reTlxgSgt9DNp7ZCnwAvU1n79oKyvDfww+DywciAKfNGK75ynLS6lKzqASQ4/ylHDQrGX1wqNj4+udi/Poj+QVO0iPpCk6omo1JMtELYw3JKI3yEOgr80QM5Np642K8u8RzSe7nUrrKiG1WaqPpv91qKdDOlMv5/DPDVun4fD/tg/X2PHE7DZgzobwzeqjcSUbjLUcubo8qhjBb1PcF4KnO7AX6CaNu5M4KNAq9+POm8nssFqqa9ab+gc6hwge0WJhSDOUJe2lZcRopeseRl2wlw0hvp8hAtzPu3/ZVloxC5QOi/GOZpH9D0Owt6BB0SV4BWADzBiFqZ8qPjokt7T2MOkvHk9M0qh1I9wUy6xm+kCvE0sa1VA+odu686kiKINh0m2HbTtmsDA6pSFXjBHlrEFize6aKOjuYPNDgOzdy7axfDIA8CWiSRASaVAGrfcFhpr+gfRQ9MSlo6vN5b8BQkcQcOFbKdInfDi8UUAy4c/v/dfxoq5zXi9jo1W5dSKOc8nw37wPgs4mkPue7cyJSjAdb6jmbLO2XwLty1lc5WVQrrZvgIEvoVspYKTqTVtFwJBKH+XQF9+D8c8JGKcOgEE7L6cLIRvxxVoM0xugdRBTo35/U82DG8Q fwtUhFWv FYue87p5gBlbB2cX/wHJcONUoyJ3JHMEmnCoiUlGUxeO23hpUyhvZyHHCZrK7tPWl223Fdy13zHF0gEVr4emoJiiwy6zCxhN9Sp2/+ULYw+xiKeEQmW2hMmtctxl2bqROWloxgnMmJPS/1cQPDBvcSqjE4rmxS6i9qEXvi/6+qemFJ/3F5dnP2t5yunPdDGDMDrydFl3IdAFePizHGJHAvJxTHk/c4jInoniIz/2d8AqrLQA+QMJgS9Ow3uRhjmAxyrttdMa4vO13/kDYepHr8p/u4R3egRQEw30dsyisQLN7lkHtXi2IXyNJQyyO4MAtDhxopL7ZvXd4S24yHxcPOlPF+NtZ1L6L1DBCQqL3WOxJx30= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Oscar Salvador writes: > On Tue, May 14, 2024 at 04:04:40PM +0200, Bj=C3=B6rn T=C3=B6pel wrote: >> From: Bj=C3=B6rn T=C3=B6pel >>=20 >> Prepare for memory hotplugging support by changing from __init to >> __meminit for the page table functions that are used by the upcoming >> architecture specific callbacks. >>=20 >> Changing the __init attribute to __meminit, avoids that the functions >> are removed after init. The __meminit attribute makes sure the >> functions are kept in the kernel text post init, but only if memory >> hotplugging is enabled for the build. >>=20 >> Also, make sure that the altmap parameter is properly passed on to >> vmemmap_populate_hugepages(). >>=20 >> Signed-off-by: Bj=C3=B6rn T=C3=B6pel > > Reviewed-by: Oscar Salvador > >> +static void __meminit create_linear_mapping_range(phys_addr_t start, ph= ys_addr_t end, >> + uintptr_t fixed_map_size) >> { >> phys_addr_t pa; >> uintptr_t va, map_size; >> @@ -1435,7 +1429,7 @@ int __meminit vmemmap_populate(unsigned long start= , unsigned long end, int node, >> * memory hotplug, we are not able to update all the page tables with >> * the new PMDs. >> */ >> - return vmemmap_populate_hugepages(start, end, node, NULL); >> + return vmemmap_populate_hugepages(start, end, node, altmap); > > I would have put this into a separate patch. Thanks for the review, Oscar! I'll split this up (also suggested by Alex!). Cheers, Bj=C3=B6rn