From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC44C27C4F for ; Wed, 26 Jun 2024 08:50:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 396EF6B0083; Wed, 26 Jun 2024 04:50:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31F776B0085; Wed, 26 Jun 2024 04:50:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C0786B0088; Wed, 26 Jun 2024 04:50:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F02CA6B0083 for ; Wed, 26 Jun 2024 04:50:27 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7B666A00FB for ; Wed, 26 Jun 2024 08:50:27 +0000 (UTC) X-FDA: 82272418494.30.6EAB9A9 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by imf13.hostedemail.com (Postfix) with ESMTP id 5487320019 for ; Wed, 26 Jun 2024 08:50:24 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UxfVq8jG; spf=pass (imf13.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.8 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719391817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F34oA4nn9Qi0XgtKbntCOOhdWGvwaQ2kiXm8idWg01Q=; b=luL0UwnZ9LcHvegSCWvdCR1qgyyV/MY6Juvv7sLdtuOjen/1XjBg1+yCdCzcKyqDeo1qet Z9o8miUykhckZPNWwH0bP5HUmi+TZZma/wlUD0MGIZ02Zb0DzeLsjydoESitahfcb/m2Bw v61dhhVQDl1wu6pGsW69UhrwVxZZn5Y= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UxfVq8jG; spf=pass (imf13.hostedemail.com: domain of ying.huang@intel.com designates 192.198.163.8 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719391817; a=rsa-sha256; cv=none; b=i8z1Svw7i8GSmJ/PX9G0mn/KYOOEYPOqDIhwDlJ2ydNEgDV5i7YYccq7Aant3mSnTOmewZ lzYW4OqzTYe01RytiF0tKACVHL8oNmfhpmUQMDd0zTNkwMblTOBqRMoG4SrAT+4tT9gNGd 7aFCJOLhK9yEHCvzH9LC+yKt7oCkojQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719391824; x=1750927824; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=hbgIrvLNG3JVyk+XOg/DvdfZjiWKR0LtGTMHMqm6PJM=; b=UxfVq8jGtnY3Ae2cHRdnfEZuWjOIFtZeQgZSEbZVJS4cWv10IeAb4Kwd bMjhfBKhQk8roKtPZc3x8boHyaLpKVDz2aJ3pwRYwMT3wyaNY3Ikhcxpi 8HeRIqwccVMG3j94bCEZYzT/iGPDQ02Ph723VSavZLXjZkNRYoW30wtiL kB3EKrauaPmAtnlGw+eDbXj/BURHZWDC0nWGLeto0voxWsqMxiyQ63tgP hzY22TFC0tAGtW8PQl/FEfaOJf+3ujZI5Ev4esBXeGK35b+NCwK1ELCrL JoHQTUr5F5gJaOmvCN3g1epU0kp9fytCKFv4jWqGp5ZWvgfWJOLNP5qrd Q==; X-CSE-ConnectionGUID: PvYmRZHZRuqkgVOMjRhH/w== X-CSE-MsgGUID: ak9W715WR2GtQKYoSDEx3w== X-IronPort-AV: E=McAfee;i="6700,10204,11114"; a="33983956" X-IronPort-AV: E=Sophos;i="6.08,266,1712646000"; d="scan'208";a="33983956" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2024 01:50:22 -0700 X-CSE-ConnectionGUID: 5HnKgUo+S8Kzqy/b6pxSmQ== X-CSE-MsgGUID: vNboYoUMT2id2AEudTcF3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,266,1712646000"; d="scan'208";a="44038581" Received: from unknown (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2024 01:50:19 -0700 From: "Huang, Ying" To: Tvrtko Ursulin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com, Tvrtko Ursulin , Mel Gorman , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , "Matthew Wilcox (Oracle)" , Dave Hansen , Andi Kleen , Michal Hocko , David Rientjes Subject: Re: [PATCH] mm/numa_balancing: Teach mpol_to_str about the balancing mode In-Reply-To: <20240625132605.38428-1-tursulin@igalia.com> (Tvrtko Ursulin's message of "Tue, 25 Jun 2024 14:26:05 +0100") References: <20240625132605.38428-1-tursulin@igalia.com> Date: Wed, 26 Jun 2024 16:48:27 +0800 Message-ID: <87r0ckozs4.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 5487320019 X-Stat-Signature: 9jwffhu69wqafbby571mf1tmpumktr5g X-HE-Tag: 1719391824-489764 X-HE-Meta: U2FsdGVkX19Vlfgv/dEGD0gQYvuE0eq4Tyc5XiZ9H5gqMbMGZ6cznwRWyb6KtNalZEDI4PsfqoFmyAhkmxRDvoVCusBdUkpLXzW6dfqCPm/URkqbYKT9HMC4U6zKesptvAT7nUtZkmsqMhMfKoyadqOVKoB0kQTLd2g7EXvya5nOZGW+86qQvxhaKVpvDbBln619E63phzSXcWQYcLNnThrp18AQaEQHUyMBFIYN/WNxWP0hdL8YR8ZUQC2aSQTHYz2Swtw1sN8jcgZm6d62OICmJGQAciSZRkvmzYMUZOTJY8NVNi/nCI9W3V3F6TzreLNxSUEzxlYDFlZl8DGbvMeJirNiuSVzNADBfGw+qZz0pKSf+z3SLMoqKU+Z7ivH5Mq82CH8Ot35YpulWBzWD2I8ADtNhUA+nTwPhBbLsHpUXANYALF7sAXxW8hXIvdX/RBSM6phb6YJf3Vf2B3hmzTIBXx2dnEtZf+agLS451jtvTzXXk7eAU/QERrTnvlbVX0MG6FU2ORmX+7aWw84FJ+mbpmC4KZzf4RzoQEHoYdrGLq+RJOGWxpfWducErlmc6aV4TKc6V6zzi0D5EUq7x7g8H5ceevXzERCCV1sKT+yqhXzSLO9hj7A3KNljuwgEugCQ05y5sNYOlSvTEg+8OeT+8hKhJQYfnlMIsDIg7M06FdMJDZ/TSpM0fU2H2KZKsLQV2a6h+yrOmlvukFVYARagKj6YfZTo3et49QixuP0cX0Au/5id4sdIa0MI1m6YGd4853d4nmOeqah14Tn73T1WfwMr/LpPKdO7E4LESq0PGwWLjLmxWu/4RWIGonttw2ZD+Mvx7Fff1YOJO2b9tsQAoqloBUK0iR0r1ihZc687u8PHKWCdlM+qHOsL8V8O1oY2VfIW6V+mgQ5gyPMiVf5VoCk2vp4gUkpp28SIqXPaFF2sqb5l11+arxE+uj1n2xE8Z9huDE/jz8+KY7 gwJ1KuLR 3XdANYYVepEGw4xA7lxJoQmRpHQjr6TmZbpFBpgHucyAac4H+kazed4uMxT2F64GIAVnG1w+rL51agTrDX/9XoGtdXXrmGhJ0Bb6tRZ09Cgb19EpB0G1bhU0wSWJi4z6Qo8HtnI05pGBDe84v+aM3a0uUSxsKcXCbRkYjA2OWbqXRzUY7K1dUAs7EaIEougeY8vl2POdp0OREGIz3CG6rEthWZLzHhS6vHmVtz4feFQBHt/v6R4IFQSSIOpt3Q1BXWDdJZMkT8Jl5Mcl80fhC0EEjgsXkKNuoeG0J5m9bFhW9DwDtiptfWDaeb6SgM/VrLekJFClmrB03zKLp9yDsD/ulL+KUEyUwNwVLoY2X87nbZ61zU1juzYWn8JtUF1n6xvqzBAty46kEUXrKoTqtqijqanPgQE9MVlBcpJAtMRTqGnB4bFRce7iFJh/Q+1mEAXGmqTKVE6v5ftJRYYVwD28EpavV71XAYzPo2DUfsGvsNSFvAeoncIi6vLTJcHXSj1oQPcj+wOYP1JAyrhcVXUlYAUWhsd814FlfDTyHuc8ECUrWdKono/NxNWPlJZKwlrJc8jyVZ/vAulc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Tvrtko Ursulin writes: > From: Tvrtko Ursulin > > If a task has had MPOL_F_NUMA_BALANCING set it is useful to show that in IIUC, MPOL_F_NUMA_BALANCING works for VMA area via mbind() too. > procfs. Teach the mpol_to_str helper about its existance and while at it > update the comment to account for "weighted interleave" when suggesting > a recommended buffer size. Otherwise LGTM, Thanks! Reviewed-by: "Huang, Ying" > Signed-off-by: Tvrtko Ursulin > References: bda420b98505 ("numa balancing: migrate on fault among multiple bound nodes") > Cc: Huang Ying > Cc: Mel Gorman > Cc: Peter Zijlstra > Cc: Ingo Molnar > Cc: Rik van Riel > Cc: Johannes Weiner > Cc: "Matthew Wilcox (Oracle)" > Cc: Dave Hansen > Cc: Andi Kleen > Cc: Michal Hocko > Cc: David Rientjes > --- > mm/mempolicy.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index aec756ae5637..d147287c4505 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -3293,8 +3293,9 @@ int mpol_parse_str(char *str, struct mempolicy **mpol) > * @pol: pointer to mempolicy to be formatted > * > * Convert @pol into a string. If @buffer is too short, truncate the string. > - * Recommend a @maxlen of at least 32 for the longest mode, "interleave", the > - * longest flag, "relative", and to display at least a few node ids. > + * Recommend a @maxlen of at least 42 for the longest mode, "weighted > + * interleave", the longest flag, "balancing", and to display at least a few > + * node ids. > */ > void mpol_to_str(char *buffer, int maxlen, struct mempolicy *pol) > { > @@ -3331,12 +3332,15 @@ void mpol_to_str(char *buffer, int maxlen, struct mempolicy *pol) > p += snprintf(p, buffer + maxlen - p, "="); > > /* > - * Currently, the only defined flags are mutually exclusive > + * The below two flags are mutually exclusive: > */ > if (flags & MPOL_F_STATIC_NODES) > p += snprintf(p, buffer + maxlen - p, "static"); > else if (flags & MPOL_F_RELATIVE_NODES) > p += snprintf(p, buffer + maxlen - p, "relative"); > + > + if (flags & MPOL_F_NUMA_BALANCING) > + p += snprintf(p, buffer + maxlen - p, "balancing"); > } > > if (!nodes_empty(nodes))