From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-mm@kvack.org, kamezawa.hiroyu@jp.fujitsu.com,
akpm@linux-foundation.org
Subject: Re: [PATCH] hugeltb: Mark hugelb_max_hstate __read_mostly
Date: Fri, 15 Jun 2012 11:40:24 +0530 [thread overview]
Message-ID: <87pq91m7fz.fsf@skywalker.in.ibm.com> (raw)
In-Reply-To: <20120614141257.GQ27397@tiehlicka.suse.cz>
Michal Hocko <mhocko@suse.cz> writes:
> On Thu 14-06-12 19:26:18, Aneesh Kumar K.V wrote:
>> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>>
>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
>> ---
>> include/linux/hugetlb.h | 2 +-
>> mm/hugetlb.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
>> index 9650bb1..0f0877e 100644
>> --- a/include/linux/hugetlb.h
>> +++ b/include/linux/hugetlb.h
>> @@ -23,7 +23,7 @@ struct hugepage_subpool {
>> };
>>
>> extern spinlock_t hugetlb_lock;
>> -extern int hugetlb_max_hstate;
>> +extern int hugetlb_max_hstate __read_mostly;
>
> It should be used only for definition
>
I looked at the rest of the source and found multiple place where we
specify __read_mostly in extern.
arch/x86/kernel/cpu/perf_event.h extern struct x86_pmu x86_pmu __read_mostly;
arch/x86/kernel/cpu/perf_event.h extern u64 __read_mostly hw_cache_event_ids
arch/x86/kernel/cpu/perf_event.h extern u64 __read_mostly hw_cache_extra_regs
drivers/gpu/drm/i915/i915_drv.h extern int i915_panel_ignore_lid __read_mostly;
drivers/gpu/drm/i915/i915_drv.h extern unsigned int i915_powersave __read_mostly;
drivers/gpu/drm/i915/i915_drv.h extern int i915_semaphores __read_mostly;
drivers/gpu/drm/i915/i915_drv.h extern unsigned int i915_lvds_downclock __read_mostly;
drivers/gpu/drm/i915/i915_drv.h extern int i915_lvds_channel_mode __read_mostly;
drivers/gpu/drm/i915/i915_drv.h extern int i915_panel_use_ssc __read_mostly;
drivers/gpu/drm/i915/i915_drv.h extern int i915_vbt_sdvo_panel_type __read_mostly;
drivers/gpu/drm/i915/i915_drv.h extern int i915_enable_rc6 __read_mostly;
drivers/gpu/drm/i915/i915_drv.h extern int i915_enable_fbc __read_mostly;
drivers/gpu/drm/i915/i915_drv.h extern bool i915_enable_hangcheck __read_mostly;
drivers/gpu/drm/i915/i915_drv.h extern int i915_enable_ppgtt __read_mostly;
-aneesh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-15 6:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 13:56 Aneesh Kumar K.V
2012-06-14 14:12 ` Michal Hocko
2012-06-14 20:43 ` Christoph Lameter
2012-06-15 6:08 ` Aneesh Kumar K.V
2012-06-15 13:57 ` Christoph Lameter
2012-06-15 14:33 ` Michal Hocko
2012-06-15 14:50 ` Christoph Lameter
2012-06-22 22:06 ` Andrew Morton
2012-06-15 6:10 ` Aneesh Kumar K.V [this message]
2012-06-22 22:03 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pq91m7fz.fsf@skywalker.in.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox