From: Andi Kleen <andi@firstfloor.org>
To: Qiaowei Ren <qiaowei.ren@intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v7 07/10] x86, mpx: decode MPX instruction to get bound violation information
Date: Sun, 20 Jul 2014 23:07:59 -0700 [thread overview]
Message-ID: <87ppgz2qio.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <1405921124-4230-8-git-send-email-qiaowei.ren@intel.com> (Qiaowei Ren's message of "Mon, 21 Jul 2014 13:38:41 +0800")
Qiaowei Ren <qiaowei.ren@intel.com> writes:
> + */
> +#ifdef CONFIG_X86_64
> + insn->x86_64 = 1;
> + insn->addr_bytes = 8;
> +#else
> + insn->x86_64 = 0;
> + insn->addr_bytes = 4;
> +#endif
How would that handle compat mode on a 64bit kernel?
Should likely look at the code segment instead of ifdef.
> + /* Note: the upper 32 bits are ignored in 32-bit mode. */
Again correct for compat mode? I believe the upper bits
are undefined.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-07-21 6:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 5:38 [PATCH v7 00/10] Intel MPX support Qiaowei Ren
2014-07-21 5:38 ` [PATCH v7 01/10] x86, mpx: introduce VM_MPX to indicate that a VMA is MPX specific Qiaowei Ren
2014-07-21 5:38 ` [PATCH v7 02/10] x86, mpx: add MPX specific mmap interface Qiaowei Ren
2014-07-21 5:38 ` [PATCH v7 03/10] x86, mpx: add macro cpu_has_mpx Qiaowei Ren
2014-07-22 16:18 ` Dave Hansen
2014-07-23 2:35 ` Ren, Qiaowei
2014-07-23 16:02 ` Dave Hansen
2014-07-24 0:56 ` Ren, Qiaowei
2014-07-24 4:46 ` Dave Hansen
2014-07-24 5:23 ` Ren, Qiaowei
2014-07-21 5:38 ` [PATCH v7 04/10] x86, mpx: hook #BR exception handler to allocate bound tables Qiaowei Ren
2014-07-21 5:38 ` [PATCH v7 05/10] x86, mpx: extend siginfo structure to include bound violation information Qiaowei Ren
2014-07-22 0:42 ` Zhang, Tianfei
2014-07-21 5:38 ` [PATCH v7 06/10] mips: sync struct siginfo with general version Qiaowei Ren
2014-07-21 5:38 ` [PATCH v7 07/10] x86, mpx: decode MPX instruction to get bound violation information Qiaowei Ren
2014-07-21 6:07 ` Andi Kleen [this message]
2014-07-21 6:11 ` Ren, Qiaowei
2014-07-21 5:38 ` [PATCH v7 08/10] x86, mpx: add prctl commands PR_MPX_REGISTER, PR_MPX_UNREGISTER Qiaowei Ren
2014-07-21 6:09 ` Andi Kleen
2014-10-13 17:41 ` Dave Hansen
2014-10-14 1:44 ` Ren, Qiaowei
2014-07-23 16:20 ` Dave Hansen
2014-07-21 5:38 ` [PATCH v7 09/10] x86, mpx: cleanup unused bound tables Qiaowei Ren
2014-07-22 0:50 ` Zhang, Tianfei
2014-07-23 16:38 ` Dave Hansen
2014-07-24 0:49 ` Ren, Qiaowei
2014-07-24 1:04 ` Dave Hansen
2014-07-24 1:27 ` Ren, Qiaowei
2014-07-21 5:38 ` [PATCH v7 10/10] x86, mpx: add documentation on Intel MPX Qiaowei Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppgz2qio.fsf@tassilo.jf.intel.com \
--to=andi@firstfloor.org \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=qiaowei.ren@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox