From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C6F1C48BDF for ; Fri, 18 Jun 2021 08:15:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DDAF96121D for ; Fri, 18 Jun 2021 08:15:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDAF96121D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3E4296B0070; Fri, 18 Jun 2021 04:15:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 395956B0071; Fri, 18 Jun 2021 04:15:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25DB46B0072; Fri, 18 Jun 2021 04:15:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0101.hostedemail.com [216.40.44.101]) by kanga.kvack.org (Postfix) with ESMTP id EA81E6B0070 for ; Fri, 18 Jun 2021 04:15:27 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 6F6978249980 for ; Fri, 18 Jun 2021 08:15:27 +0000 (UTC) X-FDA: 78266135094.40.D4C6050 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf27.hostedemail.com (Postfix) with ESMTP id 9C00780192FE for ; Fri, 18 Jun 2021 08:15:23 +0000 (UTC) IronPort-SDR: kiIZgiRMwOTHWIFc8XUJiF8O9H2RsIuCsCdwg3YBbFQBI4H0EE4+Tg9cHiCiz8eu8KRInXqs+y bKKcqtuEeiqQ== X-IronPort-AV: E=McAfee;i="6200,9189,10018"; a="186209356" X-IronPort-AV: E=Sophos;i="5.83,283,1616482800"; d="scan'208";a="186209356" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2021 01:15:20 -0700 IronPort-SDR: GhhtatfQ/voVXHKGuquDYJLyX5JoHfQQrL+zgp2nFsMIwuz0GWe1zyAUngtEuR/E2o8Vvl/Pzj yoY4Gispk+Nw== X-IronPort-AV: E=Sophos;i="5.83,283,1616482800"; d="scan'208";a="485604188" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.239.159.119]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2021 01:15:18 -0700 From: "Huang, Ying" To: Oscar Salvador Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi , Dave Hansen , Yang Shi , Michal Hocko , Wei Xu , Dan Williams , David Hildenbrand Subject: Re: [PATCH -V8 04/10] mm/migrate: make migrate_pages() return nr_succeeded References: <20210618061537.434999-1-ying.huang@intel.com> <20210618061537.434999-5-ying.huang@intel.com> <20210618075328.GA23470@linux> Date: Fri, 18 Jun 2021 16:15:15 +0800 In-Reply-To: <20210618075328.GA23470@linux> (Oscar Salvador's message of "Fri, 18 Jun 2021 09:53:33 +0200") Message-ID: <87pmwjpp0s.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii Authentication-Results: imf27.hostedemail.com; dkim=none; spf=none (imf27.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 192.55.52.136) smtp.mailfrom=ying.huang@intel.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none) X-Stat-Signature: inqafop7e3k11tqohpd5u949zf68rzmw X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9C00780192FE X-HE-Tag: 1624004123-961865 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Oscar Salvador writes: > On Fri, Jun 18, 2021 at 02:15:31PM +0800, Huang Ying wrote: >> From: Yang Shi >> >> The migrate_pages() returns the number of pages that were not migrated, >> or an error code. When returning an error code, there is no way to know >> how many pages were migrated or not migrated. >> >> In the following patch, migrate_pages() is used to demote pages to PMEM >> node, we need account how many pages are reclaimed (demoted) since page >> reclaim behavior depends on this. Add *nr_succeeded parameter to make >> migrate_pages() return how many pages are demoted successfully for all >> cases. >> >> Signed-off-by: Yang Shi >> Signed-off-by: Dave Hansen >> Signed-off-by: "Huang, Ying" >> Reviewed-by: Yang Shi >> Cc: Michal Hocko >> Cc: Wei Xu >> Cc: Dan Williams >> Cc: David Hildenbrand >> Cc: osalvador > > I thought we all agreed on making nr_succeed an optional argument [1]. > It reduced the churn quite a lot. > > [1] https://patchwork.kernel.org/comment/24104453/ Sorry. Forget changing this. Will change it in the next version. Best Regards, Huang, Ying