From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 002AFC2BB41 for ; Thu, 18 Aug 2022 00:52:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 755476B0073; Wed, 17 Aug 2022 20:52:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 704096B0074; Wed, 17 Aug 2022 20:52:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A7088D0002; Wed, 17 Aug 2022 20:52:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 47B5E6B0073 for ; Wed, 17 Aug 2022 20:52:13 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 107861C61C0 for ; Thu, 18 Aug 2022 00:52:13 +0000 (UTC) X-FDA: 79810886946.05.8CE2D75 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf27.hostedemail.com (Postfix) with ESMTP id 520B84008B for ; Thu, 18 Aug 2022 00:52:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660783931; x=1692319931; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=58ON10/L8BlQ/a/6dmh5aWnxs++pUDrqF1IpJhK5uis=; b=Q/YGW/UZMHSXYbc9lXT/korF6quXslMJ+lQ2929gs9GHoA9sUTF4jzNB wCw9vK2/lYA/xL0Wx9hLtl5aIVfI9wrANGhmu7ok2ziX61yPoQGjq0YA0 J6o6ZH+F1c/2J3y1r649JErONiyZOiA+fFh7kqMAp+6ADU7UNSmleqTvW chfAfixXhiHsUrWGJJiOc453tpAr+om3cTYuvhthhdypg99wKZ5GvFJx/ k5hRQltjLazq+0JYJVb2iSqaZmSaTAkIxck61oH0b6Hl1TDbr+pe9AsrK DwPExUEyULaIxZYrvuOSms/C8gHXyvwSFh21OR7KfZyl4kSnmY2LID2lE Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10442"; a="279601693" X-IronPort-AV: E=Sophos;i="5.93,244,1654585200"; d="scan'208";a="279601693" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2022 17:52:09 -0700 X-IronPort-AV: E=Sophos;i="5.93,244,1654585200"; d="scan'208";a="935589924" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2022 17:52:07 -0700 From: "Huang, Ying" To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Baolin Wang , Zi Yan , Yang Shi , Oscar Salvador Subject: Re: [PATCH -V3 0/8] migrate_pages(): fix several bugs in error path References: <20220817081408.513338-1-ying.huang@intel.com> <20220817084833.b348d11eab362b2ac5a02259@linux-foundation.org> Date: Thu, 18 Aug 2022 08:51:56 +0800 In-Reply-To: <20220817084833.b348d11eab362b2ac5a02259@linux-foundation.org> (Andrew Morton's message of "Wed, 17 Aug 2022 08:48:33 -0700") Message-ID: <87pmgybcgj.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660783931; a=rsa-sha256; cv=none; b=jeMZYRMMgbfFAo+cceQkiZkgkj1YdTMJPansnt4kb/pdlbi9jPVzPs262nH4QBsdIKKXtK S6/h7l0Y3pIl40ojKIx/nxCbGD2rl7ZOW3LSl1JfDuSk8/E0M0OAokf9EDHoKQFDHI6xWE w+6vITltN6YBV6Oq1d63iTNDYoL3Z6w= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b="Q/YGW/UZ"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660783931; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/n1PTtzt1ZAJeMiPqpf/RaGSSkqStAAdg3uVTHyQXmk=; b=vXISYTLUlhpsvNVuowC+fx60GYjMouJj+KPSalEsV5styp8wF/Oxmg93P7CMzgsGvkN1C5 wFaXbkVkVwJ6HMfa6lC6pd2YWvXJQnwFNuNhXvTiThzLCDES+yaflurvviOPm22vJZCJez d/VuPRdO39k5sh4OXomD0Dj71OxxIFc= X-Stat-Signature: 5yzjwigaiwkswbm66h5et9zjf79h7z73 X-Rspamd-Queue-Id: 520B84008B Authentication-Results: imf27.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b="Q/YGW/UZ"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1660783931-955456 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Andrew Morton writes: > On Wed, 17 Aug 2022 16:14:00 +0800 Huang Ying wrote: > >> error-inject.patch, test-migrate.c, and test-migrate.sh are as below. >> It turns out that error injection is an important tool to fix bugs in >> error path. > > Indeed, and thanks for doing this. > > Did you consider lib/*inject*.c? If so, was it unsuitable? I haven't take a deep look at that. Will do that. Best Regards, Huang, Ying