From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBF3EECAAD3 for ; Mon, 19 Sep 2022 13:52:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BECC940007; Mon, 19 Sep 2022 09:52:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06E526B0072; Mon, 19 Sep 2022 09:52:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E507B940007; Mon, 19 Sep 2022 09:52:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D5D3D6B0071 for ; Mon, 19 Sep 2022 09:52:41 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9BF9BA0A65 for ; Mon, 19 Sep 2022 13:52:41 +0000 (UTC) X-FDA: 79928975322.15.3E0A39B Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) by imf22.hostedemail.com (Postfix) with ESMTP id 11DE8C000C for ; Mon, 19 Sep 2022 13:52:40 +0000 (UTC) Received: from in02.mta.xmission.com ([166.70.13.52]:33224) by out02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1oaHCQ-000UIg-7I; Mon, 19 Sep 2022 07:52:38 -0600 Received: from ip68-110-29-46.om.om.cox.net ([68.110.29.46]:37536 helo=email.froward.int.ebiederm.org.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1oaHCO-007Sl5-GG; Mon, 19 Sep 2022 07:52:37 -0600 From: "Eric W. Biederman" To: Jiangshan Yi <13667453960@163.com> Cc: viro@zeniv.linux.org.uk, keescook@chromium.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jiangshan Yi References: <20220919025139.3623754-1-13667453960@163.com> Date: Mon, 19 Sep 2022 08:52:17 -0500 In-Reply-To: <20220919025139.3623754-1-13667453960@163.com> (Jiangshan Yi's message of "Mon, 19 Sep 2022 10:51:39 +0800") Message-ID: <87pmfr5v5a.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1oaHCO-007Sl5-GG;;;mid=<87pmfr5v5a.fsf@email.froward.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=68.110.29.46;;;frm=ebiederm@xmission.com;;;spf=softfail X-XM-AID: U2FsdGVkX1+VZ4y/8q2TorQ6l/dySqXv0i95p+myx0w= X-SA-Exim-Connect-IP: 68.110.29.46 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH] fs/binfmt_flat.c: use __func__ instead of function name X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of ebiederm@xmission.com designates 166.70.13.232 as permitted sender) smtp.mailfrom=ebiederm@xmission.com; dmarc=pass (policy=none) header.from=xmission.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663595561; a=rsa-sha256; cv=none; b=3mkuTM+dNEthE+1JLjW7gXbMwstP+OujqUbjWgqpJA9Cf4SzCxoz0DkvZjU9Js3Nb850Kj kPGL2gwxGTCMC82z8ocFnk56TW25u8aNHfKliA398VfG/fauex7VzoKkj9WcC6EtXVuLNR uQIW/cE8xIiKw4Oh8x7nlxN8C42EXbY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663595561; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cd5xdo68uP3d5ODuGetn21i/1toEAcfw4rxEM83xFM0=; b=2obnV1V4uo7f/GBHdlu8hJgfybBsjjrjfKHpgv1PC3+YdG279/x1LePiL0AFnUxiLy3OGU rOkgDiTncaUf2ptXbS8vi59+Tkn05v+1nCInxWDgCtNKKgWyxI/5+h0RdRWnReG1lJVmf2 PYUcodTHUO4qfVZ7ep28GddNHNnm4OI= Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of ebiederm@xmission.com designates 166.70.13.232 as permitted sender) smtp.mailfrom=ebiederm@xmission.com; dmarc=pass (policy=none) header.from=xmission.com X-Stat-Signature: q3hk4eakkiximcsskng9wdw739mexsja X-Rspamd-Queue-Id: 11DE8C000C X-Rspamd-Server: rspam03 X-Rspam-User: X-HE-Tag: 1663595560-926744 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jiangshan Yi <13667453960@163.com> writes: > From: Jiangshan Yi > > It is better to use __func__ instead of function name. Why? Usually we leave these kinds of stylistic decisions to the people actually working on and maintaining the code. Unless this message is likely to be copied to another function and it very much does not look like it is, this kind of change looks like it will just make grepping for the error message more difficult. Not that I am working on the code and can speak but this just feels like a gratuitous change to me and so I am asking questions to make certain it is actually worth making. Eric > Signed-off-by: Jiangshan Yi > --- > fs/binfmt_flat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c > index c26545d71d39..4104c824e7b1 100644 > --- a/fs/binfmt_flat.c > +++ b/fs/binfmt_flat.c > @@ -184,7 +184,7 @@ static int decompress_exec(struct linux_binprm *bprm, loff_t fpos, char *dst, > z_stream strm; > int ret, retval; > > - pr_debug("decompress_exec(offset=%llx,buf=%p,len=%lx)\n", fpos, dst, len); > + pr_debug("%s(offset=%llx,buf=%p,len=%lx)\n", __func__, fpos, dst, len); > > memset(&strm, 0, sizeof(strm)); > strm.workspace = kmalloc(zlib_inflate_workspacesize(), GFP_KERNEL);