From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E344CC77B73 for ; Wed, 19 Apr 2023 06:07:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 691238E0002; Wed, 19 Apr 2023 02:07:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6417A8E0001; Wed, 19 Apr 2023 02:07:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 508D88E0002; Wed, 19 Apr 2023 02:07:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3DFFB8E0001 for ; Wed, 19 Apr 2023 02:07:25 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0C51F401AF for ; Wed, 19 Apr 2023 06:07:25 +0000 (UTC) X-FDA: 80697108450.25.A7E92F6 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf27.hostedemail.com (Postfix) with ESMTP id 5F7BD4001E for ; Wed, 19 Apr 2023 06:07:22 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UYJy2vrh; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681884443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6iyH6q7YZtRhA5ccOwBt/xKQoMnT3knReQeBLleuPo8=; b=Ats0gueqY26lSQpCui1x5pgUktevl8FYHJJwef7SsCeamJYiubZuA5Ziz+E3IihuuMoJvp cLRijIT/8waN02Met6owmjdSw+y3LLYG3dgo/EImJWhLVbwzpJZNVSOMB79hiiEPv93Qjo LjHn2ze/8jC+dEFyCe44mZWsU8RGqmI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=UYJy2vrh; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf27.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681884443; a=rsa-sha256; cv=none; b=KtyLcOPoqnOVVegwaL2PHEEktS7XjTp+69g1yzLCRB9eVQpDb5yuxJ1dBulSQQyefafQyf fK+zy8pQTtYN1KH0cHhRe0K8jMglfr3UZh55HOk3zeDFgV+y3tRzk85QkF+sOUYqi8LQCJ +1nJU4lt4k7Suv5KZz+iP/7PXDGTKhg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681884442; x=1713420442; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=HL4/IpuRxVTfl2tt7aPzdAuCiKtCuY7ygljEjn2Iws4=; b=UYJy2vrhZptHBbmAy2ngSn+YahdaPszphMEsl9rqS8hHTPVW2pZ/IuF9 /0y6XTJ1KKZ5YUK7YL4oftML1uQHf1wgqvw52LcSQ6fWatE9i0TvG17Ho qUwnijmyChZttRN/zqTYXQ3OL02F1YtHspJvZyuNOkjG3jdiGmZ/N13T1 I6RlBXhF4IRZ2W0b0gXalFeVMLQuXDuZXsdvM9DSTJv4Cyo4HPjXd27ap N8YD9aEagcb9i4VvHUYIiZCnrtfSA7yjxbsdtpr/j9DAclWp06o/W6FTX KQX8O5tFA+bzvrz9B2imQeswAYc1ef0VCOOYsoF2oaq/zTRR7erBe08pM A==; X-IronPort-AV: E=McAfee;i="6600,9927,10684"; a="410593569" X-IronPort-AV: E=Sophos;i="5.99,208,1677571200"; d="scan'208";a="410593569" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2023 23:07:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10684"; a="721783828" X-IronPort-AV: E=Sophos;i="5.99,208,1677571200"; d="scan'208";a="721783828" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2023 23:07:18 -0700 From: "Huang, Ying" To: "zhaoyang.huang" Cc: Andrew Morton , , , Zhaoyang Huang , Subject: Re: [PATCH] mm: skip CMA pages when they are not available References: <1681882824-17532-1-git-send-email-zhaoyang.huang@unisoc.com> Date: Wed, 19 Apr 2023 14:06:05 +0800 In-Reply-To: <1681882824-17532-1-git-send-email-zhaoyang.huang@unisoc.com> (zhaoyang huang's message of "Wed, 19 Apr 2023 13:40:24 +0800") Message-ID: <87pm80tnhu.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 5F7BD4001E X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 49qrae9wh88t8srckgxunfjsib6trx8y X-HE-Tag: 1681884442-920688 X-HE-Meta: U2FsdGVkX18+JVIFMvorjZt+WlWYZrgiS+kPwqpm4OxtyiAc1qh7sikSvjWJFWy0VOCtq79xnzCuVUCxPhZm8DaAtITGrdycF/H3KHwmNXenMEKBefzPKPrUPKyraEwcqik+mT7KhB/wWJX+/xePZiBYY4WVv6V+twlzuaM1O5/UwiyWFMm4cdCQduwjxwrVDypft4myTF/Nnz1h3yGtdtz0lYmfAMfxmK8M4BRMqamfk67LLRsFUloQnfuVuCeEE06ghdvJuY+VaJAQz9mwlOps+Hf/NPZaZzqX7CiBlYN2Z97GTr16uStuwe6yg8y5U4fJZcWLYcKo/MpU3KD5PZapm4pvMumVZrynhR+6K/pKkaG8Sn/vynRohwdeNqyQtOX2T9NOPgj/wcItcs2vjHfcVfIpZv/NJtqNve2Imb2G0kMTdxIA82w95mOsbBDQEAioyW4hhxdra5xUDb+23PyFOZc2/8a861gl8Con/SMU++lK4xrWNj8qy+ZiJWFiW+bSaAqWKLjnsz8cLHzNAu3+DPKX6ueSc99XxaLZfnt8VqF+6DJDPyTTZafu2nsjLX6/dR6kRX3O2JK6M6IpH/WRY0LDgDTfe20hrVOKN1gXSxltG15ZVM0EaknmEB2m9zhZPNJZypf55ry2HkOLvpTX0TzY2z2NhUoLVO89pZSTp6xDU9M6l157f99Ak14QXJeTgFrqtgqYy3U80ulVmqUn2qpUUQee35QK1af/xKZ2pDySKH6oxEZ8HMp0aq3rAvK0e2iiy/805LOaPwqY83bqSLpa/mnOPizt8wx9uBVMz9TFIGD5Uk+fEsTLcFU1vQQmKNamNT2pnndtMQ4EX/QQ2dPbHfut3gUHzNqL49JXM6Ez1TZ36fpNixuFlxgPdp0Y3QfWA52CebWzhS1kPDCl9EZsjxrD2xsx3feakl3zLeNP+3Ro/W+Arv/dpugVlXvAQQ8yZLiRLFU3Gt2 gKJTlgaz mSwbk9BBbsRLw24Cht0k4wV3Aq5ztM53XU6vjcAeOIDgdB3Uo5YfO9DcrpzFQFWtJ2gM9YJkM/neNfvw4x0QLcqZEjxXXxMSMG7Xzl/4BQ4mcVda5HNcmVu31bQr1SQ2NUSjMxWsbcRcROI3zA2pTGmpAZ9AsDDC9wnEtBNMjIhlhL99RpF70BhQG0V3hKWIyP/ZUvqxh+pTEXJ1JJOj3/6RlXFffV4ZvMgIA3zvIiPLnNbVKIr/lCdFzrEY9SsEO01WgqiaQJPwtwWhGgp39EojtloUCIzNmKPLX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: "zhaoyang.huang" writes: > From: Zhaoyang Huang > > It is wasting of effort to reclaim CMA pages if they are not availabe > for current context during direct reclaim. Skip them when under corresponding > circumstance. Do you have any performance number for this change? Best Regards, Huang, Ying > Signed-off-by: Zhaoyang Huang > --- > mm/vmscan.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index bd6637f..04424d9 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2225,10 +2225,16 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan, > unsigned long nr_skipped[MAX_NR_ZONES] = { 0, }; > unsigned long skipped = 0; > unsigned long scan, total_scan, nr_pages; > + bool cma_cap = true; > + struct page *page; > LIST_HEAD(folios_skipped); > > total_scan = 0; > scan = 0; > + if ((IS_ENABLED(CONFIG_CMA)) && !current_is_kswapd() > + && (gfp_migratetype(sc->gfp_mask) != MIGRATE_MOVABLE)) > + cma_cap = false; > + > while (scan < nr_to_scan && !list_empty(src)) { > struct list_head *move_to = src; > struct folio *folio; > @@ -2239,7 +2245,10 @@ static unsigned long isolate_lru_folios(unsigned long nr_to_scan, > nr_pages = folio_nr_pages(folio); > total_scan += nr_pages; > > - if (folio_zonenum(folio) > sc->reclaim_idx) { > + page = &folio->page; > + > + if (folio_zonenum(folio) > sc->reclaim_idx || > + (get_pageblock_migratetype(page) == MIGRATE_CMA && !cma_cap)) { > nr_skipped[folio_zonenum(folio)] += nr_pages; > move_to = &folios_skipped; > goto move;