From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2055AEB64D9 for ; Mon, 10 Jul 2023 06:13:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6504B6B0072; Mon, 10 Jul 2023 02:13:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FFCA6B0074; Mon, 10 Jul 2023 02:13:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C8B86B007B; Mon, 10 Jul 2023 02:13:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3AE4E6B0072 for ; Mon, 10 Jul 2023 02:13:21 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E24BD12027C for ; Mon, 10 Jul 2023 06:13:20 +0000 (UTC) X-FDA: 80994684960.30.4E41CBF Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf05.hostedemail.com (Postfix) with ESMTP id 3255C10000E for ; Mon, 10 Jul 2023 06:13:16 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OH2dIzp+; spf=pass (imf05.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688969598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zJ8iyYiydLY+kk7HhErv9yaf34x356rSzR1vF/NPjVo=; b=qOJAzUFEjbMPbe/CK8aJ6w1TQWj/3IZdEPjLxnuc3eGkZz2dscqtnPVSX8bO/jOTZEavBm hHFwNxdT75Pb665Bw2sweuyQck/55cZy+fVGaraCqvAAC26jCz2girZktSxgcn66gvFOaM fkkwGC6W8VEW8yF1DPqAk6KL4sZlV3s= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OH2dIzp+; spf=pass (imf05.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688969598; a=rsa-sha256; cv=none; b=x1FDam8do8zhdwrN4iIzmgV7k5Exb9HnwYY2t5jtuwX2OQ8mBhKXRNDf06/QC9CUdBKpuS XSELXaeJh0dTTutQjh4hjWWaW+Bb433pguO4fRtcjcyggSF+bUj8owLDwrH0KVsKRMzeod qnrNQln1buzEQhqtV7n4nlmTCrmmNvE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688969597; x=1720505597; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=4aybMDCc0kzO4ssUfb3GudNz2ZedSVSfcl287JTXCjU=; b=OH2dIzp+f9ybe9QjUex4NjbIeGsSt5/3qNXf2hu8Z1D7nM/Kl1eUyDOR 4mHFij4auPcnWYxn9IP8wrseNJ/Ca0+Qv5/We+xcCDJ+kWHdEfg5WVqbU B5tFirY84cycGox+7SNZ/u+GHXEt3h9HnFMVheZITSwhI8Rtzs3b0zS4D ZGYq173aoz5Y0DE7GUHxLM1UlrMuSgodcuixtI2fQzcvUUC0B+hlZNgnZ xbi6HUnNi0zLntXtSEcaI3fxk+tiGtrzmmPwHOKOPrtjMCnqBWjLJkvCR TmxJnLqUjuo8yAOhh3L9AzHCaQcVkz8PHe/3nJbQRumCLHT7sjNLha9Fg w==; X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="354123138" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="354123138" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2023 23:13:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="1051242704" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="1051242704" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2023 23:13:12 -0700 From: "Huang, Ying" To: Baolin Wang Cc: , , , , , Subject: Re: [PATCH 2/2] mm: compaction: skip the memory hole rapidly when isolating free pages References: Date: Mon, 10 Jul 2023 14:11:35 +0800 In-Reply-To: (Baolin Wang's message of "Fri, 7 Jul 2023 16:51:47 +0800") Message-ID: <87pm50fg88.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 3255C10000E X-Rspam-User: X-Stat-Signature: eafc99adgbwn9uursdcp5g8i4tn7prhd X-Rspamd-Server: rspam01 X-HE-Tag: 1688969596-408376 X-HE-Meta: U2FsdGVkX18DHlEKV+Lqvfr3iwuWVpOMhx2ppB7FWNf5KIpD+R+jpNOi8EUFS6NMUTeEQM0MQ3uk35T1uUd/iVJPhZ0mrZJ4ELTU1Eb4p614P3rRAEgQ+RaJ26wi0TM81G4ebdySoGFlKDYeTZkUGZ/OkAdt6CHF2X85SqXbQpIw4kS5u05vcQ4dFa6SO7bhdyKI9s1+6aEWXeQy8Izy4OTewR0CKRnGKzIY5dOGQQvoif+vHPlS9EKtGlhUrZZ7Ru8hwLJ/BjWicQiMHorXVOb4FF4loYTXxAwzoVxv5NlUrDt9mZlOorq7tUEfsS1x7J5JeaRpzmo9hXYO9pt/fLQaAsFECf/FH2C1/3DC5J9FVxR9eDLi5VwLS0/E7PR1orVgvACPNRE1RSlUVpuV1ctj0Cw6dj6UzOY5Z6Ml+8WwVRJuHRkg59gN8LEqZ8Fa+9p583Bn1EVUsEIB9ecnisk20WsPtBUd7k2VQ7suzey4TO1/XuMHVcSkjZVPIM6OOJSqUIjNAp/TGjMNl793hOIbgSCwj3SFaaDfn2kaNF98I8C56/mTKQJkSyyTuasZJnvhvAaQ31auGZj+8UT1AW/0ksn5H/BGaZlKubLa8DaLZ+K7Kt8Smz8b79NPdZRCq7VbeAHIAxPCu17feibgCA8qd2sHQXIpbUrhIHkK7Lqk82ottjnv6JFXXV2shfqcjWLahbL94U/pq+vZ8AMEOLD07xt8Ksk8ZIOZRyDAOrUZrRKA+G6DnSQ6e53Q2UB9hmYz2kjt/fpZcRUZcMfG58aVu0x6vS9w2kVPt4qglJn6QZgCVD31jLtDT1uyN8iBc0nIv5ZT+R4fFDcD34Fe3XvoUB86FmFXkZXou4epOT3piOwgLd2wlGvRZ4lNuzKJfgbMIU8LHtonOn3cA3dDHuKAPTvpldcekpoSNaLR3KidbVC3KW/bQzdCxMtvdXcGP5Bk4ftvOFv/c8Ukiih +h3e1VuB +ax1WIsU1BQDMr9P6AOqTKYWNiLAdIaozXZhKtMcJo+5JkbOLOHxnAxTmuBs9upU+AP5s8KyCXrvf8OzQL7A+LAI1ea32+eyxXm8sDeJZnAmyHnlIS6ZS+Ky8CpjOaMDiT9673/Nv4HD9lPnEFG4iHLUOWKTHFwVcFcEMQxY3oaFN6kY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Baolin Wang writes: > On my machine with below memory layout, and I can see it will take more > time to skip the larger memory hole (range: 0x100000000 - 0x1800000000) > when isolating free pages. So adding a new helper to skip the memory > hole rapidly, which can reduce the time consumed from about 70us to less > than 1us. > > [ 0.000000] Zone ranges: > [ 0.000000] DMA [mem 0x0000000040000000-0x00000000ffffffff] > [ 0.000000] DMA32 empty > [ 0.000000] Normal [mem 0x0000000100000000-0x0000001fa7ffffff] The memory hole is at the beginning of zone NORMAL? If so, should zone NORMAL start at 0x1800000000? And, the free pages will not be scanned there? Or my understanding were wrong? Best Regards, Huang, Ying > [ 0.000000] Movable zone start for each node > [ 0.000000] Early memory node ranges > [ 0.000000] node 0: [mem 0x0000000040000000-0x0000000fffffffff] > [ 0.000000] node 0: [mem 0x0000001800000000-0x0000001fa3c7ffff] > [ 0.000000] node 0: [mem 0x0000001fa3c80000-0x0000001fa3ffffff] > [ 0.000000] node 0: [mem 0x0000001fa4000000-0x0000001fa402ffff] > [ 0.000000] node 0: [mem 0x0000001fa4030000-0x0000001fa40effff] > [ 0.000000] node 0: [mem 0x0000001fa40f0000-0x0000001fa73cffff] > [ 0.000000] node 0: [mem 0x0000001fa73d0000-0x0000001fa745ffff] > [ 0.000000] node 0: [mem 0x0000001fa7460000-0x0000001fa746ffff] > [ 0.000000] node 0: [mem 0x0000001fa7470000-0x0000001fa758ffff] > [ 0.000000] node 0: [mem 0x0000001fa7590000-0x0000001fa7ffffff] > > Signed-off-by: Baolin Wang > --- > mm/compaction.c | 30 +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 43358efdbdc2..9641e2131901 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -249,11 +249,31 @@ static unsigned long skip_offline_sections(unsigned long start_pfn) > > return 0; > } > + > +static unsigned long skip_offline_sections_reverse(unsigned long start_pfn) > +{ > + unsigned long start_nr = pfn_to_section_nr(start_pfn); > + > + if (!start_nr || online_section_nr(start_nr)) > + return 0; > + > + while (start_nr-- > 0) { > + if (online_section_nr(start_nr)) > + return section_nr_to_pfn(start_nr) + PAGES_PER_SECTION - 1; > + } > + > + return 0; > +} > #else > static unsigned long skip_offline_sections(unsigned long start_pfn) > { > return 0; > } > + > +static unsigned long skip_offline_sections_reverse(unsigned long start_pfn) > +{ > + return 0; > +} > #endif > > /* > @@ -1668,8 +1688,16 @@ static void isolate_freepages(struct compact_control *cc) > > page = pageblock_pfn_to_page(block_start_pfn, block_end_pfn, > zone); > - if (!page) > + if (!page) { > + unsigned long next_pfn; > + > + next_pfn = skip_offline_sections_reverse(block_start_pfn); > + if (next_pfn) > + block_start_pfn = max(pageblock_start_pfn(next_pfn), > + low_pfn); > + > continue; > + } > > /* Check the block is suitable for migration */ > if (!suitable_migration_target(cc, page))