From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40563CE79A8 for ; Wed, 20 Sep 2023 03:14:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD3BA6B00FF; Tue, 19 Sep 2023 23:14:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C5BE56B0100; Tue, 19 Sep 2023 23:14:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B22E66B0101; Tue, 19 Sep 2023 23:14:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9F31F6B00FF for ; Tue, 19 Sep 2023 23:14:48 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 65315141218 for ; Wed, 20 Sep 2023 03:14:48 +0000 (UTC) X-FDA: 81255508656.07.148AE98 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by imf06.hostedemail.com (Postfix) with ESMTP id 5DF6318000C for ; Wed, 20 Sep 2023 03:14:46 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=NxnVzw9J; spf=pass (imf06.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695179686; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XFq5tXNchP+SyC0gMlmfOfh8zDCKBzyXOd/oMkHEfMQ=; b=Yf2W0m+QmkI+Mf9JqzCjmNYzCviZFQTfYGwHAoJUwKIoXzS1qV9Md9UITf0B2HzUldltIl 5VVugCtFMZOFW2aiW5gafPUYL6DEpGT8v+fJpTShIhdsgd6+p+O93C9HL2aWznYJBhYCN/ PkLkx+px2DvqgM68GgMxiJ6vP32C158= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695179686; a=rsa-sha256; cv=none; b=XosiWh4LqLL194so+BmsMdtAzYEfmB+MDIMoR+krKUM1E7VwUnBwEbMydEq+b2kyOQADXg BgxN5q3Xwn4QAhXWDNOiYTYhYphAyPYi8jiHqLx2cc+jYKmmeW+rpg49GbCJgdYLHGquEF L0M8LmR6MnfkyxM8DCZfVOqDMxWp79I= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=NxnVzw9J; spf=pass (imf06.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695179686; x=1726715686; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=1SxDjFkG+rS8siB7pgMqaoqzXOfpU9xxTwYAc924F0U=; b=NxnVzw9Jd6KIifSOBNzY3iykO/KkcU66Aps+BnqTKoyTanSnAKfCmiy0 unComyfFeLQz2gNXKhpizLx1eSvdGSpojLTPBFXZ3LNf/5ukYs/YDREzy brKhvDPX8U1NB6DDNNgfcTjX+vwQNgnEkjB1ORMtE9DWeqVkr+Noit5k2 zZe/GMmom1ljGWAHfAPeeiPmoncKOejrQTDZNsoR875fn9nw7+iTQnSzx 7iE1/aR85g9bLqyLuQlTw/sW2ThxVl/au2K1iksH+Z2mAtQqFJh97AiYg oQIZPmISvJg2cr8UGR2gNsZi2EzU/T4tGQcslr2d7JnzfC04VCXDuObK+ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="370425531" X-IronPort-AV: E=Sophos;i="6.02,160,1688454000"; d="scan'208";a="370425531" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 20:14:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="861800218" X-IronPort-AV: E=Sophos;i="6.02,160,1688454000"; d="scan'208";a="861800218" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 20:14:42 -0700 From: "Huang, Ying" To: Kefeng Wang Cc: Andrew Morton , , , , , Zi Yan , Mike Kravetz , Subject: Re: [PATCH 5/6] mm: memory: add vm_normal_pmd_folio() References: <20230918103213.4166210-1-wangkefeng.wang@huawei.com> <20230918103213.4166210-6-wangkefeng.wang@huawei.com> Date: Wed, 20 Sep 2023 11:12:39 +0800 In-Reply-To: <20230918103213.4166210-6-wangkefeng.wang@huawei.com> (Kefeng Wang's message of "Mon, 18 Sep 2023 18:32:12 +0800") Message-ID: <87pm2dwna0.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Stat-Signature: xj6hu4qqwai87u3y45nozemzat4ms48m X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5DF6318000C X-Rspam-User: X-HE-Tag: 1695179686-110563 X-HE-Meta: U2FsdGVkX18mH8030vRD1Ao4GtV93E0a0j9Al+RInpnWcD+xxRAAr6l65uZgAT2k5NLWfjuL9edBNfCFwtw51xDOj9sZ/yQalfC1s2F6j922paZpTZ88uLRLnReG++eVPqcCyUZ0Rcw/tl+wzL0EtD6ChJlEO+fn/JdTGPEO5v0v38jScCb9+A7eePmUKwQYx/DzPD1wX1E5rYd1KkwhjuCOK3jRS5SdAB20FXHwHQE77F6X8NK+CiBLiyPqe7dY6pUSBOqKw2j1ljBQbYy9SOtdc5G7UCEK1/necgfYFb7kpfT1gZ3d2sk1nZ3wNh+qSiujqY9tHi3Ugbs5o2qdZO9R90A4Xr3DphKfgD5EdUmY88Pdn1iDlA4pGv2nTp1OmlOTdK2Hm0YOPcQXdTDOFI5FuqTVrwAx+8DgXp3U3MY+t466ZMPJhVXUdQZFVNPvYbbIdQC56p3P+/CDYTWiDACA5fI719i5vNOt3dMyB5scEI3K6DCAQVHhc3qJninShOd84HNmcepuLA+3wO5dQYxceFujFyH5E/2IHCw2uaSFhw2FYOV7CSdqXG0DluhiA6Rwk6xCER/2lj3Wsy2AQUL+fcN+8Wb2avwLek7C0gGypC58y/YF8c6xMzxvEwHiXTF8ypVSoLezxLv5z8ICzngqH1C3n+qooyLEDeI+M7O2v/CDrdDKml+g9PhB1gbIebggSf7CIIjW3j/SssQ1871/P64X1YvQszI5zFylP0CBVPjG80KKf8keb1kDHi3uEW+lnq3E2eOfOj2V1WvA7yIenzib+icUNhL7G9sqcXtdrVgcelTUsDT0a5TLK0uSY3XqlhDrPU0nOWG50rLCOe40lDc0fnfcHd4/1+jM2gmGToMTKjwFkjFnaMbyvSlC69DJ90LdjJO0ZbZTwU8YzeLmR0VzfkOhp1FCwMWbwVIaGem7iPZpdiuQPBqHu7fHwfrvWAor4LWFyO9KQh7 12GoynjM j27H+Pu7v9OORKq1xz8ebkfziTPC3d4c6txocEgFesTi0fG7MquulG6NAkabCNru1z51K5Cmm49d58nwRc5DwQ8aDrrI9e82+/i88hJIZHG+lnmVLqoI7vAS3X7rqq5aYh4kHFcf+znULwiJqyeGULF3I0an5lqrGL6IczElR4wiW+CwzKSxlBAKDkH9HeBLCYHEGC8cQtvjSItUsgmZzWi9mIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Kefeng Wang writes: > The new vm_normal_pmd_folio() wrapper is similar to vm_normal_folio(), > which allow them to completely replace the struct page variables with > struct folio variables. > > Signed-off-by: Kefeng Wang > --- > include/linux/mm.h | 2 ++ > mm/memory.c | 10 ++++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 12335de50140..7d05ec047186 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -2327,6 +2327,8 @@ struct folio *vm_normal_folio(struct vm_area_struct *vma, unsigned long addr, > pte_t pte); > struct page *vm_normal_page(struct vm_area_struct *vma, unsigned long addr, > pte_t pte); > +struct folio *vm_normal_pmd_folio(struct vm_area_struct *vma, unsigned long addr, > + pmd_t pmd); > struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr, > pmd_t pmd); Why do not follow the counterpart of page (vm_normal_page_pmd()) to be vm_normal_folio_pmd()? -- Best Regards, Huang, Ying > diff --git a/mm/memory.c b/mm/memory.c > index ce3efe7255d2..d4296ee72730 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -689,6 +689,16 @@ struct page *vm_normal_page_pmd(struct vm_area_struct *vma, unsigned long addr, > out: > return pfn_to_page(pfn); > } > + > +struct folio *vm_normal_pmd_folio(struct vm_area_struct *vma, unsigned long addr, > + pmd_t pmd) > +{ > + struct page *page = vm_normal_page_pmd(vma, addr, pmd); > + > + if (page) > + return page_folio(page); > + return NULL; > +} > #endif > > static void restore_exclusive_pte(struct vm_area_struct *vma,