From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA0CAC61D9D for ; Wed, 22 Nov 2023 17:43:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58C556B061D; Wed, 22 Nov 2023 12:43:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5153B6B061E; Wed, 22 Nov 2023 12:43:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 391A66B061F; Wed, 22 Nov 2023 12:43:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 23C746B061D for ; Wed, 22 Nov 2023 12:43:36 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EBE9D81242 for ; Wed, 22 Nov 2023 17:43:35 +0000 (UTC) X-FDA: 81486312390.29.23DFDB6 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by imf05.hostedemail.com (Postfix) with ESMTP id BD5A8100013 for ; Wed, 22 Nov 2023 17:43:33 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=Lhqp2f1K; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=gQ7X9tiI; dmarc=none; spf=pass (imf05.hostedemail.com: domain of shr@devkernel.io designates 64.147.123.19 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700675014; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HGqIVGUX4u3PtJ0XmRkxpd4ga76lF2lDbzJ+i5QVFks=; b=gQByjOPHdzFhA2FSRZbfgNJJeNF6P5QMgF6VFg0BbjMWuv/VYg9mzpB5U4cPtaJPhHthg3 0K50ea22uSEuxNUGDQYWznbuLbqIr5vdK9XUnYNcPlCp9ofIug6CW00UO7TQDwXhghWD/D B1Xmi9Ykr4qH1kmc0aEQJBLZxgDqZws= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=Lhqp2f1K; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=gQ7X9tiI; dmarc=none; spf=pass (imf05.hostedemail.com: domain of shr@devkernel.io designates 64.147.123.19 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700675014; a=rsa-sha256; cv=none; b=unViAuRnwtjIgvFoFSp8egoleNjGvLw4pA5ktg4ln61nO6a16w9G7NUdEBjoPnmgOcjXA2 Qmass4YBaf7FG2cl9vloew3XllxgOg+C3eWmyzQqxPnVXB20VQEBygFtHpSgILMVKCpVTD 49JN9X4PXCbmiT1eZ3VisfCs/VFA35M= Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id EB9BD3200A24; Wed, 22 Nov 2023 12:43:31 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 22 Nov 2023 12:43:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1700675011; x=1700761411; bh=HG qIVGUX4u3PtJ0XmRkxpd4ga76lF2lDbzJ+i5QVFks=; b=Lhqp2f1KdShPl2Jus8 DpvRpkbT3N1ebRoAo07BdizqTIMp2Ejfd7AxIcY1nycwzBFdr6N3wJn7KlqToXVE nAPgsUHSH0g5Of4GfN0z9UlnSWz6E8jYUpgiG5s2iSos5E+MIteBZJzNn+pGeE54 qVnObB3nJRBMTOZT/3BX2xsl/CQNAo0/NZRf3D9vOZ5qd4mZG930C7MSnscFEwOa FIgTC41KNsBKR6XDpCSLawRbdPz2dvHUpS9p4NUs3WUBmdbX+/kiGBxfQZBbI977 l+KohS4pQIopl6WFxW2WxOhmtYGbxRe9eDdlaCLc6gEdA7GdlcHkjG7mwtLwmp3i tgqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1700675011; x=1700761411; bh=HGqIVGUX4u3Pt J0XmRkxpd4ga76lF2lDbzJ+i5QVFks=; b=gQ7X9tiIr/0YQPbX2tNSU36AJE0/1 0AwevGsbP0k2eyCXphrV9hZw2TkXT+ZWe+GLrc7POmCEOIlM9lvrmCn4P5fFMQ3g WOVdzW/wRf+hBl+5W1AO1riQ8PrtEisimnzYBhaLt4n2faQ4OCzctQqbUs0czMHS LktQWJ0Axw2npGTxdmodcwcho5mJD4hu6QhckbCyWtkxCqqFk+UvXG+q0N03jRXJ 5O0mxHo6kWozWYfvR7boTGylbGnd0aedHqodZJnSW0NjvQKUc3Nu2/InG2P9/qHG lopAdmKxr6ikVIdYh5sFtRHCa+LLWSmjBfYDcifoOO4kQ39yT+XznLJJg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehuddguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefuthgv fhgrnhcutfhovghstghhuceoshhhrhesuggvvhhkvghrnhgvlhdrihhoqeenucggtffrrg htthgvrhhnpeevlefggffhheduiedtheejveehtdfhtedvhfeludetvdegieekgeeggfdu geeutdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hshhhrseguvghvkhgvrhhnvghlrdhioh X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 22 Nov 2023 12:43:27 -0500 (EST) References: <20231028000945.2428830-1-shr@devkernel.io> <20231028000945.2428830-3-shr@devkernel.io> <724f61a5-4d02-4232-ae8f-71f55e73186a@redhat.com> User-agent: mu4e 1.10.3; emacs 29.1 From: Stefan Roesch To: David Hildenbrand Cc: kernel-team@fb.com, akpm@linux-foundation.org, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 2/4] mm/ksm: add sysfs knobs for advisor Date: Wed, 22 Nov 2023 09:43:09 -0800 In-reply-to: <724f61a5-4d02-4232-ae8f-71f55e73186a@redhat.com> Message-ID: <87pm01r8eb.fsf@devkernel.io> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BD5A8100013 X-Stat-Signature: cemgqyacwzwsskdfs1i873i5z9m9858g X-Rspam-User: X-HE-Tag: 1700675013-216597 X-HE-Meta: U2FsdGVkX1/PP6OCJcu2XdDzMot9mIFs2M+zBUpW3TwZWRX5qvb5R+KLv7hlLGq81vPzaTc9voH/NUPvWK2rYtPrMYh6Gy3hTtu74rPx2Ks995ptYMdinJQ1RdZvuL0d/HlXKsts+xZBq0YudMK9FDzXyGWJ0ukMtHutkdI1PBmAKvgrRT2MACWvLv6WoDO0vXMpbuoXfjIDEZw67RUDGobu1Ua5HcjXrkzVz/HPkDk8twwVfMpPN4kPcmDHFR5HbO9MxPOHnFxjLBI0hzXffgLNf/tVXsFl/vb7/9IlDjHDF0ITW4xpTHp+UoIwYdVonUZqusHcjfOieW+Fva6q6sU9+37YLdRGKmOcy9HEjL8t2yQt2/7cpAKTMy9Nqsc27rJ357ZxIrMs42ku7l0LhTlJNWdg1JmdoTzZmg6kv7fhq/8nUAsdFAAfC3H+wCGAejc7mJRbwm4053Jsr/XDKaIknmYkPo10a8QzcBIb6b6k0zPdOGO/CNotL0XGtceet+nDwxdIyMidHxZxDjCA0KmBhFhUnpBWFctKItZBh7jcp5flGBKdNTW3jTRxx7215zYhjgIhNBmcdxApbi7j2dT8vUESrEWfJ4CuYeTr1xr1556dyi2HHBc4uC/c0n/CCyBIb6CqpYKMzwOZX/jBsi0Elw5i4bX2opa7AQLAqnRXo7sl26LD29m6lkQ5QM3F5fJoNxbfRUtL523xLafP/zMvThJ91UTtr5m+b3T9PuysgAJeTmPX94TNmIrEfRwHWjRdWly1fV57HRSdeeM5763xec4GCeI6Ar3S/pr1Mj2AGk1RK+ouGndLDCiNnWT8it5Xb40pWXCshTSyxnk88XosGA/QEaVzk+WBsUJpjwTFBqGIsiCj5X+JUJcmcyWj97aPalBwg+jEC70NVQNb3CNLVS89ZPmEmuOnhD7cYpaB5p409Ep2YFXnj3+a6akZiFD6pe2dTo0wRTnEdie HOgFgHLa /Yo3iIizhIOVx5Z+3SxrX+NjtCUtmmX4ZcpkX2ZpYtRsr01GzF54HRXbsd8ycY6uD21QhIzlerBl0AQy4f8uIt6vIo8v0kPGrVoL0XOfHSbKOxV4OMXaa4wtzfdAcuEFborL+K5YyMkCXuiWkAlIec4DELfdbJGjMJbZWpxHK+Y/wrEvx/j6vi2ZVNAlZED+AG9S4p/894Lz4Fju1sqZzIndqsaETl2LFVAf/+12JNBRIJAl4vUwxxLK+vjkwNz+TWwew X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Hildenbrand writes: > On 28.10.23 02:09, Stefan Roesch wrote: >> This adds four new knobs for the KSM advisor to influence its behaviour. >> The knobs are: >> - advisor_mode: >> 0: no advisor (default) >> 1: scan time advisor >> - advisor_min_cpu: 15 (default, cpu usage percent) >> - advisor_max_cpu: 70 (default, cpu usage percent) >> - advisor_min_pages: 500 (default) >> - advisor_max_pages: 30000 (default) >> - advisor_target_scan_time: 200 (default in seconds) > > Is there a way we can avoid exposing advisor_min_pages/advisor_max_pages and > just have this internal e.g., as defines? Yes, we can.