From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4A6DC25B74 for ; Fri, 24 May 2024 06:39:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 565896B0083; Fri, 24 May 2024 02:39:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EE2A6B0088; Fri, 24 May 2024 02:39:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38EA56B0089; Fri, 24 May 2024 02:39:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 16CE06B0083 for ; Fri, 24 May 2024 02:39:40 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9FDCB1C0E26 for ; Fri, 24 May 2024 06:39:39 +0000 (UTC) X-FDA: 82152338478.02.D993586 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf21.hostedemail.com (Postfix) with ESMTP id EC8821C0008 for ; Fri, 24 May 2024 06:39:37 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=F6P0MS9U; spf=pass (imf21.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716532778; a=rsa-sha256; cv=none; b=2mAdfUUfCjc+/w8XePOIl51LDobfRwkxHGTRPQIxVjgOGocABeSZMEXXsrbkFb4oza4FzL qj89E8ad1VV5uAV1YDXqgCbpGa9pASeUfyD0rvpoJETUgiHV7D7KJyAPMKcgyqtJkhqr0S XkHWyEAvGvBefgu9WLuxzQUkqUgMtAQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=F6P0MS9U; spf=pass (imf21.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716532778; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=HsT7bJXg6clFHv5nP1q6o5UDSMwCvumikRcMv42yBfQ=; b=iKiCOmjhAFikPnlbl8dkYQZ2jplT8+FpPpkHx5PkhAI5wQU/RhQ5Z3oJ+5qXPvde1z6Z6V nzQfuKunDdKdY8ALkk9yrcuwcLTyVBDk+dl9Pu9KT/GCIzIffFzAXy2dDqE77RwOHUY/wO eSEt7MBxxN9JymITPH9IV+O/r+O83dA= Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6f8f30712d3so265249b3a.0 for ; Thu, 23 May 2024 23:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716532777; x=1717137577; darn=kvack.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=HsT7bJXg6clFHv5nP1q6o5UDSMwCvumikRcMv42yBfQ=; b=F6P0MS9UUXHfg5mTxROnocF90AjmjEec0ilbBcyQjI4V5dPG6DLV6vh7dgC7luIciO r8RJN2ffuq2cA1jfWuCIfRU/wdrwJUWGn0EEFua75nseJ+EcU8c0COZYlAV/N8TX2pcj QoOF6SE63SqmsHJy15E32SnXBqzX0swf1O0KpMV2cw7hdZhdrhj//AO+Yn3BU3ddZ550 N0YHeovVgeYH2VqeGDJ6NXOeYq1OYV7GWspWsL8bAnzT0tUmmXZeC3tzHXthlfnn0pWo DDDYS+PnYwr+Td+ZsMOWbT8ocO4BumTI3xifnV7dkjB56OT7uhpbbaIkbrtn0JeWphzV 0KXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716532777; x=1717137577; h=references:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HsT7bJXg6clFHv5nP1q6o5UDSMwCvumikRcMv42yBfQ=; b=mtG421ZyALbrovfZhgO7jAWq6p5aSG8rxjGw2uCYfhMaY8u7O2Knm9+qp6HKTJu7+D Jvbg7U8HCjpbaze2gx9bhkDEJvxm48g6u5L1vStOoFSoimQB8EQAeCRxV8Hllnqg1syI quN7R4V7Eq9rboeTKwiZJIdl7ltl3bqoMrWdJBXRwaajo6T1223iMbJddkKJaRRMXww5 Pc0WB8TZYK0NO/uj1RJfLYKy9u7+xBBNk2e217CAgSbZZobXkBMGKXJFN7EXvbdO4SPg 3M+71L5IBzmuHGq0kVlScZwu2SDFdQHILurbbN1L/RRl+MBV90XqhKzEResLTpJfT9WR edXA== X-Forwarded-Encrypted: i=1; AJvYcCVSDPmSgcWL0VG8Ulm7KmwM4xiy9WhOMS/TCIKbojUFQfiCtTIgc/UBbLGyYunE6qugyRpbmZ+B0orNnNROXCTA+1s= X-Gm-Message-State: AOJu0YxJObgaZxCPdWO8n+GooDfYV8mkHWCKz+ilxn9y21fyt+Ofpw3q w5XikTCiPlJqje+VoJn5wH3A4fYycoGPD4A0z/ctDQIZqs2wtGbH X-Google-Smtp-Source: AGHT+IFZ9+4a4BqTPNNlbl09+d4bQ8gxrwCFrBn4r/+9RqjgoawX3EUMlLrRPNdbolpuIaWUJGwPuQ== X-Received: by 2002:a05:6a20:3c93:b0:1ac:de57:b1e3 with SMTP id adf61e73a8af0-1b212b044a7mr2178789637.0.1716532776613; Thu, 23 May 2024 23:39:36 -0700 (PDT) Received: from dw-tp ([129.41.58.7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f8fcbeada4sm556314b3a.102.2024.05.23.23.39.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 23:39:36 -0700 (PDT) From: Ritesh Harjani (IBM) To: Christian Brauner , Xu Yang Cc: Christian Brauner , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, jun.li@nxp.com, djwong@kernel.org, willy@infradead.org, akpm@linux-foundation.org Subject: Re: [PATCH v5 1/2] filemap: add helper mapping_max_folio_size() In-Reply-To: <20240521-beinbruch-kabine-0f83d1eab5e6@brauner> Date: Fri, 24 May 2024 11:51:33 +0530 Message-ID: <87pltbspaq.fsf@gmail.com> References: <20240521114939.2541461-1-xu.yang_2@nxp.com> <20240521-beinbruch-kabine-0f83d1eab5e6@brauner> X-Rspamd-Queue-Id: EC8821C0008 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: 56atcnaedhjincunpaq4ighh3hfggy7g X-HE-Tag: 1716532777-556853 X-HE-Meta: U2FsdGVkX1+TxcMxN9/xOod5omIJX6fkmexyQ1iikZPi1RIi/+Fp2hbbEwZ9fmNz44spkACZCNnlbVtoXGzT88v06GAD8tqjF1zoNGo/2lBbQSzQzsagsy3hpkpI7ytc4b/8qz0rQLBNygPXnbCJ1ZLXebpq5AbVhJGbfa84UoJ8KkNKgPOJzU8CKfNDQJE5+zmdN7qfJePCAnYZNsLG/gRoQ56CWtYSB7/F4LX0hlYM0KFKwiiRqynOVNwZ/hnyhl7iuLeqyAKLgnpUdO7MjJdkq3DEvxHYuxQtSbJWVCNGOd7YAyNJBo09xgoprmkhdMmfZlSd9bQgCKho7yCSdbTaaCiZJw+dogBItV+EXIUY7lnXF5YjVPt1jMhU/sQAA5K7aI9epI75jLkkL1nqBLwScJq3duahhlw4/nYUOJvc7LTdaGtkHRSCCl7+yIMSNaIBJWP++uH/Qu+ykY6hOQAq9TK27Rc6D6rPJ5neeytmRNWi+dXapIedSMHqym4DXII2uT/eo1G89b53nJe3XSTqGTXwEW0+uZGBgvIruUsptB1i9QE7LnAphY5KvB1At1wYcAI9zRNvqQDlNMjZUUZS8QcYm1X+NpaYH1cqbRgJ3MHJ3qZC9+1OrSczXndOhGR7OCy3/POzTA1BfYFGBbh8BxaawB86RusV0cWli/htO26dntJvHHeFVQkDcarJRdlLr/gT6MlYEoqPK4uMZYni08lP3kTmf81zZLHDobg1EH+fht4klsoyKHnKps8xMYFINMYmB9na5r+NSHbRITitt0LntwJMMVYPowkpcQ4CZRagaTdIE2ePsnh9s+Tcrx7LFYdHf0LLbYHAuxJJV2PIqwVUOSunI7XXGCOkFfM22Po4hs9+AUDckErxfEgbsY0dHz6mmaNdsSm1rIXf+eDiUB4kpKrmRNNbYhxMl43PGv3UHtCYoTAh70NjbAyIoHFJ5MLMbyBpkYYdRW1 l/UTqsy2 wIu8RvyagHXD46Ik5n9o4xQbemqzG9r2+NSk7j4yONv9RBMSie+2uTqr9nZRknVfwHUwckqXGmOXHMbknZ0z0MruSJRiLiyNO6urovSR2TfaGS6nKSkm2oZULioh5S1+uw/1O1zLg8BE1BlrMA2LNQVY1kB+WNACpxDpYynlORkV31A2jt4cXyW9SHLCev8uaq/CGQak35bZ/7wxSqQUeNOjvSX1CYje1gqgcs84zrwYKooOlmj8v5FBi/v0De6f4uDW/GdwjETSnDAc3SmQZhytL3Ehd9Sp+gn/AUpj7KdS9U+BRaIwpCebYC7J8luAYDSv6/fl5ACliBnUCM6SGbFHgXcOjl9xaL0eHU/5x2CfBq2ziSe5yu5GrSmdMYzF+oQSnsatcNL+g2mKlJAP3p9SpNQcLPxD5nFP8ttDSsfvvhVcujZthMsECj+9qpiFlxMyjtNenOOdsrIe9r7Xwl6d8WFW0Q8XLGHVoxIFfkZSL59dedioV1lDboxPAMaVgd3dB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Christian Brauner writes: > On Tue, 21 May 2024 19:49:38 +0800, Xu Yang wrote: >> Add mapping_max_folio_size() to get the maximum folio size for this >> pagecache mapping. >> >> > > Applied to the vfs.fixes branch of the vfs/vfs.git tree. > Patches in the vfs.fixes branch should appear in linux-next soon. > > Please report any outstanding bugs that were missed during review in a > new review to the original patch series allowing us to drop it. > > It's encouraged to provide Acked-bys and Reviewed-bys even though the > patch has now been applied. If possible patch trailers will be updated. iomap_write_iter() prefaults in userspace buffer chunk bytes (order MAX_PAGECACHE_ORDER) at a time. However, the iomap_write_begin() function only handles writes for PAGE_SIZE bytes at a time for mappings which does not support large folios. Hence, this causes unnecessary loops of prefaults in iomap_write_iter() -> fault_in_iov_iter_readable(), causing performance hits for block device mappings. This patch fixes iomap_write_iter() to prefault in PAGE_SIZE chunk bytes. I guess this change will then go back to v6.6 when large folios got added to iomap. Looks good to me. Please feel free add - Reviewed-by: Ritesh Harjani (IBM) > > Note that commit hashes shown below are subject to change due to rebase, > trailer updates or similar. If in doubt, please check the listed branch. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git > branch: vfs.fixes > > [1/2] filemap: add helper mapping_max_folio_size() > https://git.kernel.org/vfs/vfs/c/0c31d63eebdd > [2/2] iomap: fault in smaller chunks for non-large folio mappings > https://git.kernel.org/vfs/vfs/c/63ba6f07d115