From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FBB2C27C53 for ; Wed, 19 Jun 2024 07:32:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE27B8D0074; Wed, 19 Jun 2024 03:32:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6AD18D004F; Wed, 19 Jun 2024 03:32:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE4508D0074; Wed, 19 Jun 2024 03:32:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8F0F68D004F for ; Wed, 19 Jun 2024 03:32:50 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 45F54120E61 for ; Wed, 19 Jun 2024 07:32:50 +0000 (UTC) X-FDA: 82246821300.27.59AE742 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by imf12.hostedemail.com (Postfix) with ESMTP id 06EFC40010 for ; Wed, 19 Jun 2024 07:32:47 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jKqRA+LE; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718782361; a=rsa-sha256; cv=none; b=EO6977D7xWSRHc3Jz+hd6bQ3AO4OCOEJsgP/VE4ncqXoMVwJ1MxJYQqwRCSMwlW/mp5pjy U5dnnTtYHYBjvrMjE2H7P9bZDeln7op6V2ULC6YPOn6c6gde8M5wLjj1eD3X1xcv6Oq0Pk QUjDMTpNwmc+K1xqKny5VrQ32k16y+M= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jKqRA+LE; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of ying.huang@intel.com designates 198.175.65.11 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718782361; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CSapD39Q7DX9YdLZdlgmzxTRT145s8AVZGO6BjUUtdc=; b=HGEUNPHZ6q3LMhMdH97t+Ss0L+W0nDXFmNXaPx2figwHF3gkfsRiOnxRo2gdalia8i5ft0 ELG0L7uc2sbC5vEkjf5um6dlmE05rK199dIpOg9DbksxUmFonikkzhq4UIox9aQXMbvWy2 Te+RIjtdEg1Tzs18OLwd7JFbqayZyXs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718782369; x=1750318369; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=X+zUOKHagxOhak6kW7m6miAY618xfGHWy+jbD1zOAGs=; b=jKqRA+LE19q6ImK3SeqwC6+wplqgptCWnX8Ttux43IdabYxlznkNfwh5 0KzNfhFOzm9hf7F4pgPQwb8S+8TK/lvqZt6EDphvLQj2DsC4td4P2A2W7 S5ewQ03TE/DwEWGUZt71emp4IeUC+x/EVcXfna+mrT5cWgkYIYirVwSVZ oVxDMWjZAefdrGnhNi3Xjed8ONN+Cs6iJHN3ebWP0kKPxsN/4a+rQxVcf foG0uqdJWmw9uH98y50REHPDZ66y+4PompE6gymm4dmTkJD8Q30kqS39U U9ccziBtKZoG7WOpyCARmJ+cUSmPoM5Rc7CRo8F/+CxMEfksI+wQ0Hj58 g==; X-CSE-ConnectionGUID: tuzMiHeYS/u4JeB3IEaYnA== X-CSE-MsgGUID: tb7MPjD2TeSlUOafDke3eA== X-IronPort-AV: E=McAfee;i="6700,10204,11107"; a="26296323" X-IronPort-AV: E=Sophos;i="6.08,249,1712646000"; d="scan'208";a="26296323" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2024 00:27:08 -0700 X-CSE-ConnectionGUID: dqKLDcOUSl+5+vnGNTPr/g== X-CSE-MsgGUID: kwOYi2QLSw2aOFmcxqI+LA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,249,1712646000"; d="scan'208";a="79296144" Received: from unknown (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2024 00:27:05 -0700 From: "Huang, Ying" To: Zi Yan Cc: Andrew Morton , Hugh Dickins , linux-mm@kvack.org, Zi Yan , "Matthew Wilcox (Oracle)" , Yang Shi , David Hildenbrand , Yin Fengwei , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/migrate: make migrate_pages_batch() stats consistent. In-Reply-To: <20240618134151.29214-1-zi.yan@sent.com> (Zi Yan's message of "Tue, 18 Jun 2024 09:41:51 -0400") References: <20240618134151.29214-1-zi.yan@sent.com> Date: Wed, 19 Jun 2024 15:25:14 +0800 Message-ID: <87plsd4co5.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 06EFC40010 X-Stat-Signature: is61cw56b5uztrrkedumibu4rfnktd6w X-Rspam-User: X-HE-Tag: 1718782367-427924 X-HE-Meta: U2FsdGVkX18zxTRpTD7zcHeW/NcOUPaRup7lzkqSWTSTWO3ayuVuHJwntXWc4P2cmfeEZU65xqw1lY8bV0hxdAjsm0x43jSwbwmV7yeAtbFXSzL5wFb3RtYZjV4tYhZUl8XBK+dKBX/7zXpGRKyAJ1iWi5oDv7AT8yRmesHCYNj5XyHzR9fEj2n8xaYdXwUZbAHI0z1fo3kuM+e2s1n6FrcMBli6XVsHQ1SggC62FHVlX0nqRx5oJ2bRT8y6csVgwF9MQ0XHFE4Vl+91DyQ89whuli/W7pzDyOjwHE54oXksULX4CdRyPc72H6cybAvnI574EzOop7SVZA0m7i1aenO8kReMpuS0nCGKhyKWUataQSCpp6AfAZsHqRf8apLsAbM13s5wU/urbKhhvsRzPpXWVcJvoXITWJkV53kBebOptQLDPvV/41AUP9uxrvuHtwDMNbB47bV0Cr9eBukaB/etM96yCjVp9LSYBtQwbhmbwATEnXjgnLQEV0aIa5DiqMCbH00eFSIZMh+9JIveUsBfWsCjVkYejLiiSEYIfpPUKT6MtyHjHnBXkTHXvn+zSre9sfiqtXP8dKImtDGF2kf0crJ5m7w3y7IysfP7BlYFwvV75MDjJjjgFnG7XegOb+h3uCJ39y2YIPD4FZoWn9olihlLRgQTzu9Pp8UkUHMa5hAhb1vdaXoqbRiZWLPWGB+X7/aBNSIouDbwibGLK/cmmy0RtG65Ix3tsrNFFlue2UMVOl/ZtVtD3vobwtjsdZqp5fP+0BOpvQvTV4zxHvAU4lJseEsz9QN+kxkrKw8aUuNJCYFVBBhpzl//x0xDLyBPbW9Cz0hEeQsSTCjVCN9NxCw7W1vptUf2rALN7QxL71u9iJ8AMHB12fJxXHZUdqpxBwS2bLxTY+1WjDAB5JmAv+cgdtc69G0QFajSOyioCtLXOd7ZrRAABxo/zifoPFGjvFop+sRqzlEuh7U BYcS1C/f VEPcUxIAwiJCYfjQRISgKSrdsh9pUErlK18Nv3IaibUNTyfFgPc2OzcO57Ht8T7hVY/VjsemOPX4/MZ2LrF993Z/KOQBJbynu/3dT7+3mhzEpRZdfNxp5HwzeQdy7j686b+h39+zU5kL9kl2jc2lOSc3DZqtoCVUXDN5+Chbqb/1gScHEKjxDWqipjNt7R5iVABSc9r52HHr5fY08CZ32p6xtPFxLduK+gDA8RQRbOB0z+avzXNMkUhGtu8pQnjkG26C3jEnqAOffvblReX36lIfVr8rjD/EHkLvEp6Fdto2BMriTRYyHu2hMKWWPS0pW2XJl5t9Uar6Rk8zHx+VW3dki+yLp+9m7TGbFb+8QbatehIRwziZ2Vx/cutIQBLY82kdPhpWPLcZgPUI1tA3jPtz+Aw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Zi Yan writes: > From: Zi Yan > > As Ying pointed out in [1], stats->nr_thp_failed needs to be updated to > avoid stats inconsistency between MIGRATE_SYNC and MIGRATE_ASYNC when > calling migrate_pages_batch(). > > [1] https://lore.kernel.org/linux-mm/87msnq7key.fsf@yhuang6-desk2.ccr.corp.intel.com/ IMHO, we shouldn't ask people to use link to understand the patch description or commit message. If so, we can make the link less outstanding and maybe add more words about the issue. > Suggested-by: "Huang, Ying" > Signed-off-by: Zi Yan Otherwise, LGTM, Thanks! [snip] -- Best Regards, Huang, Ying