From: "Huang, Ying" <ying.huang@intel.com>
To: Zi Yan <zi.yan@sent.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, Zi Yan <ziy@nvidia.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Yang Shi <shy828301@gmail.com>,
David Hildenbrand <david@redhat.com>,
Yin Fengwei <fengwei.yin@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/migrate: make migrate_pages_batch() stats consistent.
Date: Wed, 19 Jun 2024 15:25:14 +0800 [thread overview]
Message-ID: <87plsd4co5.fsf@yhuang6-desk2.ccr.corp.intel.com> (raw)
In-Reply-To: <20240618134151.29214-1-zi.yan@sent.com> (Zi Yan's message of "Tue, 18 Jun 2024 09:41:51 -0400")
Zi Yan <zi.yan@sent.com> writes:
> From: Zi Yan <ziy@nvidia.com>
>
> As Ying pointed out in [1], stats->nr_thp_failed needs to be updated to
> avoid stats inconsistency between MIGRATE_SYNC and MIGRATE_ASYNC when
> calling migrate_pages_batch().
>
> [1] https://lore.kernel.org/linux-mm/87msnq7key.fsf@yhuang6-desk2.ccr.corp.intel.com/
IMHO, we shouldn't ask people to use link to understand the patch
description or commit message. If so, we can make the link less
outstanding and maybe add more words about the issue.
> Suggested-by: "Huang, Ying" <ying.huang@intel.com>
> Signed-off-by: Zi Yan <ziy@nvidia.com>
Otherwise, LGTM, Thanks!
[snip]
--
Best Regards,
Huang, Ying
next prev parent reply other threads:[~2024-06-19 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 13:41 Zi Yan
2024-06-18 19:44 ` Andrew Morton
2024-06-18 19:48 ` Zi Yan
2024-06-19 7:25 ` Huang, Ying [this message]
2024-06-19 18:13 ` Zi Yan
2024-06-20 1:23 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plsd4co5.fsf@yhuang6-desk2.ccr.corp.intel.com \
--to=ying.huang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=willy@infradead.org \
--cc=zi.yan@sent.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox