From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7185BC3DA42 for ; Sat, 13 Jul 2024 10:42:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 791266B007B; Sat, 13 Jul 2024 06:42:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 742016B0083; Sat, 13 Jul 2024 06:42:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 609036B0085; Sat, 13 Jul 2024 06:42:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 38EFC6B007B for ; Sat, 13 Jul 2024 06:42:20 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B6754A44CE for ; Sat, 13 Jul 2024 10:42:19 +0000 (UTC) X-FDA: 82334389998.06.C7453D0 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf25.hostedemail.com (Postfix) with ESMTP id 020C2A001F for ; Sat, 13 Jul 2024 10:42:17 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=FGAZR++f; dkim=pass header.d=linutronix.de header.s=2020e header.b=D96QLQRM; spf=pass (imf25.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720867321; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nf78z+ot0DcB12FLGp27PqqquDVnJlnIDmODNL4yRjQ=; b=kY9FGfEh2y/69uJxu683Ly5J7f4zShBTL5RAIUfN7NPu6Ln3/DkI6eoMO6YjwU3vSmADTi S5dxZbvOsTjMdSnXS/uUPruQ4FZSnRRFdgAncNUI+lGqm7iq7RYEFG42af8evWDce3Yk3x ehifZNycMKeYLqSW3f0adarefi6WxpM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=FGAZR++f; dkim=pass header.d=linutronix.de header.s=2020e header.b=D96QLQRM; spf=pass (imf25.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720867321; a=rsa-sha256; cv=none; b=E27CmqpMEaks6Ul4ghVbeDMbF4kxClTYz1rgRthhM9BI4MnSnO2GUl6xIMo624myZWsQdr AhjO5cOPNiPUZKMyGQNBY8njb0Qgp3ymKFGyqxycL+0rU6gzePRpTbnEzU2J0z3KZpcTew Xn6dZVk38dbtra+BVd8rmsBxBCHkpOg= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1720867335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nf78z+ot0DcB12FLGp27PqqquDVnJlnIDmODNL4yRjQ=; b=FGAZR++fLXkA41w42NmRuvHcAvq5zX3sjoB7pvVXp3YcXdOD13trrThDA0NA0dZUaoqhhF 2oirRpWxDwwYP8iZzcMyoEsPu2T7BXe6lKaI3EqrZElS/+UlvmJV6l1F2+xFu8HrKy0D4m awmft0VxgEahAedrmUlfUGkiaH//WMMO5rjE46G8njvMheGpY5ASaPR3RaVWLIQN5T61R4 vEnA5SY5PgAhPk77lVDqASPzP8gwS3QAdXX+B9DsJwM1J1Mkg3mAPa+Z4TMnh5OYsrffst 506bJAT2icEKq5urMl+HuQqnwrVqot52KyxULJpqWJoJ9H3CyqNdj37dn/kKtg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1720867335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nf78z+ot0DcB12FLGp27PqqquDVnJlnIDmODNL4yRjQ=; b=D96QLQRMmwhgfBHjBjxFizYhXkYoDi0RIMdgG2S9uhHQQowec0c4Yt4SfdC6iMvVcwyn1Q uLviHfVJmbGjC9CQ== To: Vignesh Balasubramanian , linux-kernel@vger.kernel.org, linux-toolchains@vger.kernel.org Cc: mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com, ebiederm@xmission.com, keescook@chromium.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, bpetkov@amd.com, jinisusan.george@amd.com, matz@suse.de, binutils@sourceware.org, jhb@FreeBSD.org, felix.willgerodt@intel.com, Vignesh Balasubramanian , Borislav Petkov Subject: Re: [PATCH v3 1/1] x86/elf: Add a new .note section containing xfeatures buffer layout info to x86 core files In-Reply-To: <20240712094630.29757-2-vigbalas@amd.com> References: <20240712094630.29757-1-vigbalas@amd.com> <20240712094630.29757-2-vigbalas@amd.com> Date: Sat, 13 Jul 2024 12:42:14 +0200 Message-ID: <87plrhshdl.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 020C2A001F X-Stat-Signature: ysyfqxqwbns4hyd64xa7ay9um4zeoehr X-HE-Tag: 1720867337-154396 X-HE-Meta: U2FsdGVkX18PgerE7jyNKo2lrzzwiop7XSpH1MN4TZCl5ZGdtxuV4JQoQnsJnpdLqTN6AGpuTZzD39LoYbsRtNSITfPJKPcJMqRHKx6X2RXlPHNp8C/qp2J+aLpt2S7gGuJvHj7HREXTVnLq7dHmXUUNgLD7N8daJTg/I8ikeEVrg07NjrcOg1Qa9Q5Y/VOD9Y92iWxo3XRpS5NMSSOqwmCto3NOhabPkJRn8Y8AjXLUohZn7QavueDsFUj68Mizj0ZcuBMykV9cAd9YLVCzw6BAudlUTwqrcC9WNid/VSVFgJ8f/jni52LPOw8hDnNMfJ7lau4vOgm7Vq0dqGAwuQ5xNeHypDWeN7sJS30e5k3NSOKnr2w4TcNNjL8jRgz0PR4Gf4kkVw7BGIRitjE5zO+9IQ6dBF//6Ck6X1Nd4hwBiuN4kWHkUaoEJKBvSjzmJUH3diJm+noyphi1iLvZOerDjPWmbUkHIY2OKSfiSX54KcBCcU6bXY/NrZTxa3SxMhuNFfWrVEuX2mTg1QpTolkJBndKrFff0GP57+prTzV36zJW7E8P4FBmpiu3xj9McoFCbx7KTWbroUecvP8ip3q8ySQqRLMCVQCZugrV5Kh1ml6Uh06gwjzz7YRHvmc5TbI9QsbcIjyCtMV/+SwPx6I+VvMuSvA+WMwTc9prHS7n++8Y/oO/1r+KVqSveo7uHdaIIFJps4ia/ToOKqsoW0XIdp/7xT/u6jSGYP+0xC1WhLyrG6NVRy/TTYh5ZNwhaulkroOQPAbj5Jo8lwxRWKx8ybmuIlDDdqh/+1MfC0aZbSsGuBQ3GmQeNkxpz84sDu2WT1oPtcd4XjitHfv0A74+FDx/m2q1oXxAHOuYZECuEU9voacqzakL22bBW5NY9KBPbf2/Hg9ZpfwNGavVW3d/MsxhaoB0SfWOJurNNgyqYhbvxA797KYP9cBE51XFPtkdjRb5axweMOk/Jb8 PevuLKTA N5S6dcBjw8STwmZNfdzicxLEUOuBdq/rhztmtbm7MgQIKqIyLqk4ixbTU1z2svQjVgAxhQqebrv2C2GCSRsHgdnxzr2jptJsR14zR5RJMIgWrKvlIPYVORp0V0veABmtdODdTXIVNb1OjlM3vhnWQ/gocQy9AKu99peNT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 12 2024 at 15:16, Vignesh Balasubramanian wrote: > diff --git a/arch/x86/include/asm/elf.h b/arch/x86/include/asm/elf.h > index 1fb83d477..cad37090b 100644 > --- a/arch/x86/include/asm/elf.h > +++ b/arch/x86/include/asm/elf.h > @@ -13,6 +13,15 @@ > #include > #include > > +struct xfeat_component { > + u32 type; > + u32 size; > + u32 offset; > + u32 flags; > +} __packed; > + > +_Static_assert(sizeof(struct xfeat_component)%4 == 0, "xfeat_component is not aligned"); This struct is only used in xstate.c and asm/elf.h is not a UAPI header. So what's the point of declaring it in the header instead of xtsate.c? If this needs to provided for user space consumption, then it want's to be in a UAPI header, no? Thanks, tglx