From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A54EC3601E for ; Mon, 7 Apr 2025 16:05:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBD386B0006; Mon, 7 Apr 2025 12:05:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6C2C6B0008; Mon, 7 Apr 2025 12:05:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBF6E6B000A; Mon, 7 Apr 2025 12:05:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A940F6B0006 for ; Mon, 7 Apr 2025 12:05:31 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DE40C1C852B for ; Mon, 7 Apr 2025 16:05:31 +0000 (UTC) X-FDA: 83307722862.13.A53F835 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 8FE3F40002 for ; Mon, 7 Apr 2025 16:05:29 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qaplj1o4; spf=pass (imf12.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744041929; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zNoERvvtXRSCrx3KIjxMddb09wFmHm8Y12hrkHAY1dA=; b=2lKPgnoXvdaUdbk9NTIIT1q0e8PkRQC0HAEpz4YcFEESvXdXZIJxn7M+JDbCd4l6PMFd77 OjT2KfNuHWFh2/KSvqii5wZKyYIJ9jMSbYUSviIMr56W9QRpFYjQOHSLw1+xAlKoAn5yJh KOXLD8/R0rHRvjjqHK+sp7yXXoUCKPQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Qaplj1o4; spf=pass (imf12.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744041929; a=rsa-sha256; cv=none; b=NeZU3PBEuE9XDYKxuyuQTdU9/50JLF4CxtYbs8iDIgNCAKb67KTGdrKarmhSVbzGMsWmez pVYAHtseHjcgg+975xm+CMDmERBDfsub+DgyoCGL5wrDhiMUeG6PvdcURsaWgl3UKgj8a7 qnO54ZPk8WfBsneoEWHhgh94OnMxY0c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744041928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zNoERvvtXRSCrx3KIjxMddb09wFmHm8Y12hrkHAY1dA=; b=Qaplj1o4aJaVUS66DX2VMmM7QU31k6sRhUMchNqxBUKUOr1hpY8ETQTiXF+Anj0GWSHTnu qXd+/CxuluarHOUOMBkwHPCbc2X5rDOq19bNxbuEfEdLFKRz4ms3U2E6Ci4Sn5axWD65FD F69gb0q4IzVmHwdlqdHMyKgJ8zuw3Xs= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-46rrSKh-MhWQ165kGgg3KQ-1; Mon, 07 Apr 2025 12:05:27 -0400 X-MC-Unique: 46rrSKh-MhWQ165kGgg3KQ-1 X-Mimecast-MFC-AGG-ID: 46rrSKh-MhWQ165kGgg3KQ_1744041926 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-ac737973d06so424813466b.2 for ; Mon, 07 Apr 2025 09:05:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744041925; x=1744646725; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CsKVmSSOEhSPW5M16uS9aq81qKIIkPndLncn38XuUug=; b=YpunNlzJP4UwXwXCSTpRu836BGOgwKxcaFO2pSZn2jYuRqbUL/vueaRC2CIjAEamCQ EWBh2aTM5to+U7WGzQS1Ca+vtmJOiwgbSg3cNLXLvsw1p7cTv1Wb9LXXaRpxVfopM6Ka bz9olD2BIy5mjg0yfK234xBfQNmuUISwRGGaM9t0xPIPAP1uoTssJoj5bNszSQ4mQQbY SXf1z/fkhUFiqYHETOdIDggrFhN/p43DUS5Np2ImGQ6IV8Is9qf/Yi9LTOmT4pPiXsTz tNiSTDoOP4KAz0+nG2rG0jy8+LAcGoigNaLxqWBmYcc8v7CWy/fj+dIKjg2Y2gUglaJT xtTQ== X-Forwarded-Encrypted: i=1; AJvYcCX3jH+ScBg7B46H05o3LBP/rvVYJM0SEcv3JDm9xbOg0blPewoIQ7RnXDc36/Gkosa+4hoQjKVb0w==@kvack.org X-Gm-Message-State: AOJu0YyJ/MJa6lYS8GarbKcF5S35O1opLfVArRWSSCoc/brTPimftodt rEacWtcq08ZPOBB0LUE4zM9xOvRdGOmfVIoHEi7i16ESUVX71JyREGsENJ0Pd3jSafkh3NqzI+Y /ikUckDi6oACP5GuOgqQ5gHes1bhsp1LiLfHAK+jZK/g0H6YL X-Gm-Gg: ASbGnctJutZi1CtDMlF/I3LkGhGcqNvCAwRbt9F09DseqjzlAdFbS6x48xhTLCNlPQZ p/CNKZIkBqSgLNrSeBkmidTaYizpibEQUi5Bi0YM1Fx42LJo5dRl+Lh2iBSqDRiMcCumpkz2wX9 CFr9kyBuMvpcGNQK7Cs4sQUu7zaSktJLYgXKaXrBW/OJM2MAEOmGhxOcVL9GYJGJJWSr3+jp14E jVaSLO4D2NSQJHTnbawcxnjaHg/dPdNfEsvbdWxaYOoUXPHI74b731i+pQSopc4pA9lDocsoytC R9+DCI5QzVHT+vswZh/IF6nFKQdsCh764tSS/q4h X-Received: by 2002:a17:907:7291:b0:ac2:a4ec:46c2 with SMTP id a640c23a62f3a-ac7d1b9c1demr1174829266b.49.1744041925336; Mon, 07 Apr 2025 09:05:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHfWaVdDYJ0191r28pa3c0I5QAq2TX4YfoyI6/S6plMu4jTexyNQOGbQSCGtYlVpcULGOS5sw== X-Received: by 2002:a17:907:7291:b0:ac2:a4ec:46c2 with SMTP id a640c23a62f3a-ac7d1b9c1demr1174821366b.49.1744041924666; Mon, 07 Apr 2025 09:05:24 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac7bfe5d407sm755045066b.25.2025.04.07.09.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 09:05:24 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 1E85D19918CB; Mon, 07 Apr 2025 18:05:23 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Zi Yan , Jesper Dangaard Brouer Cc: "David S. Miller" , Jakub Kicinski , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, kernel-team Subject: Re: [PATCH net-next v7 1/2] page_pool: Move pp_magic check into helper functions In-Reply-To: <4185FF99-160F-46A9-A5A4-4CA48CC086D1@nvidia.com> References: <20250404-page-pool-track-dma-v7-0-ad34f069bc18@redhat.com> <20250404-page-pool-track-dma-v7-1-ad34f069bc18@redhat.com> <87cydoxsgs.fsf@toke.dk> <87v7rgw1us.fsf@toke.dk> <893B4BFD-1FDA-46DE-82D5-9E5CBDD90068@nvidia.com> <4d35bda2-d032-49db-bb6e-b1d70f10d436@kernel.org> <4185FF99-160F-46A9-A5A4-4CA48CC086D1@nvidia.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 07 Apr 2025 18:05:23 +0200 Message-ID: <87plhovtx8.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hyEM5cq5tMLFcG9DvnaazKxcG6i6uoceJPP4sR4Y_t8_1744041926 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8FE3F40002 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: gu7xpb3pdrqmyriwhz4iifdgda4khhop X-HE-Tag: 1744041929-787579 X-HE-Meta: U2FsdGVkX1+gNNRXHY3Y97V2aMWLL3JIWulCS6Y7zTJWOzs5QzYY8YpTm9uaxskEccUAxcmNd+gSHcyVL43ORkz2XkV6axuC1QkZhNyVGNLLiIHd5HwCQ3hS3nuPUkvwbC+5zMcDT7x+fGvWYa2CrmSwv04jx/NnMjxHZxWLTBGra0zFdJRL50DtFZ6fdoSEqaJgnuxM1I++PF6/b8NRidhJs2bhOwth45r8fvtkrpE51Ca1FIVcGXjhwiy3ys+yyu4U1nLB2fhczTtJp817t3cT1MX0pM3OAtBF/X7BzeAt9sZXYsYHKZR9zJsnlcKbEVWY0a+d0wtXomQ8XDZJuggq1dcFrBHH/kM4owETa811ldR/EAponuD2v5FT49uR8PEmyB/9XsYUPBREm2BnWDgDKJYLp2ZVu0cRPzpH/jrVQaLkihe36/Lq731ahfzhgnBpVOmXTGu3jF2ApxIeRqWzQma4u1CygaX3MOv79xglEKwTCNTgSvIt6+HTUOA+MdRUxzklOUUNrNyBJ1R2HvuvS7Ujz8yZT5TnaK/oRwajj0pjjhL0kxpwQxXhwNlMxLXxhj+nHt5UUFzHHvkPSoppy2XdIukwlUfz0Z+PL1paeqXxX9ciG0roWQ8wpkoshBywQjJdo/zu6qr3D1oki4jY14Mm7oVtqQWmqduQ4LRa+YW1UeL3Uk2HZ/3X31iHzjkXCBodcgiKDequ8qoI3wD4W+uQQQIna/gScj/sjzZ1Qp3zp0HxDxn+ms1F0UpseNUN3x+sH/i2vJl2+o0rjubRd6WbRvIasnil2hq9LM5LtmHaWSeXS2lJIT9e7IHjj9v25h3BydpaKcNb+HRiol+bCkGUPfbMUrQ827VWkabClTg8oY0fCtDDEAyRjzxsXPWUXcZvWuNbksbCa9sqNw8Ak57By9X8iCjvBFdMzt5KGZU/uy1fpELLPV4iMkm6/bzOeCnAiP22XzWfLsK FRL0uAgj prSXfnUKy60CRsooPB9T/a13RTuNQ1KEaFpB6x+GxJ5KFDeJnKunRp0SRcLm03Nnide38u5zJR0BhBWfvtIoZ04vr2W4vzg2OjUv5ICMvDenwLM8Ykv305w/UZhg1LOsSwtwnnZHufFLrD5m5JdQi9PqeiOWwoQSYQosMXeThIkFQR8W/mZV81qh8PReGc8ROP0whFsgrMte58e4aK4c2jh1u+S6mNdrBNvdZDsVcnzojDFfFv3Ws42UjEE8H33MT8ybBXe7fSxTlXPoyDFjmzigYyL7VCN/hAgTji11ggP0R+NdNLTPRHJtFfGgDNktJH3HKCQLNFcDThLBSB8jdetVaJoCBOrgwRBO6tgI8ogwhAmZ0kEluNbnPisewqTim0qDlZdE/M7jRwfp2E6SoeWTyZPejRZYXE2rGjNTwSatVXhXcC2TvsXbPU/36BvA4kwCo0WZ2OrctRxz/oi6Okv3g6p+QQTqaDw/pyl5TgMBDHUBceSg+yA9MAkNjFIbGGhJBTa1x/f4IGRjP09bPwpQ/iD/mc7Z8gU7If36ehc8i1KsMAS1MclqrlNzF1q+KtGJRaDCUQJ6M7r4X2f7CLFL40PeCLRv2m6h9IyCYJgR9VbcbaK8eowATzFEK3Eh47EHvhWPXeZl0FV2gUaUEWTOHfXp417KyFkp4XZccymTvtEZ1OmlxNKZxdKTUqF0s3yA63Uts66uHTsI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Zi Yan writes: > On 7 Apr 2025, at 10:43, Jesper Dangaard Brouer wrote: > >> On 07/04/2025 16.15, Zi Yan wrote: >>> On 7 Apr 2025, at 9:36, Zi Yan wrote: >>> >>>> On 7 Apr 2025, at 9:14, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>> >>>>> Zi Yan writes: >>>>> >>>>>> Resend to fix my signature. >>>>>> >>>>>> On 7 Apr 2025, at 4:53, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>>>> >>>>>>> "Zi Yan" writes: >>>>>>> >>>>>>>> On Fri Apr 4, 2025 at 6:18 AM EDT, Toke H=C3=B8iland-J=C3=B8rgense= n wrote: >>>>>>>>> Since we are about to stash some more information into the pp_mag= ic >>>>>>>>> field, let's move the magic signature checks into a pair of helpe= r >>>>>>>>> functions so it can be changed in one place. >>>>>>>>> >>>>>>>>> Reviewed-by: Mina Almasry >>>>>>>>> Tested-by: Yonglong Liu >>>>>>>>> Acked-by: Jesper Dangaard Brouer >>>>>>>>> Reviewed-by: Ilias Apalodimas >>>>>>>>> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >>>>>>>>> --- >>>>>>>>> drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 ++-- >>>>>>>>> include/net/page_pool/types.h | 18 +++++++++= +++++++++ >>>>>>>>> mm/page_alloc.c | 9 +++------ >>>>>>>>> net/core/netmem_priv.h | 5 +++++ >>>>>>>>> net/core/skbuff.c | 16 ++-------= ------- >>>>>>>>> net/core/xdp.c | 4 ++-- >>>>>>>>> 6 files changed, 32 insertions(+), 24 deletions(-) >>>>>>>>> >>>>>>>> >> [...] >> >>>>>>>>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >>>>>>>>> index f51aa6051a99867d2d7d8c70aa7c30e523629951..347a3cc2c188f4a9c= ed85e0d198947be7c503526 100644 >>>>>>>>> --- a/mm/page_alloc.c >>>>>>>>> +++ b/mm/page_alloc.c >>>>>>>>> @@ -55,6 +55,7 @@ >>>>>>>>> #include >>>>>>>>> #include >>>>>>>>> #include >>>>>>>>> +#include >>>>>>>>> #include >>>>>>>>> #include "internal.h" >>>>>>>>> #include "shuffle.h" >>>>>>>>> @@ -897,9 +898,7 @@ static inline bool page_expected_state(struct= page *page, >>>>>>>>> #ifdef CONFIG_MEMCG >>>>>>>>> =09=09=09page->memcg_data | >>>>>>>>> #endif >>>>>>>>> -#ifdef CONFIG_PAGE_POOL >>>>>>>>> -=09=09=09((page->pp_magic & ~0x3UL) =3D=3D PP_SIGNATURE) | >>>>>>>>> -#endif >>>>>>>>> +=09=09=09page_pool_page_is_pp(page) | >>>>>>>>> =09=09=09(page->flags & check_flags))) >>>>>>>>> =09=09return false; >>>>>>>>> >>>>>>>>> @@ -926,10 +925,8 @@ static const char *page_bad_reason(struct pa= ge *page, unsigned long flags) >>>>>>>>> =09if (unlikely(page->memcg_data)) >>>>>>>>> =09=09bad_reason =3D "page still charged to cgroup"; >>>>>>>>> #endif >>>>>>>>> -#ifdef CONFIG_PAGE_POOL >>>>>>>>> -=09if (unlikely((page->pp_magic & ~0x3UL) =3D=3D PP_SIGNATURE)) >>>>>>>>> +=09if (unlikely(page_pool_page_is_pp(page))) >>>>>>>>> =09=09bad_reason =3D "page_pool leak"; >>>>>>>>> -#endif >>>>>>>>> =09return bad_reason; >>>>>>>>> } >>>>>>>>> >>>>>>>> I wonder if it is OK to make page allocation depend on page_pool f= rom >>>>>>>> net/page_pool. >>>>>>> Why? It's not really a dependency, just a header include with a sta= tic >>>>>>> inline function... >>>>>> The function is checking, not even modifying, an core mm data struct= ure, >>>>>> struct page, which is also used by almost all subsystems. I do not g= et >>>>>> why the function is in net subsystem. >>>>> Well, because it's using details of the PP definitions, so keeping it >>>>> there nicely encapsulates things. I mean, that's the whole point of >>>>> defining a wrapper function - encapsulating the logic =F0=9F=99=82 >>>>> >>>>>>>> Would linux/mm.h be a better place for page_pool_page_is_pp()? >>>>>>> That would require moving all the definitions introduced in patch 2= , >>>>>>> which I don't think is appropriate. > > The patch at the bottom moves page_pool_page_is_pp() to mm.h and compiles= . > The macros and the function use mm=E2=80=99s page->pp_magic, so I am not = sure > why it is appropriate, especially the user of the macros, net/core/page_p= ool.c, > has already included mm.h. Well, I kinda considered those details page_pool-internal. But okay, I can move them if you prefer to have them in mm.h. -Toke