From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE7D4C2D0CD for ; Wed, 21 May 2025 19:07:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1BEC46B0088; Wed, 21 May 2025 15:07:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16F786B008A; Wed, 21 May 2025 15:07:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AD636B0093; Wed, 21 May 2025 15:07:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DC3CC6B0088 for ; Wed, 21 May 2025 15:07:01 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 774AA1CBA23 for ; Wed, 21 May 2025 19:07:01 +0000 (UTC) X-FDA: 83467847442.08.B8B6137 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf16.hostedemail.com (Postfix) with ESMTP id D0E58180008 for ; Wed, 21 May 2025 19:06:59 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=pNO3N5lW; dkim=pass header.d=linutronix.de header.s=2020e header.b=w5i9e5dB; spf=pass (imf16.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747854420; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wu3LOEUSMm8SUQd5p5Qsk9bRgy0QGcEvKsCCH/IqaTA=; b=aWNS+BY9hOo2TQl7buLV4Y3GDpxzK8trz9PwyYXp5x6vlmfamddirerPtEoy5+l8WXQOjV gxq8Kmib5xrczwwswUNo+03yp7irysRB4CCNs39LjeZyP5Z/QLqC3LwTYYed3/zMLi1vxI DDoJL4949mRaq/pkSXvzadCJ1xbg+Gw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=pNO3N5lW; dkim=pass header.d=linutronix.de header.s=2020e header.b=w5i9e5dB; spf=pass (imf16.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747854420; a=rsa-sha256; cv=none; b=ffOxrVgP/vBXmzY0WAfaYduTZBkQIaBNhaiwBw/Gzl6kOJnoAfusDMZjqJ990aVBPphjCu aWa1fXNQ6RVXJXB5OPjXYsIc3AFNN1sDQQwW+Fjq3+iM+CHbTD/tGlgUuhA1iYWL/vBFl9 WmWTbheDlychLhpFZMG3giRCfs3Ke7s= From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1747854417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wu3LOEUSMm8SUQd5p5Qsk9bRgy0QGcEvKsCCH/IqaTA=; b=pNO3N5lWlIpqyldg/OiyeKbAWTLkJJGWD8+guFnqyTm6u78TlsjWbbXsJPXpILVulkUVTC +Ecf8Rwbhesje+0OaGhHljlD2Ea0EODTfuGbVt/HfPWuuNvrqQb5j7Mq1vmtU24VG/hRDr 8bBXTll5BTy0hQk9F0FULd3csejwbsYU/EKkhCK0N3hZ6r1IUSegoXTQrxro+YUreenGbD stLdPEhbeu/Qr5A5ppOoUHTzknajq3sPtLHLnLNatzyjXWwCIRHSvaVznGDcHMfLmuEWAe WDfD+PvzgzYR3VD3myI2rigE/HFauBoIfW0jLjjYpXudjOPb+1MwWaMzuHHiug== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1747854417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wu3LOEUSMm8SUQd5p5Qsk9bRgy0QGcEvKsCCH/IqaTA=; b=w5i9e5dBlmxPOtW5aRYgr2WrZg7AbPP8TCLo/5dgCqAvNhbzUtO9uqZpJRMRFDSW5rE/Xm DIhx41lr/e/3HrBw== To: Dave Hansen , Rik van Riel , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, x86@kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, nadav.amit@gmail.com, Yu-cheng Yu Subject: Re: [RFC v2 7/9] x86/mm: Introduce Remote Action Request In-Reply-To: <2385d4ed-48d5-4d50-ae95-dbeb23432b71@intel.com> References: <20250520010350.1740223-1-riel@surriel.com> <20250520010350.1740223-8-riel@surriel.com> <2385d4ed-48d5-4d50-ae95-dbeb23432b71@intel.com> Date: Wed, 21 May 2025 21:06:56 +0200 Message-ID: <87plg1rdf3.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: D0E58180008 X-Stat-Signature: cm3euonm733355t1kcjmzqp65wrwtcui X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1747854419-669326 X-HE-Meta: U2FsdGVkX18u1TmN/agKc4fBruGPRH4H8R8pyNzxOkWpUsPwPKRaVhNzz66XbSMeKzbn9LuSm7ij/8S+xfIctXUhnjsX+GQJVO8mkLniZ7A3IQ86YPkphLzro8WhaEV27wnWe72I5E1Mh/VIXsL9m5bdtqsukcwpwSM/4g/ZFfDdzSPdPAUxPxydi5OsnTNamGNCKV51g+YdYgnK2qfFm5n7h6UcYe+R+7Pjt6bc/E2IrRHz3ixy8HaSPhRx1aKMa9uv+v9oOEaE7cC82t9EvFP0rCGj1qduTC4CUQe4Xzrja3BuLM/EMgZkwHrL0sPk/WDWo0i7FXwwbZv2stM62xFNQ6w/FGIahTxmPfvdZOqmDGGEZ7JakYVy/AwMsP/YtaX+CXZ5M+A855rZ1qO+J2rpAvctgLs8jXMFbUrJZ28zlgVt4eg0iBOffuiyAZtPu/YspdqZ74jlxoB3J4yxHv/X+gtG54RNo/w98SFkp9RHYhav48jmTulSy247DI0sfudxJDD9e78tHHulOZWYl3PsArZrfvna52SqGf27xU48VsTy9hmbySrdfndJCbVH7RGehR7iXChJH6lg6fIYbNpBZSFsBhw5cJNNEHIfD6OuLtQSitDngS5yWQRlwS10cqy3NckSR0ah7M4MyyM/wkCgxeLCYj1EalNTkETaP/xil1yqSkVvy0imtlarzJV3Y4E+JAkdNcBQVY5db1zAIob6uti4Jio1Xqamycmqv9DyKE9LGjAO4iUUzh401XLEB10K4XMXv5PPxz0YvvVqw7hxsfez+h8DtMBKLrf5qlJIlJwC04sRjhWw4t0p4bWVqupPZTigT1vMeGu0FdfQcOM+M1V1p/VETfcPydJu/WZq6B+8Y0d/8v53c9jA61LFOYpqDMj4eV6Guj3g/YGdujLVEhwYP3A4Gig94MFt7VIF+Dj87ahhdcLU5P+Vxg8l1v+bzdBz1QMdltf1JhA ZXjLm/Ra ZR0i9gm7rlBlVwSRAgbqFtJrGe6EmMk52rGmD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 21 2025 at 09:38, Dave Hansen wrote: > On 5/19/25 18:02, Rik van Riel wrote: >> +/* >> + * This is a modified version of smp_call_function_many() of kernel/smp.c, >> + * without a function pointer, because the RAR handler is the ucode. >> + */ > > It doesn't look _that_ much like smp_call_function_many(). I don't see > much that can be consolidated. It does not look like it because it has a gazillion of function arguments, which can all be packed into a data structure, i.e. the function argument of smp_call_function_many(). There is zero justification to reinvent the wheel and create another source of hard to debug problems. IMNSHO it's absolutely not rocket science to reuse smp_call_function_many() for this, but I might be missing something as always and I'm happy to be enlightenend. Just for the record: The changelog contains an utter void of information why this modified version of well established common code is required and desired. Thanks, tglx