From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH] drop_buffers() shouldn't de-ref page->mapping if its NULL References: <1114645113.26913.662.camel@dyn318077bld.beaverton.ibm.com> <1114646015.26913.668.camel@dyn318077bld.beaverton.ibm.com> <87k6mn5zs6.fsf@devron.myhome.or.jp> <1114701153.26913.679.camel@dyn318077bld.beaverton.ibm.com> From: OGAWA Hirofumi Date: Fri, 29 Apr 2005 01:26:27 +0900 In-Reply-To: <1114701153.26913.679.camel@dyn318077bld.beaverton.ibm.com> (Badari Pulavarty's message of "28 Apr 2005 08:12:34 -0700") Message-ID: <87oebyeuks.fsf@devron.myhome.or.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-linux-mm@kvack.org Return-Path: To: Badari Pulavarty Cc: linux-mm@kvack.org, Linux Kernel Mailing List , linux-fsdevel , Andrew Morton , skodati@in.ibm.com List-ID: Badari Pulavarty writes: > Andrew confirmed that this is a valid case. > > I don't understand what you want to do here ? If the mapping is NULL, > we can't de-ref it. Whats the point in putting a warning and de-refing > it. Its going to cause NULL pointer de-ref anyway. I meant your patch + warning. If it is just bh leak, not valid state, I thought we can notice the leak of bh by warning. I wanted above things. If it's valid state, of course warning is just crap. Sorry for noise. -- OGAWA Hirofumi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org