From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: linux-mm@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
skodati@in.ibm.com
Subject: Re: [PATCH] drop_buffers() shouldn't de-ref page->mapping if its NULL
Date: Fri, 29 Apr 2005 01:26:27 +0900 [thread overview]
Message-ID: <87oebyeuks.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <1114701153.26913.679.camel@dyn318077bld.beaverton.ibm.com> (Badari Pulavarty's message of "28 Apr 2005 08:12:34 -0700")
Badari Pulavarty <pbadari@us.ibm.com> writes:
> Andrew confirmed that this is a valid case.
>
> I don't understand what you want to do here ? If the mapping is NULL,
> we can't de-ref it. Whats the point in putting a warning and de-refing
> it. Its going to cause NULL pointer de-ref anyway.
I meant your patch + warning. If it is just bh leak, not valid state,
I thought we can notice the leak of bh by warning.
I wanted above things. If it's valid state, of course warning is just
crap.
Sorry for noise.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-04-28 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-27 23:38 Can this happen ? Badari Pulavarty
2005-04-27 23:53 ` [PATCH] drop_buffers() shouldn't de-ref page->mapping if its NULL Badari Pulavarty
2005-04-28 3:46 ` OGAWA Hirofumi
2005-04-28 15:12 ` Badari Pulavarty
2005-04-28 16:26 ` OGAWA Hirofumi [this message]
2005-04-28 0:05 ` Can this happen ? Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oebyeuks.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pbadari@us.ibm.com \
--cc=skodati@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox