linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, dchinner@redhat.com,
	fuse-devel@lists.sourceforge.net
Subject: Re: [PATCH 6/9] fuse: Push file_update_time() into fuse_page_mkwrite()
Date: Thu, 01 Mar 2012 20:31:17 +0100	[thread overview]
Message-ID: <87obsgce4a.fsf@tucsk.pomaz.szeredi.hu> (raw)
In-Reply-To: <1330602103-8851-7-git-send-email-jack@suse.cz> (Jan Kara's message of "Thu, 1 Mar 2012 12:41:40 +0100")

Jan Kara <jack@suse.cz> writes:

> CC: Miklos Szeredi <miklos@szeredi.hu>
> CC: fuse-devel@lists.sourceforge.net
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
>  fs/fuse/file.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 4a199fd..eade72e 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -1323,6 +1323,7 @@ static int fuse_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
>  	 */
>  	struct inode *inode = vma->vm_file->f_mapping->host;
>  
> +	file_update_time(vma->vm_file);

Fuse sets S_CMTIME in inode flags, so this is a no-op.  IOW the patch is
not needed.

Thanks,
Miklos

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-03-01 19:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-01 11:41 [PATCH 00/11 v2] Push file_update_time() into .page_mkwrite Jan Kara
2012-03-01 11:41 ` [PATCH 1/9] fb_defio: Push file_update_time() into fb_deferred_io_mkwrite() Jan Kara
2012-03-01 11:41 ` [PATCH 2/9] fs: Push file_update_time() into __block_page_mkwrite() Jan Kara
2012-03-01 11:41 ` [PATCH 3/9] ceph: Push file_update_time() into ceph_page_mkwrite() Jan Kara
2012-03-01 11:41 ` [PATCH 4/9] cifs: Push file_update_time() into cifs_page_mkwrite() Jan Kara
2012-03-01 12:25   ` Jeff Layton
2012-03-01 12:30     ` Jan Kara
2012-03-01 11:41 ` [PATCH 5/9] 9p: Push file_update_time() into v9fs_vm_page_mkwrite() Jan Kara
2012-03-01 11:41 ` [PATCH 6/9] fuse: Push file_update_time() into fuse_page_mkwrite() Jan Kara
2012-03-01 19:31   ` Miklos Szeredi [this message]
2012-03-01 20:36     ` Jan Kara
2012-03-01 11:41 ` [PATCH 7/9] gfs2: Push file_update_time() into gfs2_page_mkwrite() Jan Kara
2012-03-01 11:41 ` [PATCH 8/9] sysfs: Push file_update_time() into bin_page_mkwrite() Jan Kara
2012-03-01 11:41 ` [PATCH 9/9] mm: Update file times from fault path only if .page_mkwrite is not set Jan Kara
2012-03-01 12:23 ` [PATCH 00/11 v2] Push file_update_time() into .page_mkwrite Jan Kara
2012-03-01 23:29 ` Ted Ts'o
2012-03-02  9:41   ` Jan Kara
2012-03-08 23:12 ` Andy Lutomirski
2012-03-09  8:19   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87obsgce4a.fsf@tucsk.pomaz.szeredi.hu \
    --to=miklos@szeredi.hu \
    --cc=akpm@linux-foundation.org \
    --cc=dchinner@redhat.com \
    --cc=fuse-devel@lists.sourceforge.net \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox