From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Glauber Costa <glommer@parallels.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-mm@kvack.org, mgorman@suse.de, dhillf@gmail.com,
aarcange@redhat.com, mhocko@suse.cz, akpm@linux-foundation.org,
hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH -V4 04/10] memcg: Add HugeTLB extension
Date: Wed, 21 Mar 2012 10:18:43 +0530 [thread overview]
Message-ID: <87obrqsgno.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <4F671AE6.5020204@parallels.com>
Glauber Costa <glommer@parallels.com> writes:
> On 03/19/2012 11:00 AM, KAMEZAWA Hiroyuki wrote:
>> (2012/03/19 15:52), Aneesh Kumar K.V wrote:
>>
>>>
>>>>> +#ifdef CONFIG_MEM_RES_CTLR_HUGETLB
>>>>> +static bool mem_cgroup_have_hugetlb_usage(struct mem_cgroup *memcg)
>>>>> +{
>>>>> + int idx;
>>>>> + for (idx = 0; idx< hugetlb_max_hstate; idx++) {
>>>>> + if (memcg->hugepage[idx].usage> 0)
>>>>> + return 1;
>>>>> + }
>>>>> + return 0;
>>>>> +}
>>>>
>>>>
>>>> Please use res_counter_read_u64() rather than reading the value directly.
>>>>
>>>
>>> The open-coded variant is mostly derived from mem_cgroup_force_empty. I
>>> have updated the patch to use res_counter_read_u64.
>>>
>>
>> Ah, ok. it's(maybe) my bad. I'll schedule a fix.
>>
> Kame,
>
> I actually have it ready here. I can submit it if you want.
>
> This one has bitten me as well when I was trying to experiment with the
> res_counter performance...
Do we really need memcg.res.usage to be accurate in that while loop ? If
we miss a zero update because we encountered a partial update; in the
next loop we will find it zero right ?
-aneesh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-03-21 4:49 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 17:39 [PATCH -V4 00/10] memcg: Add memcg extension to control HugeTLB allocation Aneesh Kumar K.V
2012-03-16 17:39 ` [PATCH -V4 01/10] hugetlb: rename max_hstate to hugetlb_max_hstate Aneesh Kumar K.V
2012-03-19 2:07 ` KAMEZAWA Hiroyuki
2012-03-28 9:18 ` Michal Hocko
2012-03-16 17:39 ` [PATCH -V4 02/10] hugetlbfs: don't use ERR_PTR with VM_FAULT* values Aneesh Kumar K.V
2012-03-19 2:11 ` KAMEZAWA Hiroyuki
2012-03-19 6:37 ` Aneesh Kumar K.V
2012-03-28 9:25 ` Michal Hocko
2012-03-28 11:35 ` Aneesh Kumar K.V
2012-03-16 17:39 ` [PATCH -V4 03/10] hugetlbfs: Add an inline helper for finding hstate index Aneesh Kumar K.V
2012-03-19 2:15 ` KAMEZAWA Hiroyuki
2012-03-28 9:41 ` Michal Hocko
2012-03-16 17:39 ` [PATCH -V4 04/10] memcg: Add HugeTLB extension Aneesh Kumar K.V
2012-03-19 2:38 ` KAMEZAWA Hiroyuki
2012-03-19 6:52 ` Aneesh Kumar K.V
2012-03-19 7:00 ` KAMEZAWA Hiroyuki
2012-03-19 11:39 ` Glauber Costa
2012-03-19 12:07 ` KAMEZAWA Hiroyuki
2012-03-21 4:48 ` Aneesh Kumar K.V [this message]
2012-03-21 5:22 ` KAMEZAWA Hiroyuki
2012-03-28 11:33 ` Michal Hocko
2012-03-28 13:40 ` Aneesh Kumar K.V
2012-03-28 15:44 ` Michal Hocko
2012-03-28 13:40 ` Michal Hocko
2012-03-28 17:37 ` Aneesh Kumar K.V
2012-03-29 0:18 ` KAMEZAWA Hiroyuki
2012-03-29 7:57 ` Michal Hocko
2012-03-16 17:39 ` [PATCH -V4 05/10] hugetlb: add charge/uncharge calls for HugeTLB alloc/free Aneesh Kumar K.V
2012-03-19 2:41 ` KAMEZAWA Hiroyuki
2012-03-19 7:01 ` Aneesh Kumar K.V
2012-03-28 13:17 ` Michal Hocko
2012-03-28 17:39 ` Aneesh Kumar K.V
2012-03-29 8:10 ` Michal Hocko
2012-03-30 10:40 ` Aneesh Kumar K.V
2012-03-30 10:46 ` Michal Hocko
2012-03-16 17:39 ` [PATCH -V4 06/10] memcg: track resource index in cftype private Aneesh Kumar K.V
2012-03-19 2:43 ` KAMEZAWA Hiroyuki
2012-03-16 17:39 ` [PATCH -V4 07/10] hugetlbfs: Add memcg control files for hugetlbfs Aneesh Kumar K.V
2012-03-19 2:56 ` KAMEZAWA Hiroyuki
2012-03-19 7:14 ` Aneesh Kumar K.V
2012-03-19 7:34 ` KAMEZAWA Hiroyuki
2012-03-20 9:22 ` Aneesh Kumar K.V
2012-03-16 17:39 ` [PATCH -V4 08/10] hugetlbfs: Add a list for tracking in-use HugeTLB pages Aneesh Kumar K.V
2012-03-19 3:00 ` KAMEZAWA Hiroyuki
2012-03-19 8:59 ` Aneesh Kumar K.V
2012-03-28 13:58 ` Michal Hocko
2012-03-28 17:38 ` Aneesh Kumar K.V
2012-03-29 8:11 ` Michal Hocko
2012-03-16 17:39 ` [PATCH -V4 09/10] memcg: move HugeTLB resource count to parent cgroup on memcg removal Aneesh Kumar K.V
2012-03-19 3:04 ` KAMEZAWA Hiroyuki
2012-03-19 9:00 ` Aneesh Kumar K.V
2012-03-28 14:07 ` Michal Hocko
2012-03-16 17:39 ` [PATCH -V4 10/10] memcg: Add memory controller documentation for hugetlb management Aneesh Kumar K.V
2012-03-28 14:36 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obrqsgno.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=dhillf@gmail.com \
--cc=glommer@parallels.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox