From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22522C64EC7 for ; Tue, 28 Feb 2023 11:58:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9730D6B0072; Tue, 28 Feb 2023 06:58:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 923E56B0073; Tue, 28 Feb 2023 06:58:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C4D56B0075; Tue, 28 Feb 2023 06:58:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 653406B0072 for ; Tue, 28 Feb 2023 06:58:13 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 138031C6EA6 for ; Tue, 28 Feb 2023 11:58:13 +0000 (UTC) X-FDA: 80516552466.07.716F4E9 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf17.hostedemail.com (Postfix) with ESMTP id C3DAE40010 for ; Tue, 28 Feb 2023 11:58:10 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=f5n+G1Sa; spf=pass (imf17.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677585491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T7m6rAKgrT8sjyDmNLKdZltCp4n7kd0f94FIxHvHRGw=; b=2KB4DJs8C/8Nh7oRjURgk0DgrhGJfmqO5bAoFtIMdBfceXSWOULkMOfDECIwOf0+EH+tiY HXdi5xhX6VzsChZ06HyOhqVMMINHKkaJagxLzbTBtPe2rpBb6h2/XIR59fSa2l+t1LGWx4 UGPdcm0poErN1znxZ+P+U9WAzviWd44= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=ellerman.id.au header.s=201909 header.b=f5n+G1Sa; spf=pass (imf17.hostedemail.com: domain of mpe@ellerman.id.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=mpe@ellerman.id.au; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677585491; a=rsa-sha256; cv=none; b=XkzwwyjJ90dgCtgw+Vfb27Ip8j6r5S7BdOLPwZhlTw5/tFtZPqan/DnfID0qE5eTXDEgoM d5ZvtIaBy3jOlYgCBJd6aZIP9Deb8fatjnHPdwIzKc4CTb/tYHYAEVaG+R4D6nmk4082um 92zBJbvett7VCxIuu48Rj3iIuIKrb0k= Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4PQwqL0WKnz4x1S; Tue, 28 Feb 2023 22:58:05 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1677585487; bh=T7m6rAKgrT8sjyDmNLKdZltCp4n7kd0f94FIxHvHRGw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=f5n+G1San0GWm4EURNJwqNBX5uB++CKCNw0d4OVqayAOk9X6wJ0cJNyhLbSmkqsf9 I8TJPFTiRl0qOqMUYUC55+bFFECxTuNz91Kw9Ou3qAorl5UorGl+3CtE7vE4BzZvZs tyLvaxkStt6qhxCRxGt1hY9gvWqAkP3cyx831AnNmAdt00vQDCMDvAxAfVYbJ56mwm ScSy6Nwpi94mJ5Iv3P283KF7epzI45yiXTh0JnUJss8Odc3npkdc9osKcGtpxjDwtf Im+tkXG3OdgrSEejGFlh2Y16eZ5woef/IqAPThq/XOLbWzaTSMWupbn8Z9zX27C64f Nz4srrQ/Q4hvQ== From: Michael Ellerman To: Marco Elver , Andrew Morton Cc: Alexander Potapenko , Andrey Ryabinin , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Nicholas Piggin , Christophe Leroy , Liam Howlett , kasan-dev@googlegroups.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Daniel Axtens , kernel test robot Subject: Re: [PATCH mm] kasan, powerpc: Don't rename memintrinsics if compiler adds prefixes In-Reply-To: References: <20230227094726.3833247-1-elver@google.com> <20230227141646.084c9a49fcae018852ca60f5@linux-foundation.org> Date: Tue, 28 Feb 2023 22:58:03 +1100 Message-ID: <87o7peuhmc.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: C3DAE40010 X-Stat-Signature: 1pmzy9r66ngx1ur4uuc8b1rof3pqyoko X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1677585490-208164 X-HE-Meta: U2FsdGVkX19HAdmA6JJR3QMlM0klEHMfaeQZ57jloDQgP4r7njqoATQ+HmuBkfHMusnPdOKBHe0f2fJ7TzElrC2nJjHRDY2iph66OkzAk0QQcp5f32FZc86hY8cG8aga21n164ADrbrnaF1bEm+OEOZb5hLBnYH8Vpu72KVQmrB0pkbrXrk0g2BvKiSDV3N0lEaNh2ghLZmuTJcnBdo8tP1DLMxiWHoM4/x38us0ffjJnmPP5LFwMBhKqiVfetpR955y0Z6N7FkyeRbQzwaE9iHoNLVl+63sr/tOJXELSVwJ0rg5FtQXP7Lr+D3vQI3aaAWJZvPUFrk4PkAJ4EzQ8euoLuKjDKut+ZC2C3AvQLm8QIEBV8IBEZdFFrjoRNpV3V6q4aoE1is9HXQQx/LbQObH6UnQnkGg2m5TT5vjpIHM79dLSeYlxYe0JqYaEKsGCQ1o/pRC2VRPAHWe1paU3TPc/B09dN57B5y+z+P6oCPsQqsHXrAZIX+hXBqhMdrQBtPZ0vljWTgKSYShk5LTNXop2ANvnmhPg7ryJ/v6YXZiCS4nv9b9HVduyx6RQ15fwRedIavoGmH4J+J9OkbdkmmyqX5Vkt+3FMlWjqtYlRqRATKPc0DbseUYSfYbmVwHNsbZb9K0/GMtePhYS4PdxktCQIXdyJ5p8MecYcTWfvBPGWNFO4JrgpdAb/9thaFBrt+OHrl8D35YS7PXJCnYBiweSVWpvB6BVT9oLSfFZUaI6joh65zJK8rGbb+bvwdPQua7lbBfcVnzdUqr8bGNzYZc5IwqcgqNawTUIu4YBMAtLnmSVfXmZZja6vUeOAWC7FywszYpkpO2NdvoE1k2kb0yI6el18GgONjSvnvkupR8RusYOn56bg8Gy5G1bD6aSGSegRXfUaTDbESXT4EFsL3gg0QhHZyXlls4Yg9aEPkuYY8KOBuZpFaLyMt3aH/Ak7gJTrRgIO0dIYqSlEu +yxuXwrk /B1bLyRj9Ufkf0YdIRJGjjw5V6H2VIhmg1FXGAXo52oJzkU49uzBoZYuiygp+5mgz2P3+ap+oFoU+IsROJ+1cowX3dCDUxnzxgavCHTahK28PT5jRrALOr9+fIhj03tD41mRa9vodTPGtDP7+wVyQ/j1HBKvMMoP1YzDsVidzx/aoB4pQQBsCDgJzeuYu3+HWthteuju16bohAUgZMxSnugn6uOWaaMeR/6Zw/VKw0xgBQKObKAjfcIyNyBSRBtJUIcY0VdCnmMOi6cXs23xI3mHYSqVqFgbZ3M/4t7XJfBFVHCxiF2PQnqTrLyq4V0nsMoQBwKZtCh+0bIFQrsAufV/RZwPag13iCMOjWkm2Wx6Fv8pPrPDHyBle71Mfwh46EifRn2IIFI/WTgj4SKmsOchih3IKkTitickn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Marco Elver writes: > On Mon, 27 Feb 2023 at 23:16, Andrew Morton wrote: >> >> On Mon, 27 Feb 2023 10:47:27 +0100 Marco Elver wrote: >> >> > With appropriate compiler support [1], KASAN builds use __asan prefixed >> > meminstrinsics, and KASAN no longer overrides memcpy/memset/memmove. >> > >> > If compiler support is detected (CC_HAS_KASAN_MEMINTRINSIC_PREFIX), >> > define memintrinsics normally (do not prefix '__'). >> > >> > On powerpc, KASAN is the only user of __mem functions, which are used to >> > define instrumented memintrinsics. Alias the normal versions for KASAN >> > to use in its implementation. >> > >> > Link: https://lore.kernel.org/all/20230224085942.1791837-1-elver@google.com/ [1] >> > Link: https://lore.kernel.org/oe-kbuild-all/202302271348.U5lvmo0S-lkp@intel.com/ >> > Reported-by: kernel test robot >> > Signed-off-by: Marco Elver >> >> Seems this is a fix against "kasan: treat meminstrinsic as builtins in >> uninstrumented files", so I'll plan to fold this patch into that patch. > > Yes, that looks right. > > If a powerpc maintainer could take a quick look as well would be good. The patch looks OK to me. It builds for various configs and I did a few test boots with KASAN enabled, everything seems normal. Acked-by: Michael Ellerman (powerpc) > The maze of memcpy/memmove/memset definitions and redefinitions isn't > the simplest - I hope in a few years we can delete all the old code > (before CC_HAS_KASAN_MEMINTRINSIC_PREFIX), and let the compilers just > "do the right thing". Yeah that would be nice. cheers