From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9294C6FD1D for ; Mon, 20 Mar 2023 08:00:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 542A4900003; Mon, 20 Mar 2023 04:00:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F1BB900002; Mon, 20 Mar 2023 04:00:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3922A900003; Mon, 20 Mar 2023 04:00:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 26C7E900002 for ; Mon, 20 Mar 2023 04:00:00 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id ED04512096F for ; Mon, 20 Mar 2023 07:59:59 +0000 (UTC) X-FDA: 80588528118.05.F617CB1 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf28.hostedemail.com (Postfix) with ESMTP id 8A643C000D for ; Mon, 20 Mar 2023 07:59:56 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="DvVZ/yiy"; spf=pass (imf28.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679299198; a=rsa-sha256; cv=none; b=ndkQUbcqa6iVKY6pBJ5vTV4ZWwkddEjhqDwWwuCtifOlUPyK6ZN6t0QXUc2JgtA8CGlCJu tPaCMiESueebAbTla6UWokrCzLRz0tvOUH/TS8n2Kq5F6hlS1Lp/jkYzU/PxTJzqcGRbEW W+D3By7PuLPXEPy4ap1rTw8AaZcrhuI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="DvVZ/yiy"; spf=pass (imf28.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679299198; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9+g3KbEOFFtABO7196UmtGk1ED2IdtiYc1kHtKuQucA=; b=fQnfoaINvVFevtHill/aZwnJihHLaUMXSGpLBa9FfV7/4prEH6zOol1AB0Ab55M9WRZW2+ u5YqTedgVcgX0jE3pvGv2EPXoqqNn+hcn+pOVrTJf0RwruKJrLWA51NF56CEIq0GkFwN7h SOvkWlJ3vykVym57jADFLghUVC4SnFg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679299196; x=1710835196; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=YVw9SzaqPt5R2Jh/Y/jSV9pqtQ0IhNlz8O+4tLs+q/8=; b=DvVZ/yiyyGtIZ2nY+xNRuwM5qpCbxJ+xIara1dK2wBzmvf5evKaVLqi+ ogEeu7SzMpkH3IzOt1PoueyximS5foVRN9Hb6K//KBswROwlEUHuF39jp qQjMUse8LKUw8wJLjZF0AkG97v7/AKwx6/epIU8eMRSPREQCe3Je8V3kj QrL0s+fYXba7MccW98dUi9XyNEJaPARbo2q01rb+BRG+UHXSjRA8B6F+S xv4D11s7QPn8BEpCyxzg7BEh5MJ6J6NoLlKtwPvbRYyZ2mwkhM7Lee365 dcOH8UNw6elVxSxpI3eIJQTKgooKPZHj9E+h2RzHdM77aXW0jOOJP/C3H A==; X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="424875551" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="424875551" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2023 00:59:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="1010375162" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="1010375162" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2023 00:59:50 -0700 From: "Huang, Ying" To: kernel test robot Cc: , , , Andrew Morton , Xin Hao , Zi Yan , Yang Shi , Baolin Wang , Oscar Salvador , "Matthew Wilcox" , Bharata B Rao , "Alistair Popple" , Minchan Kim , Mike Kravetz , Hyeonggon Yoo <42.hyeyoo@gmail.com>, , , , Subject: Re: [linus:master] [migrate_pages] 7e12beb8ca: vm-scalability.throughput -3.4% regression References: <202303192325.ecbaf968-yujie.liu@intel.com> Date: Mon, 20 Mar 2023 15:58:42 +0800 In-Reply-To: <202303192325.ecbaf968-yujie.liu@intel.com> (kernel test robot's message of "Mon, 20 Mar 2023 09:12:16 +0800") Message-ID: <87o7onua4t.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Rspamd-Queue-Id: 8A643C000D X-Rspamd-Server: rspam01 X-Stat-Signature: imzwurhwftzguk3gceca6j3t5wag7czi X-HE-Tag: 1679299196-101800 X-HE-Meta: U2FsdGVkX18GaEvvCzXf22sjDWRYY2B45M/WhqM5YiMmn8ivTlHE6dN/K0e4CMwSX8fHVMHcaMIpI+hR4WklE4TxZr4HFsMz3WBRw+AuaDuOk8DhYJ5ta0UVTo+8Gq67BrqS1mTku02MagiJbPnfjUHA2RaSBAnC1n0QOrQ7IsGuYL2zFPhkmABvtVE94vgKypOIugDampEGaU/Odwvx8m7I0OyspA8qVxu3ftOtTNM/BZZCsaU3V5qbzLVNKyd4xsUuv9JWgaf1nLBBpJQL4G5QsAGjAbg2KDIUNAewFdU+ZpKFmcGJDMRevvhsMd83R/MY3YIcBn9fAbbLscnhrAD2GizkX9YcutqKt2b/hTiaPhnCvW9aDew+82ByNWDhK3pZw8ZaV3mVkph9sPeFiwQ1ckQ9itxpvh+rILNv5g6PeoXeaRA3Jiyu/zm/F91fOPuSCk2EXzrKa+RPd7Zi8SzBmIBgI9+as4HFSK1ApKHLv++4wHWl4VjIvoNR7v3U1BqXyffEtSKHtiQmtc48CXLlo98aMwiQ++dwKv+inCSnwslh9tUOXTZlk9urgsq9nNB8qiVDl/inoygkEa9c57Vh+YaYxyS4wnFt+Km0pNKXrUjDlXk8J7/jjKzF+qBonpXUY+0eFW58WBxleKKeMSIUfqHYl511/AGHYa15HnPdAjg+sRR1dbY9XTRczgYg1NGEMpoJpLNQgeAT37G9J718QGLRE0+ru6TWwYDWCa8tlrr4szsmrU60U+vekPgvpbEPDAFh/QijmKenY4SDNhX4MUifG6d1QX/EtaGNcasfeYC1XVxUZzsvrYBm3t9y2Bxkwt/DEk1B8+ANG5ODBz6vh0/Psq9Yit0HEB1NDqY12ogWK3omL/MOGJnjQEvUalt8MBXlnLcBxgJAOj3k7B4FH4fWIqZZLldAMMAsBQNMWH67k2yko/+7BDmrIUlrnupDqR8ZD9y4tAZ2DPd nYWMPMcy 1NNNOcjxmUZBD8po+AxWNTu8Ep//8MEwW9VUJhfRoBwUt3W30ZwYj4VW4dj1ZZeOS0K4g+5JbXP9HqrR+vq1EcBOWCV10ADSUw18l/QEIVSG6y5/ZtoLGyoor8KYd3imzpwvE3c2LU71ckdVJxO207YoaWufuhpiOhmpGzQRH4b701NRnV/dn/AR8//T0zNRDhDpZRFubgxDh9lpKcFmY2UO9Vsb9pz+Uf2O8rqXCyItLTUV6nQFsTrB0zM6qBmOXkEHrd8EsXkIuQxbHw2E8+Eac562ns8Vrk9LrJOqRkhHl5VHgZPfqYK9VxaKWtIKTeGQXxQQ7yflq4bk64+u9InFsIM3Rgy7GheAnx1PiuBE4acw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Yujie, kernel test robot writes: > Hello, > > FYI, we noticed a -3.4% regression of vm-scalability.throughput due to commit: > > commit: 7e12beb8ca2ac98b2ec42e0ea4b76cdc93b58654 ("migrate_pages: batch flushing TLB") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > in testcase: vm-scalability > on test machine: 96 threads 2 sockets Intel(R) Xeon(R) Platinum 8260L CPU @ 2.40GHz (Cascade Lake) with 128G memory > with following parameters: > > runtime: 300s > size: 512G > test: anon-cow-rand-mt > cpufreq_governor: performance > > test-description: The motivation behind this suite is to exercise functions and regions of the mm/ of the Linux kernel which are of interest to us. > test-url: https://git.kernel.org/cgit/linux/kernel/git/wfg/vm-scalability.git/ > > > If you fix the issue, kindly add following tag > | Reported-by: kernel test robot > | Link: https://lore.kernel.org/oe-lkp/202303192325.ecbaf968-yujie.liu@intel.com > Thanks a lot for report! Can you try whether the debug patch as below can restore the regression? Best Regards, Huang, Ying -------------------------------------8<------------------------------------ >From 1ac61967b54bbdc1ca20af16f9dfb2507a4d4811 Mon Sep 17 00:00:00 2001 From: Huang Ying Date: Mon, 20 Mar 2023 15:48:39 +0800 Subject: [PATCH] dbg, rmap: avoid flushing TLB in batch if PTE is inaccessible Signed-off-by: "Huang, Ying" --- mm/rmap.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mm/rmap.c b/mm/rmap.c index 8632e02661ac..3c7c43642d7c 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1582,7 +1582,8 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, */ pteval = ptep_get_and_clear(mm, address, pvmw.pte); - set_tlb_ubc_flush_pending(mm, pte_dirty(pteval)); + if (pte_accessible(mm, pteval)) + set_tlb_ubc_flush_pending(mm, pte_dirty(pteval)); } else { pteval = ptep_clear_flush(vma, address, pvmw.pte); } @@ -1963,7 +1964,8 @@ static bool try_to_migrate_one(struct folio *folio, struct vm_area_struct *vma, */ pteval = ptep_get_and_clear(mm, address, pvmw.pte); - set_tlb_ubc_flush_pending(mm, pte_dirty(pteval)); + if (pte_accessible(mm, pteval)) + set_tlb_ubc_flush_pending(mm, pte_dirty(pteval)); } else { pteval = ptep_clear_flush(vma, address, pvmw.pte); } -- 2.30.2