From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92274C77B7C for ; Wed, 26 Apr 2023 01:31:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E05056B0074; Tue, 25 Apr 2023 21:31:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB58B6B0075; Tue, 25 Apr 2023 21:31:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7C626B0078; Tue, 25 Apr 2023 21:31:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B9D936B0074 for ; Tue, 25 Apr 2023 21:31:35 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7C87680399 for ; Wed, 26 Apr 2023 01:31:35 +0000 (UTC) X-FDA: 80721814950.29.AA13B69 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf20.hostedemail.com (Postfix) with ESMTP id D89031C0012 for ; Wed, 26 Apr 2023 01:31:32 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hraN3sML; spf=pass (imf20.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682472693; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p0QZrx3KkRlvFtbFUyotRXQWpnWxmebJt52aTb6oL7M=; b=TQ2MlkhYr8VdKe4J1hOibPbOraXOniXE2lxUYhYy474Rc+8Vwtger6sHwA+TFFnzTsZm3f rHVkqaBjxFUcsHLVffr22XFj0jGThfkLawsgdrxoUuqlhfVJwHCLQNM++EEJLTT8G03z6H L/S0OBPET2T/Wt4H8faFsGdqiO5lowg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hraN3sML; spf=pass (imf20.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682472693; a=rsa-sha256; cv=none; b=atCtreNz2DtmGXBI/f1UciQmskdQdmhBN2pDFtHKehiGEP4aSyzkz/IowlrGz6d/2Uo2Mg PqGE+K6XeG/730UTGIi9XInpo/1IaD2uTHHe161cTMVrSr9n4hIamTVHE2Dvnb2AgWet7b XTN6rCzauQT6jvzMVfc+Bt3WHEShewU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682472692; x=1714008692; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=dbQM11BsMfhwEMEoPVos/xk8XjcqFHMg/6FxW7p8SfU=; b=hraN3sMLFgMNbotgnCl2644nEO074xcNPEufJj4++USvmEEzG5FEae6T HDcyVtN/+gTEvCI0yv0Mq1RJ8oSRwozCFX3u6nOT5wQk3rTJNGYm1jr2h 9U7d+Qp23+GbvHAMYKGn2YFJwnal580K527mIQUjWKqIeO7GrGd76ZtUM ev90ZyHvn/ecfb90lzAwp/UPj/f46eDyO3h4ttqh0MIWxeq/O+4TviNk6 OAKYDLRrIBiR7KzGDlTCFo/GbPGRpH8Wk5dYLJ+aQuVrVaCiJOefxgu7+ Js3UKqAmruinmIEmiRPV+8+FK0r8zJpx0+ycUVicjry/sGDq9L9UYW6sp w==; X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="348886897" X-IronPort-AV: E=Sophos;i="5.99,227,1677571200"; d="scan'208";a="348886897" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 18:31:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="783086823" X-IronPort-AV: E=Sophos;i="5.99,227,1677571200"; d="scan'208";a="783086823" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 18:31:28 -0700 From: "Huang, Ying" To: Johannes Weiner Cc: linux-mm@kvack.org, Kaiyang Zhao , Mel Gorman , Vlastimil Babka , David Rientjes , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH 20/26] mm: vmscan: use compaction_suitable() check in kswapd References: <20230418191313.268131-1-hannes@cmpxchg.org> <20230418191313.268131-21-hannes@cmpxchg.org> <87a5ywfyeb.fsf@yhuang6-desk2.ccr.corp.intel.com> <20230425142641.GA17132@cmpxchg.org> Date: Wed, 26 Apr 2023 09:30:23 +0800 In-Reply-To: <20230425142641.GA17132@cmpxchg.org> (Johannes Weiner's message of "Tue, 25 Apr 2023 10:26:41 -0400") Message-ID: <87o7nbe8gg.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: pq7fbm9849wcwjr35ce563s1t7a5e699 X-Rspamd-Queue-Id: D89031C0012 X-HE-Tag: 1682472692-704087 X-HE-Meta: U2FsdGVkX1826nyoEy/389/K0n+XhJsU7swxSA5qZO/t1zUtoK16dsc7Hv8qxj3eBsZxHYr3fE0GgyQtEYDBXaO++QLaUGRKZUCF1ikmg2U2sk7/oVPvbQ+7ocAsGLQ8rf3jwoXZBqs1x0Qloq+ZrQsP4I/UjdvwVlCb98hVIrXD3YBHXGbAB0qjRQUFORWKmsY2xR+6DlzLxiPNrrx2UVV1U+PqwWMnvuOZC2bQ/28rYJd9MROfwtxq+jjImdHcqTmNgUy+JF4HBvgPlbmjH0QQMWEteCPT/LaTAFqsCZW7BFtUwwQwkLz3uvjou3Q9ZEWrbx3yiOhWDdwvL6glvUWhOIrw/Hkc1OEQOI3iyxXNJHVWWvf1DCUZarl2ufz2k1QlYurFahSjsWvwgKoS+c2+x8AFnNRfQAbI++/fLZs+nTW96dI0qLFpyZEF2k8DiNRKrDNBQwO2ex8rpwVLS0smWSuWoTjB9uJ2NCGYr6nmBVB9W+baXXTjMzFzVcwU48+Gek3qJbf18zosJeJE+KABmI+BWX7ybaLmwSCqb5An4rFVk+MinxXJlSrCJqw6XPU4KV7iyXQ4Fq500PKPsCDWBqQ2JbxH+caw5WlID4WwDikRIVOz450gzb9P9sGaK/V/Yi/E4Z0xiDkO+ldjEesNO9ob5xkcMYXAz5VzQFwBM5G6UWL8gg8Op21XZPWeyWLgQhSRxVzpdmnF/Kjcu2QEMIY9M+JhyvblPKSmsFrNpScBFzKs5h2+0QQn5msJF5n2V91aSevfRzjLLQ/jGZfSasqNlym+v0u2voHA7N/tWvCkN6yvprunw1F+aifY6jdvZ+/7a7vCzRaQds0eD+LainXEwzvY4fVMa08OD7AhU8CHDoEilctIKUhXFpZB9NWt43y2N9ooSIjcv6O80Sad/quRKoWDvBWD1EsTpObaUY7/B7LyqZ/ZUA0jHuTGrknG/uhnPv+JFP10kAL pjIh+aUV HVYHSjJFhLm589Kf+UCnfATX5aF/TYTzmIAzSP2mFBqzLeavJZZ1uRQ+X7LV/edwPTra/EiR3MTDZqUZFv7mZe2jZ7yFnscwwzyq590Ix3jMLgY4QV7EN2k0B//1qpLzFzzyF5Yq3kuvcYuY9PGl+OeNeYIu9ndKWvBK+tdOIDTD+eB5DvvtLmrQE3R2meLrkVLWfoy6R8MidOf7MSZRMu0LTraSa3ayAC4MHPuJQ5wckr1b7Tbz8kFbCscB+2hiaOk9J X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Johannes Weiner writes: > On Tue, Apr 25, 2023 at 11:12:28AM +0800, Huang, Ying wrote: >> Johannes Weiner writes: >> >> > Kswapd currently bails on higher-order allocations with an open-coded >> > check for whether it's reclaimed the compaction gap. >> > >> > compaction_suitable() is the customary interface to coordinate reclaim >> > with compaction. >> > >> > Signed-off-by: Johannes Weiner >> > --- >> > mm/vmscan.c | 67 ++++++++++++++++++----------------------------------- >> > 1 file changed, 23 insertions(+), 44 deletions(-) >> > >> > diff --git a/mm/vmscan.c b/mm/vmscan.c >> > index ee8c8ca2e7b5..723705b9e4d9 100644 >> > --- a/mm/vmscan.c >> > +++ b/mm/vmscan.c >> > @@ -6872,12 +6872,18 @@ static bool pgdat_balanced(pg_data_t *pgdat, int order, int highest_zoneidx) >> > if (!managed_zone(zone)) >> > continue; >> > >> > + /* Allocation can succeed in any zone, done */ >> > if (sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) >> > mark = wmark_pages(zone, WMARK_PROMO); >> > else >> > mark = high_wmark_pages(zone); >> > if (zone_watermark_ok_safe(zone, order, mark, highest_zoneidx)) >> > return true; >> > + >> > + /* Allocation can't succeed, but enough order-0 to compact */ >> > + if (compaction_suitable(zone, order, >> > + highest_zoneidx) == COMPACT_CONTINUE) >> > + return true; >> >> Should we check the following first? >> >> order > 0 && zone_watermark_ok_safe(zone, 0, mark, highest_zoneidx) > > That's what compaction_suitable() does. It checks whether there are > enough migration targets for compaction (COMPACT_CONTINUE) or whether > reclaim needs to do some more work (COMPACT_SKIPPED). Yes. And I found that the watermark used in compaction_suitable() is low_wmark_pages() or min_wmark_pages(), which doesn't match the watermark here. Or did I miss something? Best Regards, Huang, Ying