From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F089C7EE22 for ; Thu, 18 May 2023 01:22:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A8328900004; Wed, 17 May 2023 21:22:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A335D900003; Wed, 17 May 2023 21:22:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FB4E900004; Wed, 17 May 2023 21:22:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 79B04900003 for ; Wed, 17 May 2023 21:22:48 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3B97B1A02E0 for ; Thu, 18 May 2023 01:22:48 +0000 (UTC) X-FDA: 80801626416.02.496D122 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf26.hostedemail.com (Postfix) with ESMTP id 2A28814000F for ; Thu, 18 May 2023 01:22:45 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RQJQUSJm; spf=pass (imf26.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684372966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0ISwj8SLPfmWy3/S0GBXIPOplX644hOwpj8rBo+g0g8=; b=IhiA7N5xfpQ4cl+bjevT4XoTPBQQ0V41EI9BNjOMm/K9bcGMx6/JJDVLhcJTTzWNZtathz Dff3ZV3sFM7qg00cRbUR86IYFBmQKtS7kCuA7f8z/F2qWPwtSgcQbQvWtIg9/tWWyYXePi mlkiUOCSrCQ5PDWcjWigjpU615qJ86o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684372966; a=rsa-sha256; cv=none; b=xeP8mGhehkm3wo2Gdke2keT24mZOLKiWTcwXtE8l1xxXgTwbMN56qOV351YLTZxTOiVBIU EQVkLAdz1yK6AJwYGgn2XryxdfOwcgbL0fxgc3T2M0FB0/m5z9RIfA1dpkM/800zqyiXfH aVSUPf8tgdRYmOEFXDL6dS0uAjCx9Zs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RQJQUSJm; spf=pass (imf26.hostedemail.com: domain of ying.huang@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=ying.huang@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684372966; x=1715908966; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=kvsuCZV5nRL+RW1S2zTLxwGX75/5cDfIVioej0JSzEk=; b=RQJQUSJmXZMdW1x1XLnvMGQwlwlJTdHr39yANGP/gzQgoIhMdZeG3pLo SQTD1PU5lxznt11/EmxMIUZhhezf2mGZGLZVBcY5tdgpBl6PI508n+OA4 ZyXjnqI3iZFd+F55vNoVfUO16mHylqF69a1W3ZXdEJklCrcKQVfmvaLaz qet5Xo1EeSCQBgJT/8i+EUhdTD2uPS/mhASMy6u7U5IPyK9ssegrHUR0+ l01L6Lr6HdiphV78nht3QsOZevweCamguGxp6T2alTx6Zn3UWxv0zIDCa /USB9Efx12L3WZen/biWOlDQO2G3TlK5wak2RBkg+QOJhs49YD9ThoYMS w==; X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="341327664" X-IronPort-AV: E=Sophos;i="5.99,283,1677571200"; d="scan'208";a="341327664" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2023 18:22:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10713"; a="679493595" X-IronPort-AV: E=Sophos;i="5.99,283,1677571200"; d="scan'208";a="679493595" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2023 18:22:42 -0700 From: "Huang, Ying" To: Khalid Aziz Cc: akpm@linux-foundation.org, willy@infradead.org, steven.sistare@oracle.com, mgorman@techsingularity.net, khalid@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm, compaction: Skip all non-migratable pages during scan References: <20230517161555.84776-1-khalid.aziz@oracle.com> Date: Thu, 18 May 2023 09:21:39 +0800 In-Reply-To: <20230517161555.84776-1-khalid.aziz@oracle.com> (Khalid Aziz's message of "Wed, 17 May 2023 10:15:54 -0600") Message-ID: <87o7mibfj0.fsf@yhuang6-desk2.ccr.corp.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 2A28814000F X-Stat-Signature: 1nwdapqd4tjweea1hued6num6wtf6rxh X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1684372965-297277 X-HE-Meta: U2FsdGVkX18Od7Nguxm4fvlLXDbFshl/oRCAYH8T46LjSe9Tu+bs7QcBpRtVl1s6siiJYzuoszjSDkDjuK+nnWBMTLORBAJqYP/jtcUCWbYNG4oikLlBHzIoux6kCr70SgyGAL+qtTSRInxHN55bTPQeAlnA8KE6+B/Gl0IwWqoi5tApCX+MGYFz3fLdMEHset8ElvBgD7Z9SxsuTvnI/uUCHcJvleDRazzV1/u43NFMLPwGJPKil0rLHOmuwsP5WJ9wZKbTyGZyKRgLRevBjYAbPuejdEhIX7VTDD8iHc8XAKQzPaa/gM913JMpSsDsJbGqCLR0/fHWXDoppchpThC3tsoXEfj13V20fhWfcOJ32RFLHToflm8AHNUw8pY+5hIrUcY0QwnAdC7oAw67pWkOuecqLmvICjyXvPKCg38xt7vKrTVBiJI6G7T+97fXP6fSzWlsoVhJ6aNpaluM5fGNniAwVHFduuiMRclDN5hspvYyeLA+KXQv1LgBCtsn4x74FB+AvDX5Aj1jex2zNY6P6S99Q1ivWHHvoIa0qqb6OuU+U9DQfS0GbyutGIL9IuA8ObrP1+X7CX2IAog365fuV9jo1D6pWVzuaZI+KxqsNrogYpPCS5HWvq1xf6HyPaSA7o658DGDmfC0vq5EsNVne9Ev5L0+MgWNcmWfHldSPBYA7k/1YzOmpo02DykFcZzx6VJArVsCXnnozznl80lmPPtAdObhBAQIgHhaIQKR3eoNYP+oNVZCdbmu7IDj1LO2xOBH8QfanozY5x6+GYi/zBbgn+2IXOAoVgoN0P8dC1cmkCFLT5qUW3omDr1Iighp5quFqoV1gP+r8DGuwZ6Bv7PbCaFJarolyMZ17ZCJzJv4Ptit++Fbgbz+gVbKtx3CWRY5Y/oimDkD8bIJnAIXYc3/r1Mp00gJ6nYu2+ck4K7eZ1fJimg9ZIRIpJKjIQYaDcsGtSX4geOi02d QBNyQKZq urx0IeO98CZho2cT4fJ7/xbibObOAqU5qGKmDPwegNhswD8eze4RfJIhODR5iiP/mKmrPVONdaw5MZZQGIsxoW3g0Lt8GLsV+IVZW3BVYrqR9LnucRcwngTDCw9eX31cJKre+w2Mg84jRHdDGZ7+4OZBsFlrYf/IfTIk3CAyjn7/6wWKcv8/V/mrv3Jf9X/2HPCi0K4HH/OuxYOE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Khalid Aziz writes: > Pages pinned in memory through extra refcounts can not be migrated. > Currently as isolate_migratepages_block() scans pages for > compaction, it skips any pinned anonymous pages. All non-migratable > pages should be skipped and not just the anonymous pinned pages. > This patch adds a check for extra refcounts on a page to determine > if the page can be migrated. This was seen as a real issue on a > customer workload where a large number of pages were pinned by vfio > on the host and any attempts to allocate hugepages resulted in > significant amount of cpu time spent in either direct compaction or > in kcompactd scanning vfio pinned pages over and over again that can > not be migrated. > > Signed-off-by: Khalid Aziz > Suggested-by: Steve Sistare > --- > v3: > - Account for extra ref added by get_page_unless_zero() earlier > in isolate_migratepages_block() (Suggested by Huang, Ying) > - Clean up computation of extra refs to be consistent > (Suggested by Huang, Ying) > > v2: > - Update comments in the code (Suggested by Andrew) > - Use PagePrivate() instead of page_has_private() (Suggested > by Matthew) > - Pass mapping to page_has_extrarefs() (Suggested by Matthew) > - Use page_ref_count() (Suggested by Matthew) > - Rename is_pinned_page() to reflect its function more > accurately (Suggested by Matthew) > > mm/compaction.c | 36 ++++++++++++++++++++++++++++++++---- > 1 file changed, 32 insertions(+), 4 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 5a9501e0ae01..f04c00981172 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -764,6 +764,34 @@ static bool too_many_isolated(pg_data_t *pgdat) > return too_many; > } > > +/* > + * Check if this base page should be skipped from isolation because > + * it has extra refcounts that will prevent it from being migrated. This appears duplicated with the comments in caller. It's OK to keep one only? > + * This function is called for regular pages only, and not > + * for THP or hugetlbfs pages. This code is inspired by similar code > + * in migrate_vma_check_page(), can_split_folio() and > + * folio_migrate_mapping() It's not good to duplicate code. Why not just use folio_expected_refs()? Best Regards, Huang, Ying > + */ > +static inline bool page_has_extra_refs(struct page *page) > +{ > + /* caller holds a ref already from get_page_unless_zero() */ > + unsigned long extra_refs = 1; > + > + /* anonymous page can have extra ref from swap cache */ > + if (PageAnon(page)) > + extra_refs += PageSwapCache(page) ? 1 : 0; > + else > + extra_refs += 1 + PagePrivate(page); > + > + /* > + * This is an admittedly racy check but good enough to determine > + * if a page is pinned and can not be migrated > + */ > + if ((page_ref_count(page) - extra_refs) > page_mapcount(page)) > + return true; > + return false; > +} > + > /** > * isolate_migratepages_block() - isolate all migrate-able pages within > * a single pageblock > @@ -992,12 +1020,12 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, > goto isolate_fail; > > /* > - * Migration will fail if an anonymous page is pinned in memory, > - * so avoid taking lru_lock and isolating it unnecessarily in an > - * admittedly racy check. > + * Migration will fail if a page has extra refcounts > + * preventing it from migrating, so avoid taking > + * lru_lock and isolating it unnecessarily > */ > mapping = page_mapping(page); > - if (!mapping && (page_count(page) - 1) > total_mapcount(page)) > + if (page_has_extra_refs(page)) > goto isolate_fail_put; > > /*