From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DDA0C77B7F for ; Fri, 19 May 2023 14:17:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3E29900005; Fri, 19 May 2023 10:17:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEF5A900003; Fri, 19 May 2023 10:17:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DD5F900005; Fri, 19 May 2023 10:17:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 913A4900003 for ; Fri, 19 May 2023 10:17:12 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 601B5140A1A for ; Fri, 19 May 2023 14:17:12 +0000 (UTC) X-FDA: 80807206704.20.70AC613 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf02.hostedemail.com (Postfix) with ESMTP id B040780018 for ; Fri, 19 May 2023 14:17:10 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=AJ75V+tW; dkim=pass header.d=linutronix.de header.s=2020e header.b=jr9EY4bJ; spf=pass (imf02.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684505830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RW8QTHH2Jw8CMnTF4UFRd4OYKTVSzS57uzm3aSetCyg=; b=vHdgRRnz2wL0X5oKFE+MZhN2rTkGgWe5fcbTW1LWLsbxy1cvDYfo5IenZzJpBb4d7CLBSl wqkUIfTSnWkqqMTzzcgmf9UweFVu+20/RT/DJv2Cj02oeAm85/u0XUby8uKY4Yv0aqCdyL Q8gvuy2yC0DNXSnstL87kRdHIECt8x0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684505830; a=rsa-sha256; cv=none; b=g/yDnP5qIA3/7Vkm/W1euRpxq+cAx6FpapSX7XHnc7/INdpO5ktu5EPulHF4H+ucoMrN6s cRguvrfSkm0FXuNqKB8ZlrJSYwdrcYFBi4ny/22J1PLRbN4GuRxbT+cMq022/dOKOSH8aA vrjeJxE6xbDhtygtOw2iuR57g3VsYrw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=AJ75V+tW; dkim=pass header.d=linutronix.de header.s=2020e header.b=jr9EY4bJ; spf=pass (imf02.hostedemail.com: domain of tglx@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=tglx@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1684505829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RW8QTHH2Jw8CMnTF4UFRd4OYKTVSzS57uzm3aSetCyg=; b=AJ75V+tWrw9L+dGjzf6PMrtheX1Ricc7Om+mvcOCs5nMVM7oBbY/eZKJImkwiWGwtUO5v0 kWFhX0S7Nm33qsunEcnERoxaQ+wrRr4sNVkg8CvH0+NgqBTm3VSSlamlNzuAPKcoFmA05s LXfpO1dp2pRR2d/ke7z2ib10Hqdg+nwfyDRozBNevV3436Mdfhf32qFl7GBKC/0Ui+aDug ae6G6Dr2OzJXK221/3NbD9BdbQdt9sTWHGR00Wnk4U4UqxzW8OQcjhym105ryC9QO5Ke5V 5elX0MatCtOON2LLsZI35a2SdeZm4Q1ivc7l+cT8Q3xqG4HkjuTwng7H7zPZmQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1684505829; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RW8QTHH2Jw8CMnTF4UFRd4OYKTVSzS57uzm3aSetCyg=; b=jr9EY4bJCdJ6pV7fXy9V86XiRdd+IsJjMm0i0wW+1Pdk0Q9jQr3RP6ZhhGp2xP/Ub8H9qT ezrTAx2dxUANNZAg== To: Baoquan He Cc: "Russell King (Oracle)" , Andrew Morton , linux-mm@kvack.org, Christoph Hellwig , Uladzislau Rezki , Lorenzo Stoakes , Peter Zijlstra , John Ogness , linux-arm-kernel@lists.infradead.org, Mark Rutland , Marc Zyngier , x86@kernel.org Subject: Re: [RFC PATCH 3/3] mm/vmalloc.c: change _vm_unmap_aliases() to do purge firstly In-Reply-To: References: <87zg658fla.ffs@tglx> <87r0rg93z5.ffs@tglx> <87ilcs8zab.ffs@tglx> <87fs7w8z6y.ffs@tglx> <874joc8x7d.ffs@tglx> <87r0rg73wp.ffs@tglx> <87edng6qu8.ffs@tglx> Date: Fri, 19 May 2023 16:17:08 +0200 Message-ID: <87o7mg4d97.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Stat-Signature: oc948dkxmgpqyd4cabbbaizaujskonwj X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B040780018 X-Rspam-User: X-HE-Tag: 1684505830-615029 X-HE-Meta: U2FsdGVkX1+juV5QrHZ4jOn1nDvozvSRK0N5gNnhDyu8y0yH5/Uelk0wHR/XT2GPkrZlIfxb6oucSYeCshbylfj/hhw1nqnBTzNWIqiQjA/WdngeU9csNYA7fOVS7XG2o2znd+eP0MEsTfECuGUMIk0BtARZq1FJ3tnkhLZPCAPmGtHyRpuN9Ctlp+eSdgnJzc+59o5t8hhidxxydumbRo6QuQLxgJwlijUlLQ3Wn6qCdAwHmEaiW/RM9Ekn53TVcyW+wkryf6T0werI2VvQJVWZ+KURHpyObVh33Kdi2ivr+5aq4keNPgCYT4zml0VykD5vtVjoQWbuud3TaHSP6Ov52lxHpRiRfN9uXrqTy+V+TrUO/rKaXq9mk+QEkIEqHblpLaDqbnst1ghB6cj4hCgWfNKUptB9bss2gyEFv4Q/TJiVDS6wSwed8u5ukBERYGliYd8Ppzg3zSS0u6tRzVd1n94r5Ozl9Oq0dpD2U0Gq13Wr2Lq6MvpaKe2/H19QcAB9DsvKyTS1bUpSniuFtex89Ntml4aMxGy8xr3USH9b4lfJ+9ht2HOfAfAzGDpHkCQoJ8ycxmE2w+JBYZbQ1/O4vtmG1nNHhWj+TFwrBYCrxl4XqWv6gnTp/TaGLZsTGTY60UNVdK+ug6oFJd4OQbuGJ0Ik6aYj4pYVxhd9S76IbuOYk2MXpbuN8j/qOqZlaafnNYhRXRA8zEKyWRjbeAw/hOIXLg4628ll0G58XGzZt7OuPfv3ogwKhmsGkw9+sq278z5yp/eMTLqUHt7YzRGpfrXGUO0UxU1Oi3N8JnZu0dq/KijvYAME/hoDmgpsFZ9u1yE+jWjKS50QKhNzvRP0cqVYb4ReufxVMlUKBXXGQ/k5BgoEz0ll6+sTA9eMw+gVOQoiw75wSvps1G17kRzS7fBgwUVI+QE3uR7KgX8MmL4D6g6hXUFOmjpehPwJIbeE0KwpUPCIxFwncEu RpJHiaMG f3zPv/2PYWJ105UTwbCno/SHy0oRDx3j7GgcnSKpARrZe3fJ32r3E8FThNu4ZTTc6ytRODNlnSFNo2+l5GKp4t3gV1nxKb79jRRZrj7MWBmPzmL9esPI24h50mw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 19 2023 at 20:03, Baoquan He wrote: > @@ -2245,6 +2260,9 @@ static void _vm_unmap_aliases(unsigned long start, unsigned long end, int flush) > > might_sleep(); > > + mutex_lock(&vmap_purge_lock); > + purge_fragmented_blocks_allcpus(); > + > for_each_possible_cpu(cpu) { That still does TWO iterations over all possible CPUs, while this really could be one.