From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B541EB64D9 for ; Thu, 6 Jul 2023 06:46:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69D528D0002; Thu, 6 Jul 2023 02:46:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64C398D0001; Thu, 6 Jul 2023 02:46:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53AD78D0002; Thu, 6 Jul 2023 02:46:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 46D148D0001 for ; Thu, 6 Jul 2023 02:46:04 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 123DE140469 for ; Thu, 6 Jul 2023 06:46:04 +0000 (UTC) X-FDA: 80980252248.04.F2DE6A5 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf20.hostedemail.com (Postfix) with ESMTP id 8AF9B1C0015 for ; Thu, 6 Jul 2023 06:46:01 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bfHYoeo5; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf20.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688625962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kKb13HUp4d8fI3xHocYdn0DRUIrPzj/3ntPfCUstRx8=; b=AL+OdGTYkcDYcqP7N3aBuV4sbxRX8cLZCqaUmIuKJXmGbH7l/xDl0Fa9pFRjNTiQ/vH8qi gEbShDwZQ4e8Jp/a3WGUyogcngEB+7/Bn8Gi3/2PAIgvRryDf6GsrHLVSGRO8ipMXz9Pn7 HLkfd7BhEjIWuGqX0SYP5C5M6X8XNSI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bfHYoeo5; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf20.hostedemail.com: domain of ying.huang@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=ying.huang@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688625962; a=rsa-sha256; cv=none; b=A37EbkBi/nW3KlHFFI01OR0JY+WRE9vC07kX+V/XNb0nJovuqVbS4HGBSMbYiOw9Z27nab QiLQcmBaUEW0oqUidlevwntywoxMIS2WQG2i8Am30cIEMlCZcSnL9J4gfWnq2Ag2z4d1mW Vw5fFB6qPlI565bUKiodUG3gKkFvCyc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688625961; x=1720161961; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=mRVVHAmFZ45/3wNp4nf90MXw/IuSIO9dhVaqP8s/mB0=; b=bfHYoeo5YV6xwhPI1vmv2a3JHbNxkjKaT/1urT4GHUfVJiklAKwSMCxX qeADSp6tCYiW997wVgOcRsCiCWgfx0kBNKvj+532bfJWIJuvXdR0sA81S BFcEoAtEmUt9My2cG18yxT8eqMDG+Wp1eXX9zlP5ejw4tG0rHbnBiVp8P VujCWVWEFWO3MoLy67Cfitv89YNrQZWQah4Xe1AAeA8cYTbmdGmXzjyXS R+Jrk+ZbZvGCaWgINmRlAHc+XEcJ2hG1BYWmhAWjRpPriqWZqJkkpKhxw d1JGLd1ohPszkNrdtkFN+0XhjTdWIZyOX0phm81Sg1Ja+BoTS43FdvQiy g==; X-IronPort-AV: E=McAfee;i="6600,9927,10762"; a="360994588" X-IronPort-AV: E=Sophos;i="6.01,185,1684825200"; d="scan'208";a="360994588" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2023 23:45:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10762"; a="1049969094" X-IronPort-AV: E=Sophos;i="6.01,185,1684825200"; d="scan'208";a="1049969094" Received: from yhuang6-desk2.sh.intel.com (HELO yhuang6-desk2.ccr.corp.intel.com) ([10.238.208.55]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2023 23:45:57 -0700 From: "Huang, Ying" To: Miaohe Lin Cc: , , , , , , Aneesh Kumar K.V , , Subject: Re: [PATCH] memory tier: rename destroy_memory_type() to put_memory_type() In-Reply-To: <20230706063905.543800-1-linmiaohe@huawei.com> (Miaohe Lin's message of "Thu, 6 Jul 2023 14:39:05 +0800") References: <20230706063905.543800-1-linmiaohe@huawei.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Date: Thu, 06 Jul 2023 14:44:12 +0800 Message-ID: <87o7kph743.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ascii X-Rspamd-Queue-Id: 8AF9B1C0015 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: jtifdocu7b7wwtkw7ssn57wwyhaownd5 X-HE-Tag: 1688625961-177862 X-HE-Meta: U2FsdGVkX18tEQWtV2wGgrfs/s6jwNwxoMToiztGp+mu1ad8a/zBAYEZHie9iTRoZfwisNBCD+dQoPdcYJHPhSzHI5BTo4xL/sO71tzpMjktFxrfGkTLmpJClmIVvucBIsCzlFuXhAfZjr+D51t+6xdL8xoFOz7iJyssfVfqKBuTalHZDmkYONxyCYnU6Y4/70ZYTvvi4P0OnRhCeFeOYbaZbF7NJ2IBMfbC3z+U5tGs8B8LuXnxVlxpHW/gdDMG/Lsi1zQ56BcDOYRpW55RSHMf7YXw5nEaodllxP9EEMs+af/0Kkpnfo0HR5wCU6GQJ5OYLQmFeAph6s/4VhIz6QVZCKQ8NxezyEVXlukTxkIqypNAkhrfJBiX8GTuczj5HZ7D8m6OYkSTnhML78OCV59IkAadiCPsfLcwP/XsdK4ZXdhLpBL7mUvMpDIFhzVJXpmqqc/EAjqUeN6FKu+/LWC6V/UMvcs5jCrjxXWjhTmGlT2oxotSnXGgKAhRkQs3WJODg0nsvpMQN8wT1Y9jkc+x6h60WNbCpZVx7gk5O5KIzlybyFpTQ8d1UmOKru7kS2WIoY4FRqQCdkGs8Ca3v5N0S8sPRT0mYSQT+Ck3iT5Zti2vtGOb6v0BtZixUaqAXPCsFUmd3U1HJEfrMxdOs0xZWQU1v4M2xudCaauNGw1FvvHPefBRQHW3lhdCuMjyhBJseQHx2Kuu9TcFYKB+gjFGiEl7ckjJtiaGCBsroFRPqNqmCMig0Y1uXq8UfHOH88ndSuv8s7AEZveXfYavG1SrbWE+uWC5qHivRC3dn8MQdSycr/QegautKU8mU8lcbz88UC7vVwol5DWd4kOl9JTOCpBzhcc3sKKilHOffDvF+ZkkjC9BseJqnU8SGIxODTQgFHKXcN8hFKpAkm6L24/vwkMXOVFDROwZfJ+K0FLyVMlrewqtSc3Pca9V0tC/SuGxS078l7m+ZFlP842 DAdx9ZJ2 iFFFXLZEgMKY038h00bALqjY6Hc4ISaDKowghjdG1ZLuj+ePYeXcFN+Wc69EaJiUikT9MmRiX/taI8p5Utx5XbI0AldvuMno22IABtO5t9VNJQ0wc5ruAFxsFPJkwwh4kFFRXiHibbLCs1yOQF40ke05GrCEJix3mltjHJnEo9Z3yuNteMA3wLQtCLDOuV5u+yic/0b/H1pJ6IK15EJsViB66RIQY/b/LOQOtF3EV5WtGoAg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Miaohe Lin writes: > It appears that destroy_memory_type() isn't a very good name because > we usually will not free the memory_type here. So rename it to a more > appropriate name i.e. put_memory_type(). > > Suggested-by: Huang, Ying > Signed-off-by: Miaohe Lin LGTM, Thanks! Reviewed-by: "Huang, Ying" > --- > drivers/dax/kmem.c | 4 ++-- > include/linux/memory-tiers.h | 4 ++-- > mm/memory-tiers.c | 6 +++--- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c > index 898ca9505754..c57acb73e3db 100644 > --- a/drivers/dax/kmem.c > +++ b/drivers/dax/kmem.c > @@ -264,7 +264,7 @@ static int __init dax_kmem_init(void) > return rc; > > error_dax_driver: > - destroy_memory_type(dax_slowmem_type); > + put_memory_type(dax_slowmem_type); > err_dax_slowmem_type: > kfree_const(kmem_name); > return rc; > @@ -275,7 +275,7 @@ static void __exit dax_kmem_exit(void) > dax_driver_unregister(&device_dax_kmem_driver); > if (!any_hotremove_failed) > kfree_const(kmem_name); > - destroy_memory_type(dax_slowmem_type); > + put_memory_type(dax_slowmem_type); > } > > MODULE_AUTHOR("Intel Corporation"); > diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h > index fc9647b1b4f9..437441cdf78f 100644 > --- a/include/linux/memory-tiers.h > +++ b/include/linux/memory-tiers.h > @@ -33,7 +33,7 @@ struct memory_dev_type { > #ifdef CONFIG_NUMA > extern bool numa_demotion_enabled; > struct memory_dev_type *alloc_memory_type(int adistance); > -void destroy_memory_type(struct memory_dev_type *memtype); > +void put_memory_type(struct memory_dev_type *memtype); > void init_node_memory_type(int node, struct memory_dev_type *default_type); > void clear_node_memory_type(int node, struct memory_dev_type *memtype); > #ifdef CONFIG_MIGRATION > @@ -68,7 +68,7 @@ static inline struct memory_dev_type *alloc_memory_type(int adistance) > return NULL; > } > > -static inline void destroy_memory_type(struct memory_dev_type *memtype) > +static inline void put_memory_type(struct memory_dev_type *memtype) > { > > } > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index 1719fa3bcf02..c49ab03f49b1 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -560,11 +560,11 @@ struct memory_dev_type *alloc_memory_type(int adistance) > } > EXPORT_SYMBOL_GPL(alloc_memory_type); > > -void destroy_memory_type(struct memory_dev_type *memtype) > +void put_memory_type(struct memory_dev_type *memtype) > { > kref_put(&memtype->kref, release_memtype); > } > -EXPORT_SYMBOL_GPL(destroy_memory_type); > +EXPORT_SYMBOL_GPL(put_memory_type); > > void init_node_memory_type(int node, struct memory_dev_type *memtype) > { > @@ -586,7 +586,7 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype) > */ > if (!node_memory_types[node].map_count) { > node_memory_types[node].memtype = NULL; > - destroy_memory_type(memtype); > + put_memory_type(memtype); > } > mutex_unlock(&memory_tier_lock); > }