From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DFEEE7106A for ; Thu, 21 Sep 2023 13:14:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B12E66B0192; Thu, 21 Sep 2023 09:14:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC32D6B019D; Thu, 21 Sep 2023 09:14:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98A986B01A3; Thu, 21 Sep 2023 09:14:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8A13C6B0192 for ; Thu, 21 Sep 2023 09:14:23 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3FA0912089E for ; Thu, 21 Sep 2023 13:14:23 +0000 (UTC) X-FDA: 81260648406.09.21ADF75 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf29.hostedemail.com (Postfix) with ESMTP id 332B612002D for ; Thu, 21 Sep 2023 13:14:19 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=yQ9zS8ML; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=956IPJl5; spf=pass (imf29.hostedemail.com: domain of tiwai@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=tiwai@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695302060; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hr4dJrGCAHGoorv5nC8n0VYn5plN0T8DDF/tRgAs9xw=; b=Ji3sEpEvaUsQFy8BUxP+wAN0FYFnX8n6ZdVhFUuyNZFi2XRJbvzdKgWRUPJ7DUgUNFPM+P JuQuIy1xmimYLZ3I/T/0/EQbKPnrPf2spJGujoWX5k0htkj4MK9ouqwrTTJBT5ITre3Hym N5Tjw9Gx9FJylMdUvYOwg83X2pU+qPc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695302060; a=rsa-sha256; cv=none; b=xLGUINaF3cYUAdThMpOzWLe2JU+ZlQahIxpewV2lhfWQYsS3BzI3XajpESnAXTS0TxDuV1 PiYGTAmzazXAoEG+caz6YuXHVHfbQmYxF9+32lNXekiBmOghl6OIiBErgOxQ65Fy3KEHCa Z9h04d2XM06LpuzSrpfrgmd5PbgGhU0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=yQ9zS8ML; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=956IPJl5; spf=pass (imf29.hostedemail.com: domain of tiwai@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=tiwai@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1C1591FE17; Thu, 21 Sep 2023 13:14:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1695302058; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hr4dJrGCAHGoorv5nC8n0VYn5plN0T8DDF/tRgAs9xw=; b=yQ9zS8MLtbBzIv4XI+Fx8UAy9OA58BxnvA0q2n1vhQLjUSsNzM4w4MdLAlqHixUwTRUdoz XubkwoYkWO2vMUvbTapSgZvfIRIZERoGsyfrIx8lbCcnL4Q5xOqDi0chiiy+ZoYKd3EIit dDKtvAuqYXOAhz9Frc0BAj0JX4LPLQU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1695302058; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hr4dJrGCAHGoorv5nC8n0VYn5plN0T8DDF/tRgAs9xw=; b=956IPJl5aJAhxsQTTbR4rPzctFBiEm6NaXj8nUVK+t2LBvTby0r5Safd7j/+V6jKUnW38T CX4LhyiTf45bK1Bw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A5F23134B0; Thu, 21 Sep 2023 13:14:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id o5KBJ6lBDGVtMQAAMHmgww (envelope-from ); Thu, 21 Sep 2023 13:14:17 +0000 Date: Thu, 21 Sep 2023 15:14:17 +0200 Message-ID: <87o7hvzn12.wl-tiwai@suse.de> From: Takashi Iwai To: David Howells Cc: Jens Axboe , Al Viro , Linus Torvalds , Christoph Hellwig , Christian Brauner , David Laight , Matthew Wilcox , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , Oswald Buddenhagen , Suren Baghdasaryan , Kuninori Morimoto , alsa-devel@alsa-project.org Subject: Re: [PATCH v5 01/11] sound: Fix snd_pcm_readv()/writev() to use iov access functions In-Reply-To: <20230920222231.686275-2-dhowells@redhat.com> References: <20230920222231.686275-1-dhowells@redhat.com> <20230920222231.686275-2-dhowells@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 332B612002D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: iybztmmxm3751i6ieda6bnxowyge3nx3 X-HE-Tag: 1695302059-456245 X-HE-Meta: U2FsdGVkX1+pua4tW+cA8LV7BAKRGY9KvpquvGickwjR2ktnwVHla442lOE8BZjHRlIwa8uLVN481G+/z9FSyLaaeuFPmWEdCWEBh/wEv4iV1bwkyF+inGz3tlil1mYjvX+axfh+WcpBnJ/yy7/CjgsXtxzGTJDJHaLbZ1hJnb/8V3ElDzl2Nk5CU1r3V4FOSUOhlDHdNcQTPdMECMJo+JyGaGIDWWsiBt7At6sMfwGYlY64J+D9nWc7s1xsqNMcoZ9KEO7Vt2Vh1Glo1ZCdK7d08Htv/wLQmIENfo5iVmdUBmeIOnw/UhPzQ/1DKHtkObIWHDjKv5HWLJmjtRXy9MBalq5aoU6SpZwu8DSY/DAb84kOoAwdkutXKAqkbsze+8uIYnODoTL/GjlwnGzTW4vMkuKPHlKUWB2YbA2te+3bnWBsQbYipzWwmzyxALgTP04sduO0ZM4SeH1py8BQjthv0ng0arXVMddcBkhqpyKwYbj3G3mEArLYbTaEU8uffXYhCYHHcSoxPLfFcB1S/+jwdn8S9abT2Hy3iDZ4U+6WTADAdN7YzONGtY5u9GzAouEi1qNURlIlLcbJlBQAJ+KTMqWs0fAJHlGHiTiNtu59bx8OW0mUAafSn2AkWLrOZSZUg00Q8E1IUEETTADL1w6Az2ZrfTxM0I+KntqboLOl341x7TjstllFX9Yj25OXEKvKZxHIUfhRgIPYdqPjMhcxpkHN9aHa1BLZuNtkoP5+kxfYBb2S+lWWmjxUOApVZHqt8xq/6o6/k/hhtUTDEwXIuqUd90zuhMcC8PS2txNpUTyBJpw4bV2448TOfhFa7yRHKQLVZeUdY5TH/wVQ4B6hZHDIRYekUhl7Ti5BXdyQ2AuG09R/cqCB1YynVuLENk4C9ddxPkD3Bf3nU3IKeZOOfz8mgOeUJDEqZSTl9RBogPUoyRrzuqJWl3j+sX2InSHAYbPkmfW2eLJmSKb P1bL5q40 LmiuB6tEMZtodmdQmADP6PA8OPm/ty9LXXmRDuPgbGruvNA/h/DjGeZ7BDdTtl3LRDrv2j5G3gEMeJaZdTH0z+Ux1Zi7BVjJExPtiA1mWUqQ/Sj5aWfo6DRZJVM2KzmRVlru87SZ8YJKOsFriDfWOTjP0aVz7zhIHzSZZOrnbutde1KAj/WSQr1Ea3N4TmVRpjWqMuU0JQVVcg+Q9jzUhrE1QwigmN6JThiy+HMzXQyET3OIShHL7g4hTmCb+iWz7QmUdT6g9aRQ0CGk2kkwFkVTP4IQdWRGkTNojlg0u6lgjrN1d6ugNUOF8BHAP7Bh17OHA7AaPf9Lf4iAypOZws07mxIQXEIYGcof3b/dArbkXtpHAVaJhX+KKUwI3qPphpoSscMaKtak7SzU+uobDwYmM4qfR5xcoZN3AT97+/g7Ptmb98pGXPQPVeWrwYeOtpUl2OqGYujy0oik= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 21 Sep 2023 00:22:21 +0200, David Howells wrote: > > Fix snd_pcm_readv()/writev() to use iov access functions rather than poking > at the iov_iter internals directly. > > Signed-off-by: David Howells > cc: Jaroslav Kysela > cc: Takashi Iwai > cc: Oswald Buddenhagen > cc: Jens Axboe > cc: Suren Baghdasaryan > cc: Kuninori Morimoto > cc: alsa-devel@alsa-project.org Reviewed-by: Takashi Iwai Would you apply it through your tree, or shall I apply this one via sound git tree? thanks, Takashi > --- > sound/core/pcm_native.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c > index bd9ddf412b46..9a69236fa207 100644 > --- a/sound/core/pcm_native.c > +++ b/sound/core/pcm_native.c > @@ -3527,7 +3527,7 @@ static ssize_t snd_pcm_readv(struct kiocb *iocb, struct iov_iter *to) > if (runtime->state == SNDRV_PCM_STATE_OPEN || > runtime->state == SNDRV_PCM_STATE_DISCONNECTED) > return -EBADFD; > - if (!to->user_backed) > + if (!user_backed_iter(to)) > return -EINVAL; > if (to->nr_segs > 1024 || to->nr_segs != runtime->channels) > return -EINVAL; > @@ -3567,7 +3567,7 @@ static ssize_t snd_pcm_writev(struct kiocb *iocb, struct iov_iter *from) > if (runtime->state == SNDRV_PCM_STATE_OPEN || > runtime->state == SNDRV_PCM_STATE_DISCONNECTED) > return -EBADFD; > - if (!from->user_backed) > + if (!user_backed_iter(from)) > return -EINVAL; > if (from->nr_segs > 128 || from->nr_segs != runtime->channels || > !frame_aligned(runtime, iov->iov_len)) >