From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE929C4345F for ; Fri, 12 Apr 2024 01:38:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4ECF96B0088; Thu, 11 Apr 2024 21:38:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49CF06B0089; Thu, 11 Apr 2024 21:38:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3169B6B008A; Thu, 11 Apr 2024 21:38:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0E0476B0088 for ; Thu, 11 Apr 2024 21:38:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CD001C0C4F for ; Fri, 12 Apr 2024 01:38:15 +0000 (UTC) X-FDA: 81999169350.17.AC303E2 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2048.outbound.protection.outlook.com [40.107.244.48]) by imf22.hostedemail.com (Postfix) with ESMTP id 2A84BC000A for ; Fri, 12 Apr 2024 01:38:12 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=d3QHJp9A; spf=pass (imf22.hostedemail.com: domain of apopple@nvidia.com designates 40.107.244.48 as permitted sender) smtp.mailfrom=apopple@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712885893; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KSbUVGPtf+v3LW6pTQEiRVRGmx/VBwb2GU1vmTvfrt4=; b=hdjMF5JO/yfU2CF854GMXOEQnUq8TWEPJdYS78yEI5CSuDmYup9lI6wG39xssjjUMeh4ET KS+JqQzSiTs0gqGrRI9ECMLS22KiWwAOQZLqoEPN5nlq1v7LWjVgEZ42kYX9sD8xnIxXnw +EZCaTCKxFFTQmH8AHgofyQbiATJNI8= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712885893; a=rsa-sha256; cv=pass; b=Ugulr/IUIgHeJHoTsx6oVpk1iVnLAbfi40YYgSrvumEA4FzhGo70Hdspdg6dH89cTtiwvn CXfUZM9fI9juLqnYcziX8kwTtf/6333n3UhaaNpl/w2lb7ueaTtK+fN8VMP7UndIhM2wID n4yzyMUw2jtiqeHfwV9L3RjyQRAqHfI= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=d3QHJp9A; spf=pass (imf22.hostedemail.com: domain of apopple@nvidia.com designates 40.107.244.48 as permitted sender) smtp.mailfrom=apopple@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SaD1DsdU0kSKsnboVYLyzBYJ44krKHyrQ4K17O83MerqL9amy0N8SWy/wfj1YhzyidEHx7zQnMCLkFG3B4tIO5EmcbHmKWTOJWDk+GxVtiTW+dbp7BcTM4VnvyCEiOYtfoKKnCy5hPcWMf74unVV0ZnY7sDWzktNPBVxH+CNditb6//U4HdBa1D5jjANo5HL/j3oVBxs/gxr/B1JvFSA2Ib2N3YvL/tgxTi8i99fFg5Wtl+En7boMH1MVkHckPc4fBVSDsX3UBNWmmBN0pKOFqwDU5W8XgP492gYEAGBg8yIY0R89t0PdBhaW6GSd3NK3iVcU51gt46ST7j7H6ev/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KSbUVGPtf+v3LW6pTQEiRVRGmx/VBwb2GU1vmTvfrt4=; b=ikI9SteXd76q5LFDTZO0wGlC2MwOoKn3b+0Botf1ccQRduz2qrfgPOjraRfD9FiImV6fEY6OhQiJMRlDAuotvhtBjGtrdi/mt9P7ktzB4JgSqj6GNZrzKiAf/xToBQBEeumfPSOfrL1O5dm8iw8wpGZIP+3bTemh8/c32E4ycNbsabK7i+2l4lOqSXTrpNafOUg9qIxGo9IKX5UvrtgOJTC684u0ZEbV0CCJMsKXoLa1YNgfSgDG+Y91dgYamGIFJ6aZAySz8AuhOZ52fNCkBiB8OnLF7taJcwQdNmjhBN0C/h9CGWNUUwNzPt/S1TmWMJBdxPdk6dOx+4OTqEQAew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KSbUVGPtf+v3LW6pTQEiRVRGmx/VBwb2GU1vmTvfrt4=; b=d3QHJp9AlN2IUO0LY4W/MWenThZ+IKW50tY0QJIO27U/lTg7Q1fEGoJFAmeACZCbW/bimE8Tb0WxfPXVi1mqWImubiuPV1CQjNb41AJRwmgWO0W9SrKlV41nl69G0kut8sOitxpn9O2bVwHkfzXbfbYeNZWr5/mVfjYR14K+DG14EUR/zlloUtYEf2RXf6a+d96MuZRzHu535HgK5HYu0zIJ/JEXhkvNatEGA0t0j3RpSxu/eFLcBm3JzNK1AEEh0xKTo2N8oQnmHF9ZNOLAi6qUXyVDPK6ZVyU80QGJ6nuJENhsegHcG56CI1YIKwaw3RTu7uRVXgRixCMiTkMRsA== Received: from CY8PR12MB7705.namprd12.prod.outlook.com (2603:10b6:930:84::9) by PH7PR12MB6540.namprd12.prod.outlook.com (2603:10b6:510:213::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 12 Apr 2024 01:38:06 +0000 Received: from CY8PR12MB7705.namprd12.prod.outlook.com ([fe80::e71d:1645:cee5:4d61]) by CY8PR12MB7705.namprd12.prod.outlook.com ([fe80::e71d:1645:cee5:4d61%7]) with mapi id 15.20.7409.042; Fri, 12 Apr 2024 01:38:06 +0000 References: User-agent: mu4e 1.10.8; emacs 29.1 From: Alistair Popple To: David Hildenbrand Cc: linux-mm@kvack.org, david@fromorbit.com, dan.j.williams@intel.com, jhubbard@nvidia.com, rcampbell@nvidia.com, willy@infradead.org, jgg@nvidia.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, djwong@kernel.org, hch@lst.de, ruansy.fnst@fujitsu.com, nvdimm@lists.linux.dev, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, jglisse@redhat.com Subject: Re: [RFC 01/10] mm/gup.c: Remove redundant check for PCI P2PDMA page Date: Fri, 12 Apr 2024 11:37:00 +1000 In-reply-to: Message-ID: <87o7af5pj9.fsf@nvdebian.thelocal> Content-Type: text/plain X-ClientProxiedBy: SY5P282CA0137.AUSP282.PROD.OUTLOOK.COM (2603:10c6:10:205::11) To CY8PR12MB7705.namprd12.prod.outlook.com (2603:10b6:930:84::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB7705:EE_|PH7PR12MB6540:EE_ X-MS-Office365-Filtering-Correlation-Id: be276bb0-b080-4d97-d11a-08dc5a913393 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ne6ef9eTTYt2LJ5x882KqDRzRtQespPhtt0+KBDJTeEfCe6H9+Bizq4QkSQt4YJhSzv4U8PaS4MM6tMV9uEiaSK62ZnjiXk6T/VUkHjIpTrmiTSJY0yYt1QzvrNuvpP+/XQEFtuj2Zzgb6FC8esLEVP46ld8fYhxWbJ910Rie7p1Zon0HLJuB3ryDf5q7LMAzoihoO9PSjW2JQO+GqzbRYImiYIrBS6oR12ZNTvtuW1Ykk1FfhqFe13/5JYEi/HlBEJJxUpMGmasiBcBSBBzCge7OPQmVDHSRJLHkvRrqyPbDEF7jbM4j0aFdDLJGN9JSQ7MTiCxH00aMjl7nKiLxz0jL8uAPqxfnNK7NEnsM+A+HDM757/2QXM7ufUHROnDVIJEI8kh5PgGlgrPBGx4bxsvKopXBhAlMqwPzQylWB0MqADXpBgvo3geHCNGEJYs3rneMZnoVvUsjQL2/OYU94dZm80A81SXI5xIGfo8xrSVanIZ/n8TRdLpDBX7klYRm2Zzja7DGHasqBS5JfldpC5wL1Dg/rtvoFxGIdPxFFT74cczKQ3LAO/FlIKdJCiOYM0RFr9Wb9wUIIcz8j7vfjN+mUnzxePsK8tX2e4970mk4VDWfpSIuN2dOfmNL9a40lltSaruR1/UF0E9jZdgHr0KyNX4oFnoWni+X+5steM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB7705.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(7416005)(376005)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fsn7AF266uxYvu1qAfJyt9RtMKELXxndqawXyXRW6KT4WH3yJ++syzPx+1Yd?= =?us-ascii?Q?QemYKfh6jlr/EJuzESL6PnUeJTl1RN9X2MB5OHjqUum2LYcDhZAwWYtHQVoW?= =?us-ascii?Q?AfUyBuvsBJGRVCsKrQdMTorvPj8dwanqyO/l7sxJ2h7j03YSZTUW884cTm8M?= =?us-ascii?Q?tVDLgcYDSoe9+j5/OG7YPSTwnvXmfw1Q96ZTGoJZ2PYmcTHYzEdIVRrlvW17?= =?us-ascii?Q?7q/gbc6BnMyYlp7n76bgkTonBx7DZs1O/E4B46pDxezd9UFxKepLu5dwv4Kw?= =?us-ascii?Q?Hg0qewWigc8IjZU+cqNsWMWWCfKmRy+7u8Gy9bn7j+HeVfCgRvZatkj+tKXO?= =?us-ascii?Q?BVwwnyhFZNhQrYREUYfaMFZs76Aj3jiOnpFBlPH5hrQiR80c499K7Se3hVwS?= =?us-ascii?Q?zhA/ISxVtv4DIbYbD/dn/P4bygL9NMkXRnQkBB70i0gdfhJrdFffy2i6uVdH?= =?us-ascii?Q?qyeY0bKZIP6ehTUaR4/q4ArV0B1I7ricIxCiLg8gF2nGBB1S8NvRdlLQGijg?= =?us-ascii?Q?y+G5a9aZD3QVnuG5cdxCZ/LBvjUo0f8nUk1K0gEeA4Ev/++A8+rIEks0to31?= =?us-ascii?Q?ux/uHTwDrovSaEAbvpqfgCHD4e+Plc3hYQXyZK/rvLeWUbkCgeDrGXP+7kBm?= =?us-ascii?Q?GKZYBw+6m/sLDFeIPbXCf5v8pWL94xWG3hRrxyRitGZlYp5DQXfHz7IN+Ugm?= =?us-ascii?Q?f0G8U+lj1abweI6CCrk6fcPcU8/ymZLzwe0wzMorUNCabZYgyUnWBwo3YZTg?= =?us-ascii?Q?f49qGd6pgBHIvj2WIPZuc4E96/SKtmfSlEnc0EZkLih087+gSqdvsZ5orabU?= =?us-ascii?Q?t5Ox0F1JeQRjgL693MDdGIZYD7pomhDMJI124Wb22i/WWAww3T3xwK1uD1y9?= =?us-ascii?Q?kz3b8qNGnQ/HtQJq1LqUUxFmODrnWT6bPV0o6fQARjTMILq6yxT5d3eMEri6?= =?us-ascii?Q?SUqYlmXN1O2MGko5XbqBZHO0Pgqq3wnsuk1K54qsIADPpm5k9V+bIz1TW0Gk?= =?us-ascii?Q?hQgPZabe810BQ5xSB7rmKYfylcF76OkUuu5qzfnXvku//sg9OAXIYwOxvbiT?= =?us-ascii?Q?KX0DUkcW4LKcebS7D3kCGN7+AFCfQ34mt5EYJ4lmSqdXvOgavASqa1rWSdh1?= =?us-ascii?Q?enVjHkgeh52QAiYBJgoOaSp9dQm6CBaI8UoDKwSioxIkTphX2bBnJ8zDCc2a?= =?us-ascii?Q?Kncy1aEubB4uhK8wO82qzCjQUBSmG9V+GxFN4ABK1HIZXiRoZf7zCqSQYfGn?= =?us-ascii?Q?7pgRgiIk9lKivPGdLoeM2apJQb3n44AArOulWcXXVHgjzIsf8+Ibdel6dC8J?= =?us-ascii?Q?PZoQOb7NmC3AnAFUAmtlO+fo2w96eCH6VQnJ89ljLvcebA3A3l8Cm2aRyhnS?= =?us-ascii?Q?Cy2EEy8sBRfACKVNT/+7j3kv/58gW7Sh0dlo3THVFBJZJFWclNAj2mqEUsMC?= =?us-ascii?Q?CzE4UbKviIxVaP942/OZSFumBmBqY4t/pOajmlxwdcN1Qx/XZtz3pgSOdXbi?= =?us-ascii?Q?KIUKZeFmZC6ljVsd5onaA2uoViwfgpR4D12Jw3QaN96913xWynGtOf4zFKKw?= =?us-ascii?Q?KRlIhVkYYB69Oa662Xki3/S9aCEFSFAJUF+mKpY0?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: be276bb0-b080-4d97-d11a-08dc5a913393 X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB7705.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 01:38:06.2831 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +dJkgw/QD/bMhPkoTLDnV+Q8EJwpwjM7/5NJp7GqrPGuVbRVmjaFL4wqPxBaONhUYuXlnOaYHpzezaaPug/EUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6540 X-Rspamd-Queue-Id: 2A84BC000A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 6z5js7h4ariqnxsa5437kyptq88z8d6q X-HE-Tag: 1712885892-1755 X-HE-Meta: U2FsdGVkX1+yet04Nyg64jLrIV8dZ0zHcdNOTr1PU/1+1wmVwsgbuyJfGQrUrn7WD6o3LBIZYEKy9V2UpRSrOjvzRkuHVAJ1mLyXPO+6z1kY2S5kML13KIVjFkk/hq48Plw0mB1aDlSAfNQsZ/LDowHtItk6QCIoRQz7mQG6Aac/qAT/7rC6b0J94DSPKdRtcdwst5iXE2Nat5Zfqeoo8hZvhcCa7ZXK+96VEWIeboG0Kxm//R96B/le91ekx5MAO+vVyw+AqKkTGOhMebMsrkvmfHY+7bpGmKBsmkO74ZIj3eJdEKdwYkyrwSHIyRV4IsBoloa0XN5l6/PVeBFHid0zpE1fVAS6dOufC4/Qrr0GAe/rQrPQn/iwtJGlQ0jKO/QZnmj2wk9mQfe/Tq1lcv4h1sLHGsAVqnk3AeCU3fBCRP5KgkxGKX5fPwPiTVf7LSE3Awgtm4SUcfYwmBmLEKIEF0GoBRFQgq3XFC30yLdA4ur8dLdUmPthIMNScSTL2AeyzRsxxNkJSc3CAPp4bBiu2o3r/gtCL5MMlNMDA2cpWiC1I2OIOGz36irfmI94mFBCTe/1ur7SDV6mMP34sGUDxIonBLjrqs7iLbiOs9UgjjzjD+lYiFqySfpnLFRgn7yaXzb9lArPI+GcRs/mpHBqtYzFKg/kvD9535rKTqhFtpZcGB7qza0bRz0YUXlxQhsVdEDRAIYyel+Omfj+4/mZU8T3W7moR2cXu/UB6MoA8T9fBL8+IxqWiJVX6Hp7ZtYcLeYH5wIpWdG1cOfS0tdsDYWY7U+xMpUH4fIafM4b6MEe3SORM2SE+Kk2edEN29deOsaGo77kOcp7LGqVYmXME7iNanD9qS77nQlf1oWG5mMclObCEtXd8hX1Y1JTjt9wUiPJFgy9b6pGK5cS00bNTfjC324ZicRXTFfLZ4lxaPK5l0d13qrvJ44zkj3HfPk2RIK9ZWuWHHtlV/Q tIxEeXhB Q2x7ScizkwVUfSER6rVhuQgZlLsWf6zyNCGQGC8Gy/Eb8IRYrWtxausUsOCtSUYa47Iqd7PlpiR4CDw1efDOGkmRpOqzkC7txKnXd8yNT9d+paup6fUiJ0RiXIHAo84xaregllZpv6/KUHjfZ1iGj9w74+Uc7CDLyh235wVp4uKeFGDk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Hildenbrand writes: > On 11.04.24 02:57, Alistair Popple wrote: >> PCI P2PDMA pages are not mapped with pXX_devmap PTEs therefore the >> check in __gup_device_huge() is redundant. Remove it >> Signed-off-by: Alistair Popple >> --- >> mm/gup.c | 5 ----- >> 1 file changed, 5 deletions(-) >> diff --git a/mm/gup.c b/mm/gup.c >> index 2f8a2d8..a9c8a09 100644 >> --- a/mm/gup.c >> +++ b/mm/gup.c >> @@ -2683,11 +2683,6 @@ static int __gup_device_huge(unsigned long pfn, unsigned long addr, >> break; >> } >> - if (!(flags & FOLL_PCI_P2PDMA) && >> is_pci_p2pdma_page(page)) { >> - undo_dev_pagemap(nr, nr_start, flags, pages); >> - break; >> - } >> - >> SetPageReferenced(page); >> pages[*nr] = page; >> if (unlikely(try_grab_page(page, flags))) { > > Rebasing on mm-unstable, you'll notice some minor conflicts, but > nothing earth shattering :) Thanks. Rebasing was the other thing I meant to add as a TODO in the cover letter :) > Acked-by: David Hildenbrand