From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48D0DC25B74 for ; Fri, 24 May 2024 06:52:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAE746B0083; Fri, 24 May 2024 02:52:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B38246B0088; Fri, 24 May 2024 02:52:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D88D6B0089; Fri, 24 May 2024 02:52:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 76DB26B0083 for ; Fri, 24 May 2024 02:52:58 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2E9F81A094A for ; Fri, 24 May 2024 06:52:58 +0000 (UTC) X-FDA: 82152372036.09.F663891 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf15.hostedemail.com (Postfix) with ESMTP id 7C13EA0012 for ; Fri, 24 May 2024 06:52:56 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SbrEzilY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716533576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references:dkim-signature; bh=ykVoCzYAXxgYfsHCRKZ4/jVPW0FI1w87SrBVTf97eqM=; b=2qIBT+FndbI3VIU4YPvNOn2twacKDSbeWcEClK0bF1K3rkCc/rFNYXGsfxm09UMJU4XJa0 ZVqShK2BspIBkB7W5Q9nTxfpZbkfnlXBkCoX/t3TzUT3uXVnHDDJ6N39/+th6kGZwL79Vx 6ZAraeN+rNgyd4QM51LmFBbTBzJwm74= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SbrEzilY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of ritesh.list@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=ritesh.list@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716533576; a=rsa-sha256; cv=none; b=iMwagC3qGNYkIM5QC+Kb+0uvw7PgTcT6PpNtRhV/0+Bw3Bqi+blgnnTlExaGjhBQhNVXbb NToo+KR7WZTnH9jGxuaD9ieqXZep0A8WuDMFMh0g6StRiy4udxB2x8O1Jh4su0ej2lWpJk P7lJdaOLaut6tJUCcq8wubeR/8OksIE= Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6f8e859eb20so535284b3a.0 for ; Thu, 23 May 2024 23:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716533575; x=1717138375; darn=kvack.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=ykVoCzYAXxgYfsHCRKZ4/jVPW0FI1w87SrBVTf97eqM=; b=SbrEzilYCQJONP/hY1cXGQpUlvwLB3Sv5GHRqOliF4Db5v/s0ueOHAtLQJijJ0y5Rw Dxcp6zqrca1rkIyzInGrvxECLVUUjxWiU4NMDK/X5GNhyMNmDOSJ55wolU3nXaMYfwnN nsdbNzcWi5GNM/Mf5gHWN9BJjg0S0hYE/VQTnzjR/Mff2anMTnEGGwkgE1hR5ku3WAGq xKT215u07XDY1wcsuuoSaHBw5+8JkoZhQzTShEJiyy7KHcP/8gdYo0ISYk+3jMG8H8Rs L/0q4dOJK8Qjp/XCGqB6G7jSiAFDFFDuuB1QiqsqVVB/mGquGrM37U2IRz18qpeSK9nx wSlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716533575; x=1717138375; h=references:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ykVoCzYAXxgYfsHCRKZ4/jVPW0FI1w87SrBVTf97eqM=; b=iyYIiZt7PFkoFJcgsJYfIBAmeUJiyibZtfk7VrHaOPTw5pW25kuwiE722M5QYkb7Vs UDzd6N64NyHX8qcEpOv4pn7Om3g2lUAq0uETXzbSHVWTh5oqg/lkQ/ptAP3IHw/RLCcH BW6BJNMC9LZ6JSmIovNJy75Z6yk9UH5i4pMslwRKg0VY2Llcj9PttLnbP855EL5iLRfC 4Lb2aIFJ5d7cUsKfl90jZRrRK44s5TcowzxLX2h3KG1C2ePUYJpArga31qzeXLTwJxNj QZMGui8zIBFkMdNSFc6631Si7X1kyCwbS1mXyLehxhYYHL2mPUNid1FrByjJxq/I+0pW QW4w== X-Forwarded-Encrypted: i=1; AJvYcCVELFeODtvPOk0b1D4nfVMu21Q/XCmOpXLqysKImKTf4WAjPNnM5IZgN4bbEWOEMb+G2r4gHVp8Z4mTBSZLZc/3sus= X-Gm-Message-State: AOJu0Ywr9voyKIfWoJl0GErTqrnEKoeO66bD86VxaNJTVhzaeQdGA8HG 2sy37cI+iSWzCIAWh6UTkN0AMngeOrJQYRPzuJvQ+QROOw6/Ae7g X-Google-Smtp-Source: AGHT+IFeHmKmJv50+uxoFGpkU0wNY7hJ3X7HEEhI+59tWnSNxwwR2DeReAt6XXA5R0PCcd9vrR99RA== X-Received: by 2002:a05:6a00:418a:b0:6ea:df6a:39e7 with SMTP id d2e1a72fcca58-6f8f2d7247cmr1513112b3a.13.1716533575418; Thu, 23 May 2024 23:52:55 -0700 (PDT) Received: from dw-tp ([129.41.58.7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f8fc053bd6sm582396b3a.45.2024.05.23.23.52.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 23:52:54 -0700 (PDT) From: Ritesh Harjani (IBM) To: David Hildenbrand , Andrew Morton Cc: Donet Tom , Shuah Khan , Matthew Wilcox , Tony Battersby , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Rapoport , Muchun Song Subject: Re: [PATCH] selftest: mm: Test if hugepage does not get leaked during __bio_release_pages() In-Reply-To: <7792c8ba-39e6-47ee-9b43-108270325c15@redhat.com> Date: Fri, 24 May 2024 12:13:04 +0530 Message-ID: <87o78vsoav.fsf@gmail.com> References: <20240523063905.3173-1-donettom@linux.ibm.com> <20240523121344.6a67a109e0af2ba70973b34b@linux-foundation.org> <20240523195734.bc03a8822a34b1a97880fb65@linux-foundation.org> <7792c8ba-39e6-47ee-9b43-108270325c15@redhat.com> X-Rspamd-Queue-Id: 7C13EA0012 X-Stat-Signature: mjhpttd15tjfgn7r331s8djbgwj3qwdo X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1716533576-101758 X-HE-Meta: U2FsdGVkX19vs6PiRUUzmUgCzeuCLkt7kNV8WkREbqXogQMlSKiny/yYmFpLBCHOnxqeD4FDAeFNKZ7SJRuZvEjGD27pdcks/FXPkUJetm4P1GoKl6jtTFzQG4631OOdT1QagcwFee9DselbTBrEzgewvxREzovoHGjN8/vt5GTdeIO2fx+CFnc6i04a7LqDQU3dGzO3PpbNfUcrRITvTYFErxrE7yHHmDsKK8J0ZMmNm+wG1VMkBZ37oBMRFBLEaCwLvFscLVMYAol6ICK2G277Q/1UShVm/r/yBxiPwoo4UHz+n0tino9qz3pV4sNXiut6CwjUgHjJ83a86ZoLWhZpXGj716Yci3LyuA0x6bj7c0XlnYeTGHz2Ayxe/ViAp1qasu0jM7m4yeyS5zIIpVcGFB+r2+CeNCBl2GMHtT0GgTpAgJaiRhr2lxqyhsiUaLpsBJ6MuLN50dI7czsbxnZ4AARIxzBXJGjJm1dNY15FWHBlw7pwtykOBH2zJg0zW1e8nEf2xiZV9uIFLPi/oOBhHnD1ztykErs1jc7vfQJPFZ4z2/mXGnbanfJlhPbinxf621OPJv/XqknU9yEFsoVAeAXQCdDF9cSdTXdQiOIzYTNMB9Pm4gEUWI6P8y8Y7WAocKltFqhU87CXdr9ZvK/8i93UQcas2ce/xnOqQeym5DZ1xJqHe2RE2Sh2mdUESg1jybU4xp4tWfaLNXwyx3NmgOWrgQdH9LapHU5rTWVOsItpTZ8QBbq1DFlF4MAebvy3N7ZKW9Lci7BqYayFsszfcl0nvzTBuI6bl244RgV7eXoyUdK+gWku3HUacviAmpGL7F8+JeemzFC0Nb3CXuFM5no9lpIBzeA+gFbdINTC0pgIvXYb+L2z/v5FQ2vB1Ydv3tplCDklJHdBmlPglw/Z93xUAzdwKnxXzNXH/0rWM7dBYmDrNsnEGx2X1N2T5FYqW1z2AIVeDKx88B5 0wPM0sZq oiyj5jkKmyKqbDdWurdFB/vJTQruuRxgGiXZOnN+tM3JCtk8MU4fyYnSo/0M2kGYiLWtt0xoCkCzvuRh5nWLPoTyWRrRJHLILx6DTyJ5vmBIGEVl2Jq2IIBd3EGmfNd3iOY8DnETGhKOYvzL1nqoxZy/n1TgG7PiAZ2GPMzXINPFsJE1paPt6ysCFjCkBVT+qKKmGjxuOBmS6qaR1k/BjxrQeVQYS4l9Z2L98PAUiNbtS0xffY33vVhaYWj/+DrEAvliRhglT/BUA8NhyIpqqd5BqHJQpeBxnKqI2WbMiaTXKgpC3UF4TNSpmWBL2u+TENyPk+d4VBfLdC7H2mYRYrlwM3EHB70VR2WPKS6Y/rujMi2nGw1xiW/klMQkJl9fvkC4/xZ2SYkkLuaMnvibTuM9Q1AbZxv5dH6g3ITjEsPzGobXnzssq+5ezIaWN3GteP+uSrNrSFqMMvLFFpuYT8a6WUqsP9pV7Qp5GnAqNJbxwkufr9VQ3xQQ/UgZvdvQsGPjUdIpwCeCrAcc3prwEGd5ERDm3Wg0bNsenV/vwIqE0NgJmXkUgypIoGaTfW0i2vKg/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Hildenbrand writes: dropping stable@vger.kernel.org > On 24.05.24 04:57, Andrew Morton wrote: >> On Thu, 23 May 2024 22:40:25 +0200 David Hildenbrand wrote: >> >>>> You have stable@vger.kernel.org in the mail headers, so I assume you're >>>> proposing this for backporting. When doing this, please include >>>> >>>> Cc: >>>> >>>> in the changelog footers and also include a Fixes: target. I'm >>>> assuming the suitable Fixes: target for this patch is 38b43539d64b? >>> >>> This adds a new selfest to make sure what was fixed (and backported to >>> stable) remains fixed. >> >> Sure. But we should provide -stable maintainers guidance for "how far >> back to go". There isn't much point in backporting this into kernels >> where it's known to fail! > > I'm probably missing something important. > > 1) It's a test that does not fall into the common stable kernels > categories (see Documentation/process/stable-kernel-rules.rst). > > 2) If it fails in a kernel *it achieved its goal* of highlighting that > something serious is broken. > >> >> I'm still thinking that we want this in kernels which have 38b43539d64b? > > To hide that the other kernels are seriously broken and miss that fix? > > Really (1) this shouldn't be backported. I'm not even sure it should be > a selftest (sounds more like a reproducer that we usually attach to > commits, but that's too late). And if people care about backporting it, > (2) you really want this test to succeed everywhere. Especially also to > find kernels *without* 38b43539d64b Sorry about the noise and cc'd to stable. I believe we don't need to backport this test. The idea of adding a selftests was "also" to catch any future bugs like this. I am unaware of any functional test suite where we could add such tests like how filesystems have fstests. Hence the ideas was to add this in selftests. So this begs the question which I also asked few people at LSFMM, Does mm has any mmfvt (mm functional verification tests)? Should we have something like this? Was it tried in past? (Sorry, mmtests name is already taken - "MMTests is a configurable test suite that runs performance tests against arbitrary workloads.") -ritesh > > -- > Cheers, > > David / dhildenb