From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 647EDE77183 for ; Wed, 11 Dec 2024 07:45:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3A576B0284; Wed, 11 Dec 2024 02:45:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC38B6B0285; Wed, 11 Dec 2024 02:45:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEDFE6B0286; Wed, 11 Dec 2024 02:45:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9C80C6B0284 for ; Wed, 11 Dec 2024 02:45:47 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2D9AE1A0646 for ; Wed, 11 Dec 2024 07:45:47 +0000 (UTC) X-FDA: 82881893472.16.4787F92 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf18.hostedemail.com (Postfix) with ESMTP id 338351C0016 for ; Wed, 11 Dec 2024 07:45:35 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZaN44Yyj; spf=pass (imf18.hostedemail.com: domain of kvalo@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kvalo@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733903134; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RNMFGkjaVVePSgh7GtbXoA+T3WPlMdrO90sFFhilL3E=; b=d/bD+ZrlddlggiM4ujICKB3NHlGkoRO77/cgQf8/MeZyzeesK0pbdzDjK4K1B2GgHByUYg XZbQM38fxqEHLDEi6H1zcoI+1e7bIOQVIaJZoIxkW+kLRxtu/ejFs9JT1nEVB7i4LzlnlX IV5c4PNgOWwnHloweFqlv8sgWB2ZaUo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733903134; a=rsa-sha256; cv=none; b=oaAjeGEP2COlDID0wz9RxZ8Flnb5VLhK8Br6AlRnwiqGAuerkkWOX/bya9tL6kUzExNrmg nNUBArib+C6OyHBuAubTgR3DTicMnmoIK/3+zs84zWL7T9/lPf+522CEuTeuRQIMuiJGWU ZhC0Q1sU+GSwICGbgg9Fjvw04N3xbiQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZaN44Yyj; spf=pass (imf18.hostedemail.com: domain of kvalo@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kvalo@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7D050A41F20; Wed, 11 Dec 2024 07:43:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8A77C4CED2; Wed, 11 Dec 2024 07:45:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733903143; bh=KM5Of7mM53fIwBBiaYiiUQ9BfxtVrpykBzubAzmUdlE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZaN44YyjhRMRn1ZZ+GmTOS40UgIRbhL4wBsfJy8XjSPG4QXarlwE2h8LLmlSyCwwE mhsyVMxQDuDVaxW28PxQeU8er7lMNhKnh1DPb1k4CbIDr8a5tkumkBV/uTN9xwnFYp h1HNwJmQE+rv8LC4BNlfDvTcPd5XXQGZmdVG4PmZqn4aLOwa4oWj50GSY3CEXVAf2K 4s9JO62HtV4AyzHzBTTKIyxerUXbJDme/tcsfk9nrdzoiXAN6SWU/JWU3UcTsBRxgt rxzg89ETMye2AN+BOVUz+OAR29EzCnQNdPIoMqWIY7xMbpGfvp3pWcUv4qGp3pyh75 7MY47GTKlC4gQ== From: Kalle Valo To: Easwar Hariharan Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , Thomas =?utf-8?Q?Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Roger Pau =?utf-8?Q?Monn=C3=A9?= , Jens Axboe , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen , Jeff Johnson Subject: Re: [PATCH v3 14/19] wifi: ath11k: Convert timeouts to secs_to_jiffies() References: <20241210-converge-secs-to-jiffies-v3-0-ddfefd7e9f2a@linux.microsoft.com> <20241210-converge-secs-to-jiffies-v3-14-ddfefd7e9f2a@linux.microsoft.com> <87sequr7ho.fsf@kernel.org> Date: Wed, 11 Dec 2024 09:45:24 +0200 In-Reply-To: <87sequr7ho.fsf@kernel.org> (Kalle Valo's message of "Wed, 11 Dec 2024 09:42:11 +0200") Message-ID: <87o71ir7cb.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 338351C0016 X-Stat-Signature: eqqibj19a61nxg9fg1d7tzrgd8gmhgzz X-Rspam-User: X-HE-Tag: 1733903135-137555 X-HE-Meta: U2FsdGVkX1/O4ttigncZmkbbXupnDCo21y2K7R5lUInNFxJykFicItpZEPVdO84IW+D+EjLT6HK5JVH3Klwy36g6qgcJaFZSvFYjNMmD48/JtjfH1XHSKP59brNT+Zg7jNY7qtvaDcSXfuSRuiO7o5X/eT0KUmZQjXVmvaeymZbyOl+h3nNTURmvAwtq+rLrCKOi7FradxjSMK75eYyqzDjCryhtE08Ki8TINpcqYXona/EtMWCzqduDY2nvXkVMeo4Frh09Ds8FLM287uad/J3AfCErCTZkUs+UlxoVr3pvWn7aMGD9ed0f53KPhiJpQmA19ftigYpHPpJGWVOs9kL0m6SkFWUJE3Nc1Kt0ibDw2PdABAOIgxyhqJIzNPN6nGSEtBmsRhQTwHRw0FqNqjm1SUVJ2iJNNaGXURb9x7w2IDXin8WJc+/EESpNv0nrNrMHkwwze+K/8WI/xWaFMBO+2KKShjz1kf3E2unmfPfKyrrwjg6dyDsFr+VBept6I3HeGtHmfv0Ti2cp5Z4MeHBUwyEQi7PmdB/jXnRJZ2R9z1aKULKMaMuio72zmAs4nVul8MPWEChlJkAVq1ua4pEx8JgYBiya0EJjJ4FRmnq3jBvWaCXWvsSP+p7BSpGtb7yjv+btuulV3tilV4MtpeugGBBukfwGYb/B+DoQdorB3CocPyouowJOhQY2bFySzXou7VWRE+sgcWps3DjzEkBbyQfWS8Asq6TXh4njffHLqeMKIBqD0e7jGHfgAWuRn+tssEP+qBYv3mWLYuB1TDzm/ZH9B9iYwt72vOYCAsK0dcw2vijzhZMBLuS4hHBkA8dG9sd+DTKmkRHQU+ffqHzojlnDUbAoAiw8cejERODE7EyNd4rkUSIPSBrMTxMo0fmoaodxthf2ioLJgSB/o3LiJ9ws6xgPVH8MIttVhdwFYqfhQyEvuyFC6SEvF4riIeA4a7y99lEWi+twpPi saetd/9L jJwkRsWQIqU76q+Ra0btjw/FtcaAEOAuVgoKLcSZDZtks+OfDXl67gjs7KQHVfMgZAqlkmqvs1rWjTn1RuVXyFgT3ru1KA1Oq0yYJHZ9WQbdZGAEk2gP/PTp9Vj9sDqrf5HJy1jARgAd0BRBoBtVx+qNIKVGvu7N+vLeF2jPYCCFxpptPpHvKMmlAOXjAOGf3h7TOS4MAmnpMr/FH8LU4pOqPpJa1uCvXoJS/r9wIFDUuXdeeIwKUMQzmFEyPeKIFql9he9LUHbyATuKtZN4GTFdo5W2q9RSaEamPRuRQUk5CQE1qQ6eh9J+NDw3p3y8H730EKPUCGm5623P5l3D/VdsbqH+Jr4ihcaX4QJAPKkPpiGBD+i6VZAKwcnn4JxrDEMuF8I4frIlF4K1zKh75z6yyrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Kalle Valo writes: > Easwar Hariharan writes: > >> Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced >> secs_to_jiffies(). As the value here is a multiple of 1000, use >> secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. >> >> This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with >> the following Coccinelle rules: >> >> @@ constant C; @@ >> >> - msecs_to_jiffies(C * 1000) >> + secs_to_jiffies(C) >> >> @@ constant C; @@ >> >> - msecs_to_jiffies(C * MSEC_PER_SEC) >> + secs_to_jiffies(C) >> >> Acked-by: Jeff Johnson >> Signed-off-by: Easwar Hariharan >> --- >> drivers/net/wireless/ath/ath11k/debugfs.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > I assume we can take this to our ath.git tree, please let us know if > that's not the case. Nevermind, I now saw the discussion in the cover letter and assume that this patch will be sent separately. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches