From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C185FC02182 for ; Mon, 20 Jan 2025 13:59:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CECC280005; Mon, 20 Jan 2025 08:59:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 57EF5280002; Mon, 20 Jan 2025 08:59:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 446EC280005; Mon, 20 Jan 2025 08:59:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 204A8280002 for ; Mon, 20 Jan 2025 08:59:03 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D1743ADA0D for ; Mon, 20 Jan 2025 13:59:02 +0000 (UTC) X-FDA: 83027986524.20.D9076B6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 3BD072000D for ; Mon, 20 Jan 2025 13:59:01 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jbNOUxZE; spf=pass (imf03.hostedemail.com: domain of a.hindborg@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=a.hindborg@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737381541; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Igv7LN2+tORLsqtcsQU61uzv3Ya8nttmV+0Uzj1G/2g=; b=EN/dsQz0yW6QNfeiTzfunWdCtxqZrOHeV0bUJA4r926nHcjRLuiqA4cdwIAt2JkZf0lk46 PIxeH9nBaIOVOUmWjc3ZAtc41bZLaTDJM+pIw7s51SQoKhloWoxlG0Xom2FfSKXQan9poi FylAVv/kTj98Bt/UMicfGXtHxjwcf4c= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jbNOUxZE; spf=pass (imf03.hostedemail.com: domain of a.hindborg@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=a.hindborg@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737381541; a=rsa-sha256; cv=none; b=m3MhD9x3451JJM8bPgHwOuLlb0nr+Svpk1Njzu+35mSSloYAn6fD/FPSegH6sMADGuF3VE dBykEiON9ysf02xwMuw0v/YLeFQYmsAcKByt8BHjdJmP6K9+sTYYLuwTmFpYCsEL3fl9Mr eohvuicw25pFzTT6KC3oNSgr2Yz+VZU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7EDC95C5B0D; Mon, 20 Jan 2025 13:58:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEF77C4CEDD; Mon, 20 Jan 2025 13:58:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737381539; bh=Igv7LN2+tORLsqtcsQU61uzv3Ya8nttmV+0Uzj1G/2g=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=jbNOUxZEFF1OuBhzwnnafsAXLIZvFeGgeujAR/aBp7/Kf184cH6Oa6O9LhQcXSbkx XScRKzAxr47yqeVSFeKX9XTowoCLetIXF6A1ax4DJQLVnjTjy67b2XwbYq9g97/J6R SI3+N7mnDaAl0CgvPilylyrTn7pUwPPGUs0tZMRh+G15NICA3N0xEd4h9HspDPWSm8 LP+qBRyGFNLjTuseAgykq8ji1v4N7yPVKkH73jur0hmcMMpjeWVcYaKvk/11QPhE+c viKHIPOoT0AEyw946TF9uef9PgIwbscfOHywmvagLOiyDpTRcRVtWgFGTz8/Ijepf3 czllVQiNv7iJA== From: Andreas Hindborg To: "Alice Ryhl" Cc: "Miguel Ojeda" , "Matthew Wilcox" , "Lorenzo Stoakes" , "Vlastimil Babka" , "John Hubbard" , "Liam R. Howlett" , "Andrew Morton" , "Greg Kroah-Hartman" , "Arnd Bergmann" , "Jann Horn" , "Suren Baghdasaryan" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , =?utf-8?Q?Bj?= =?utf-8?Q?=C3=B6rn?= Roy Baron , "Benno Lossin" , "Trevor Gross" , , , Subject: Re: [PATCH v12 6/8] mm: rust: add VmAreaNew for f_ops->mmap() In-Reply-To: <20250115-vma-v12-6-375099ae017a@google.com> (Alice Ryhl's message of "Wed, 15 Jan 2025 13:35:09 +0000") References: <20250115-vma-v12-0-375099ae017a@google.com> <20250115-vma-v12-6-375099ae017a@google.com> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Mon, 20 Jan 2025 14:00:02 +0100 Message-ID: <87o701d4j1.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 3BD072000D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: u41gw3t4hiznogxt79dqih6jbgmjrhzy X-HE-Tag: 1737381541-267173 X-HE-Meta: U2FsdGVkX19fF6i6OFdqeWlEMNC63t4J/K+2DXaJItO/7qYmlrIwTb1H5bQOhmoIowR9WZJFFT1urIbmRhiyk9Ln8JIsqg7p8OXwOaVbdiNu1fG2Za+aWmUAQRzOp4Lc07lRHqnhvu9XiehpIOPCMMZe3hEgcjjjtVcqtNEkwaXoYVKpbPOJY8R8dgqsUMO5ndjDp6F4X2j+pfOeXKc9MDIUK4Q+fd5AfRv7q7y325iaWMugQLdN5x+UwRJEEV/srJMmbOiS9Xi8fYvmXOrDeLsajceTbQ0b/a+sZU1N5Ern0d29hImxOw1wod+j/nVn9fa13srDL+hrYCqy2yP6urEGjF3WGCRJ/+/ilLRZ9pMz1dIRRpJ7RmxUhehjo2F83gIaSAa7sJyfEOrrp8gHi6t1q0sgjRmDeZqaCENn2KQdkqM/xfcHBknMDJ7Lnz3Vi09GilKT9RSPLJP9sENOigKD2gnLpsP3R4fRhPPg7jY8B3hovHg1mfeFeTXfK+WCFIt5rgca/V2mGvIdkq//N/9plalPcfzXMUMxleDAO0U47EouQmlkgIXT38MFBRReKWKnfea1JDIaWhZB+OMTGhTAX1IRkidfFrj1NDmgTaDr2lx8GvLHd4PiOxDyV6UPeAPK7YqT4i2L+PGrYOsR2plcKwPqmvqebeh2pRByPA9nt10vu9I/RQ9IuQo4x24qKXNXBTSWKYBCHc6ZOiWK5KJUFtRv4ARDMYAqiG7lyt3IpZ1BjXhiKpLwlU0m3Z4Som+GNKbedphvoWCEQwdBdndSIKIcaD5ZBBt7BTgOlGgwTF2YrUhBJmvAIKYh4Dm9wVjGILyj5BVZXW2fRNdisw24DAygWEM4+Fr089iNb+HApzB9JkrYdkiflgGRRFnBdJnqgeCARoAKeCcfEDtOBu6ybxJOnuVJLcIBwzR2HRUkXmFwfi8bnJ9YLmn2sHFPmgcjqq137V9hCQEFG7m gB8ubDud 1Cudb3dKt/XJxMcLeVNSS6xMqeGs6Fbxw6R26huykU7M93NB+1q9pkpS2dsLVEu7wzqrCiD7SfU0cI5LoMbUuY9IhSj8M1OohtJivE2B7z2FNHBqiNZs5AfWnQF8GiNXf/FlnyEuE0EtxS62CsjGemhzEKkzHDCAWd/srQBzvRTj6DNzYg763bAnVaB95cCTTtw/IJDRPWzEGEdkL9aZAb06kZFmiSKSHOoc1Wufcepn2PJVD0lyjrgWgldtb+l3ni9yxKZS5dk+yZPY6iMqeXtT1e74ivLDSLaBqE49HWEs4iBKC1xfCDMB4QaXwmp/YJtufwA8X1SOiVifSHrgQX9lQ0weLswuEh1XwhlX5qRx5jsE= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.491796, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: "Alice Ryhl" writes: > This type will be used when setting up a new vma in an f_ops->mmap() > hook. Using a separate type from VmAreaRef allows us to have a separate > set of operations that you are only able to use during the mmap() hook. > For example, the VM_MIXEDMAP flag must not be changed after the initial > setup that happens during the f_ops->mmap() hook. > > To avoid setting invalid flag values, the methods for clearing > VM_MAYWRITE and similar involve a check of VM_WRITE, and return an error > if VM_WRITE is set. Trying to use `try_clear_maywrite` without checking > the return value results in a compilation error because the `Result` > type is marked #[must_use]. > > For now, there's only a method for VM_MIXEDMAP and not VM_PFNMAP. When > we add a VM_PFNMAP method, we will need some way to prevent you from > setting both VM_MIXEDMAP and VM_PFNMAP on the same vma. > > Acked-by: Lorenzo Stoakes (for mm bits) > Reviewed-by: Jann Horn > Signed-off-by: Alice Ryhl Reviewed-by: Andreas Hindborg Best regards, Andreas Hindborg