From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02B91C28B30 for ; Thu, 20 Mar 2025 14:34:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10D4F280004; Thu, 20 Mar 2025 10:34:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 099A4280001; Thu, 20 Mar 2025 10:34:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5339280004; Thu, 20 Mar 2025 10:34:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C4F60280001 for ; Thu, 20 Mar 2025 10:34:17 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B7ED7120FF5 for ; Thu, 20 Mar 2025 14:34:17 +0000 (UTC) X-FDA: 83242174554.20.FA75A96 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id BAF5B1C0020 for ; Thu, 20 Mar 2025 14:34:13 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gH1zWQJU; spf=pass (imf21.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742481255; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7iLhCsEgmriA0Arg3aT+EM1OvQ9q5N2Kzwt92zewZ6E=; b=Pz3gira4NYQZFupBCCfCDOgUULHEdI+ow0blp0k8Hbkul47mtbMP53PwqVoqKo7Xxf5kUb M0GwVEV1/WaltDuPh31OOOUnpDWaQYauw0IvmP6r/U3KU76fDYK+obp3d5bvRCH9DZN4NX TE3EgMP1gMFRfLPJgST71nUcwh4PJcM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gH1zWQJU; spf=pass (imf21.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742481255; a=rsa-sha256; cv=none; b=zZ/41vTn/LpkEPlZkDWdPaphEGV6qCCIEgSD79x00rr1hqnQ18COzC3s2aT86ESIUHuH13 zKZm0wLmCflT0sYFNpa64yTxfYV2iW3D8qEwXxHu0uRUL3BRYvzzqAm/+IT7Z1xauyn4TP eKHE2Mr+unVsH8Jcg7mXjsZJ1ZenHLQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742481253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7iLhCsEgmriA0Arg3aT+EM1OvQ9q5N2Kzwt92zewZ6E=; b=gH1zWQJUYNYkTGHSqscKnKmynQl26G94EwCJNrZ4i6G3PvK1nQ/lN5JmAxLGJ5FZEWuLYI zCnPvElney/z/gkHB924F7TYZ0QeqiuWpYJGKjVFFdv6z1jaNTOEEibK2baFjlc3Ag1XPk 1KmGTrKy3KdyRZnVKgcgzxUE3QUR1Y8= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-524-d05d14hzNlKeCppZnpCXnw-1; Thu, 20 Mar 2025 10:34:11 -0400 X-MC-Unique: d05d14hzNlKeCppZnpCXnw-1 X-Mimecast-MFC-AGG-ID: d05d14hzNlKeCppZnpCXnw_1742481250 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-549971b3247so411628e87.2 for ; Thu, 20 Mar 2025 07:34:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742481250; x=1743086050; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aLsT93dSweyrf+qk2uXM1EK4iaVizTPbN4c8paMt31M=; b=NH3OwmzJmJVz71uZmqSZCvVSVMpc19YxzM5MLUSSVoKrbHeRB3gRevYyLe/Vl5n0uj S25MhINOLnnBewLgI+gx6YWYm413CCHwGmpxVObzaBVpbjiG7WJJrBnYQ6Dy05R7Emzz 0xCFEnHYCBCbzFqyON7zLgrj2nmCjvw8ncKT7LLfGnVPdc0Qs5u9BLf83LE865iMZmG/ X7J3nL/X+cG9tBfnNVEvgT55QFMHNxLlZ8TAItErI+DZPv98OX6CqpDs4iAxGYhrO5MG teNYAxr8/NBqm4Aj08gtbYYl5vBy438hCDxJlCAq3QxqZNiCqltCpjjjKDOl/h5Dg8r5 3iyw== X-Forwarded-Encrypted: i=1; AJvYcCUcBRxEKjvvfvVc9Hx7fp4QUW91v16NNdVAIKXuKny+KZEt/dRU9KCHbpbtkqkxpU1EikaRT9PhMg==@kvack.org X-Gm-Message-State: AOJu0Yy8f8baPCPRq+wX4U7fz3U/MXB+/if8M0MpHzirgBQ/8Y7ZYOVV W4a7PG64FrOkKg16HR/Ds9mG59D8EZCmAN8l0sz3nNpuAy99yNFvXBmGS59JmguTW+r8nKVfYSb KY/s1qytJ9b3TMaabU8I/Ud2MbgSunIk2xP/GYIbjdFjWo6f8 X-Gm-Gg: ASbGncs5N3yZBIRHTOE7JkjFgf+H6tFFDhkGjAspJFwVtDzX2katZvhPeiQsBu5Q1HZ nPzP5hYalnCxgOPnUqGU9S1/kHVrUlr76vAbuAe0LPNOcH6HAk4ByqR77c9eO06q0vkO6Q0+Qtc NSkLiDh6Jf4PHL9TpU3F6LcdsotVgCnSEGlrXeNzN06Kreof16czyCQ3d1CScMYnt4iUn5lT7pZ +zWK9RxEQtFJE6xo2LkVmaiBaPzDsDqiXea9gek98+xbuy3vrbZsf0u3+OvsnCvt46JW5EAAxB5 dcF0RrxqLci2 X-Received: by 2002:a05:6512:2392:b0:549:8e54:da9c with SMTP id 2adb3069b0e04-54ad0619d9cmr1163978e87.4.1742481249717; Thu, 20 Mar 2025 07:34:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFP5MKiRxkFgKG3EdSlhgqaV6W6DjuZ/y68FT+nnGB1qw2EVv6jr9Oog18ux0YhIZ7JDKVH0g== X-Received: by 2002:a05:6512:2392:b0:549:8e54:da9c with SMTP id 2adb3069b0e04-54ad0619d9cmr1163951e87.4.1742481249052; Thu, 20 Mar 2025 07:34:09 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-549ba8a9219sm2230109e87.249.2025.03.20.07.34.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Mar 2025 07:34:07 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 202DA18FC2E6; Thu, 20 Mar 2025 15:34:06 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Yunsheng Lin , Yunsheng Lin , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Pavel Begunkov , Matthew Wilcox , Robin Murphy , IOMMU , segoon@openwall.com, solar@openwall.com, kernel-hardening@lists.openwall.com Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, Qiuling Ren , Yuying Ma Subject: Re: [PATCH net-next 3/3] page_pool: Track DMA-mapped pages and unmap them when destroying the pool In-Reply-To: <7a604ae4-063f-48ff-a92f-014d1cf86adc@huawei.com> References: <20250314-page-pool-track-dma-v1-0-c212e57a74c2@redhat.com> <20250314-page-pool-track-dma-v1-3-c212e57a74c2@redhat.com> <87jz8nhelh.fsf@toke.dk> <7a76908d-5be2-43f1-a8e2-03b104165a29@huawei.com> <87wmcmhxdz.fsf@toke.dk> <87r02ti57p.fsf@toke.dk> <7a604ae4-063f-48ff-a92f-014d1cf86adc@huawei.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 20 Mar 2025 15:34:06 +0100 Message-ID: <87o6xvixep.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UeP5sfvUZo0nZOOfRU_UrYzvHoBZ_ftXsec7_by_i6w_1742481250 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: BAF5B1C0020 X-Rspamd-Server: rspam08 X-Stat-Signature: udbj9ik3a8k76zysmdfchohes3ap5u8p X-HE-Tag: 1742481253-825599 X-HE-Meta: U2FsdGVkX188Pl0x4g2MqX6Melv9r7l3pZf3ZBFdm4H87p0zdCu/57qXvn011NluX/KWnVCkJvEcVb3MfKW1ehoOufN2oxLP45sJBge4rSb49zoGgqYpYfOqPxfaGUlr1SptuHbMRqQ1nLjXyx2xI6SLi825rtm0PNDO5bOTd9sSwSLq3ho5qNeIPx+mXDZIjGNAPG0wLg4uWv9qHaWY6XZgZ0jubVqNjeYqi6k/3TEI9CSu/sDNJ9CRpXy9uSXvqhLdq2ZEU35uR9WmVFMH1mZgV72zoi5bT77SHCRuuD4M+ojmtyogc6TclG31pyNxJZKygbMwgrk6pLL9A/m/x9Svukn56lG9JVbKYXaFC/Z3L4ZsqH8thW0WUWcQSmDBWYqlCkgOxh3owo+/nKOJ36CGmt9UXH/t3949310t2i9s26Qn2i9u4fWl9XRIBYc5FLuHFG6NAK9U+9shczXECbraWN+8K97+xC6wmCCc2ULrtcyR9RLXyKWPTqq7OI1JUkZpaxfm0aruP5JDVPrwjtWRtSCK/xdZ8be3pgXswhS409SEdcwKD7/+YB8ge6Twls2jMP3q278lCkUtDiMEAgtILZ98VhKPmeD8NULgP9O4amgz+wywQwQ2z7Ssbo9Y2cNO0ePm1YfgbdQC0Eo13G0559NkzSJX0EBgO3IoBhmUIFdQAhowEs+IvUFMoDN68hYGOc98WUIRuedOU7FQE17u2WFA2JXsPJ2969/PxbpJKFQRrS3MoSl2lV17rZVwKFBkPCQGIeQaw4TBVfiySoMaMy0pohoIxutBSRIT+51q9OlF1GnwU7gfdBr0c752iRLbx3iXYfnXvC+MbLQTWzDOi+s8hdHZTTpqf0YsGVc+ZiAljryy3egkCixDtCpTOHw4A+ZXTzMmNbBVyvVQdUi4nk8+iM5ymEuzsJINaytOl3NhUe9oLmv8vLJY5b/VNJGwKG6RognI8Q/RGzJ KfqIghCN ZWh/uge5oKXNFMlGkmWsZOI2UmigQugSNT1Qby47qIk1oeWvJOmu3Zz1nKX+N3y6NX7R9r+NjFDz/kB1c0+y9liipqOyLqvlTN7vFTmOTh3eDVghHT1mKp80oAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Yunsheng Lin writes: > On 2025/3/19 20:18, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>> >>> All I asked is about moving PP_MAGIC_MASK macro into poison.h if you >>> still want to proceed with reusing the page->pp_magic as the masking an= d >>> the signature to be masked seems reasonable to be in the same file. >>=20 >> Hmm, my thinking was that this would be a lot of irrelevant stuff to put >> into poison.h, but I suppose we could do so if the mm folks don't object= :) > > The masking and the signature to be masked is correlated, I am not sure > what you meant by 'irrelevant stuff' here. Well, looking at it again, mostly the XA_LIMIT define, I guess. But I can just leave that in the PP header. > As you seemed to have understood most of my concern about reusing > page->pp_magic, I am not going to argue with you about the uncertainty > of security and complexity of different address layout for different > arches again. > > But I am still think it is not the way forward with the reusing of > page->pp_magic through doing some homework about the 'POISON_POINTER'. > If you still think my idea is complex and still want to proceed with > reusing the space of page->pp_magic, go ahead and let the maintainers > decide if it is worth the security risk and performance degradation. Yeah, thanks for taking the time to go through the implications. On balance, I still believe reusing the bits is a better solution, but it will of course ultimately be up to the maintainers to decide. I will post a v2 of this series with the adjustments we've discussed, and try to outline the tradeoffs and risks involved in the description, and then leave it to the maintainers to decide which approach they want to move forward with. -Toke