From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68CC2C369A1 for ; Wed, 9 Apr 2025 10:36:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45539280067; Wed, 9 Apr 2025 06:36:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 405B4280065; Wed, 9 Apr 2025 06:36:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A8D0280067; Wed, 9 Apr 2025 06:36:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 04CE2280065 for ; Wed, 9 Apr 2025 06:36:17 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5D857C034A for ; Wed, 9 Apr 2025 10:36:19 +0000 (UTC) X-FDA: 83314150878.14.404EC99 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 12887A0006 for ; Wed, 9 Apr 2025 10:36:16 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VLGMRZ9k; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744194977; a=rsa-sha256; cv=none; b=RtiUoeHyGbn6HtDLA2HVCuFgfKuNg2UPaVW3TN90oJH4x+YP6EaSzHNyIQ0DVBvii2hqdw xUoyi827yNJ7JK4hvCi00mviQl+9Mtlcs7fwSVaTtI3suuyB1Rq2AVA1triLVSP24ZHViS ffbCHS+qENKZpKOvChmOoJmBcNSySNE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VLGMRZ9k; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of toke@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=toke@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744194977; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gs6nkfLXhZyOmLN574OAGptS7++kcecAnr/SCctKWeo=; b=Z6EvHlhbMNo82ta5NkXxy237MRTWsbsZJEON+b/8Wu5zTTH40NSwPbJDwhcCxfc3OBVwaZ vTVMnhGpVQScT0vJ84pazR3Qc2pE5rM5P4eX7F8qy0dMrY9E6t4QC650p2nIMVveUB8tRS 2+nTeqrK5NP9tKRp0ZNUYPd5v+TxyKE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744194976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gs6nkfLXhZyOmLN574OAGptS7++kcecAnr/SCctKWeo=; b=VLGMRZ9kfOaucxjtuUbnal82+2/8i6EyqXAbDQaiC6c0Zuxr+21VVdr6BSVq8I0PiMj7b9 rY74umVQI3bsbHrSh5ZaomkNv26Oo2Epk4f/3dr9PQNEs+tNK7q0HjWFP89Aa/doXOI+dA DqOpSpSTU6VUIk5ko8BwYqgdBEQuEEE= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-48-kqm2FgoQO0ibEqvZ8oH8vg-1; Wed, 09 Apr 2025 06:36:15 -0400 X-MC-Unique: kqm2FgoQO0ibEqvZ8oH8vg-1 X-Mimecast-MFC-AGG-ID: kqm2FgoQO0ibEqvZ8oH8vg_1744194974 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-ac27f00a8a5so478230466b.3 for ; Wed, 09 Apr 2025 03:36:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744194974; x=1744799774; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+5kKiovjW0ZhkYwq0PKT65H3P9L8h+uzV491ftb4psU=; b=cev/IF7FnOy45ExFx2vKZHmYGcnkNypw5pwXr+Ffj5SSqPyA7rMJnDKeMBQRB34rw6 BxAM32/i786GHmok6nb7lvFD0NpPykYj0DrDBLNLJlbKNGESnWbFigma55CgYAffWsFg jQPQWnI3aM63R/z796QfbF4+TOqUOyCct2XLJzgHJeolNVmY/Df3gf0Zt6c3eG6HVipF 5sFr6oNkYVdqOE3wjnMEPgYBsOxiMkJZHF4VwrDKyFzDPgCZYDEfatb/rX7sUnbJi/Ez qam3IIID+U6GmDFzpTaWKNvgdjbdgFEGc7tchsKe/z+I5GGClPOZdSXsnPN+5qX8vPR9 hWJQ== X-Forwarded-Encrypted: i=1; AJvYcCVbt2O9SJOUmp+XUDfXlRMzhYsyZFV7P94qW78N+dq1k8XPeQq+Xgyo5v38ERae+rVTZPDzqNeZcg==@kvack.org X-Gm-Message-State: AOJu0YyoZz60kXiHBp9kA3l4LlX8yU8XNztLZVObMS2xeGwvqCVhiWDW VtK7BJT5XW+wk7ztUiebkrViDaCSK7hL0X/wo587Y24aD/IyAvKF4WpB3BOnX3kiakRoNQBOvEW 9TgdIVyAl0l9UGYM6A5zYGmSR00rugcosFxsV0Ew69qr7h3kD X-Gm-Gg: ASbGncu421tatTGRRbigPQmGvRlox0wOTuxnLqtVmxtLdlrFiBXJkdnP9Ai37OzkHpW ruqLC6XbGRi1HNPVITg4gkQl7/8COv9hlIiIzrxwbPSYIeslvduqX28JaFJB1exPvFqXL6eavV8 Dqz9R2uT4JBh0B+6HLCHsg2Fr1M4wkzfPzPPP22GGpsNSd/3DDKCXbuGvA6hFbG1cyIu4bR0lz5 9x46Cbz0NRQbJQTUGb8twtN0V1a6rtqtOERJt32iZxKjjMBiWaTt5CW3PCCNsWinxWodh9TtDhY w10q0h/O X-Received: by 2002:a17:907:7ea6:b0:ac2:dfcf:3e09 with SMTP id a640c23a62f3a-aca9b719b0cmr234860466b.43.1744194974085; Wed, 09 Apr 2025 03:36:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQCZRAFJMcL3NkxF41e8trgIRpTjzQOtQoBDKD5Ijj+qm+kAuHuUYYu1XdMXJhDmFnpSmJJA== X-Received: by 2002:a17:907:7ea6:b0:ac2:dfcf:3e09 with SMTP id a640c23a62f3a-aca9b719b0cmr234857166b.43.1744194973699; Wed, 09 Apr 2025 03:36:13 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1cb43b6sm74653666b.93.2025.04.09.03.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 03:36:13 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id DCF4B19920AD; Wed, 09 Apr 2025 12:36:11 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Jakub Kicinski Cc: "David S. Miller" , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH net-next v8 1/2] page_pool: Move pp_magic check into helper functions In-Reply-To: <20250408121352.6a2349a9@kernel.org> References: <20250407-page-pool-track-dma-v8-0-da9500d4ba21@redhat.com> <20250407-page-pool-track-dma-v8-1-da9500d4ba21@redhat.com> <20250408121352.6a2349a9@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 09 Apr 2025 12:36:11 +0200 Message-ID: <87o6x5vcys.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mXD6gEBmOGjjOdsNrFGPJMtGgupVdfVXIrKd2B8u688_1744194974 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 12887A0006 X-Stat-Signature: z35ggq4spsr1mx7qqmzap3oqkpagw3ny X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1744194976-528149 X-HE-Meta: U2FsdGVkX19AxPyfeccDA0S0f8r47Jk9C7xhvoQaiDKwOGbmsAFoTZDQ41MC2I14l9LLdElh800526+X5QcarGs3kju6aevb2nRVoS3nCmqP3O2YE6cinSPN89m8QAgzu3ZQkezySDo1C+8X1mUR1gnQKk5i535dddU8XR2zG9hqPkh5UzNuCjUpCXPphO7b+t319OETuHaxQ6b3Odw5bIezYiRDtiVWc0K7izOI3JFlbaN73xj8+X9KmTtGwy1wY0v/HqrYixm5jAwSYetjErKdNb3H2GtxKLvyLsL/nPKJfAOO/LXtqQURveTNWRkB5+chU4u052jo+DnhcQ+FkiKEijL2l89yGtWJmOEJ7zZFkf7G2nGlqzHpHP8ooKchCYPLYCW+z0MPt9FIr9Tti7xVO3K59Z9VgouFz94VG8FqS1M4wLqFb0Tjla+dll2Q1PeEBfKes6ryqWHBYE4NfsmVsIwU2njhEur8e4pl8bDpTuadWlupyfAqCRVegI3S5t1TOUM1ZaEdiOMEI/L6SZ0Todu5497J88lEJEdbJpFigaXyuzECWU/OPkMQWAV79gQGjqggrSC2v0f7l4O1OgJY/hJUUiOs0DcWC9nxh+fYm6mneEFVSp+7VgYlq7MGyioO+TcSzF2foU6EJ+irLtvpZTb4gqFAKPPeTuyqx9JXF83uXsx7MDfSpomyGnnGPjfMVI8eTvth3IMFSpLqNmN7C49x/cTrwY9jQDQmfkvY7URlg2CsfgBdegoCBY4Bi+aQdeGBrsOYji2tlJymMUT/KlsWZpf/AIX05DW73E9MZfLzZYFAMPvwJjdnJWfN/Srxp1kkANdEp/dnbxBbDCThefxYvRqRxBPA74jIX0h4uCSMqektk8GPwV8PyRb5AZ53hoXhGNaCegCEJmiyRr0av54YC2aPHu7ZrdFf6LI+Pn07pH2JRhsPz2/90B/LAhLJqIBOHFgB2wnZujo w9+132rf CKD4FMPKrCkhosMwP/AveTTrDPlkkVq8jpDkkUCEpLI3vVtW6GKDLWuGrEqi2oxdRQwIvSgRbkbQ4T+AGiju/SvMaqD+fEuTmWuhSdhrHBHYmztyvrjDI+23vU11xxxe1ZAUTo90hp60fblOYnf3O6KssLVDdXzDyZS3dQIgLeUQafHHvo2A2nJ7uJyMrmcD9RxvnAxhPzKa/mZm/5Tz9p0H9a5NZeFyxmqSP6Iu/yPQkCQCTCuTs/1yqIxAHa20b0wlUOykm31mc4zle0LmSCqtefaXLyavQQHikFauWleXyvc00YlRA393nSRsmvq1NCObOYnNhp6ZIE1itCiAn0v2/QtfdgTSfcgDrDFE/CErINlXOXYF7/JbkQd5uPPFo9pkIdoGVRuoNeYNBEXKyKT+A8BGV3P4VRVbp5iwfaGLZ2ENu2khBudqjy5C1bU2hHVnQoAnMVafglosFcrlIBs/0sXN6ihD7hR3lXzQQGR+Y9gQN1kZ5Dq3TkNjK5rCYaz4YMlOcaQ++nzReDq+DVIApm3zERNhGYEwI3PPMnEWXrZeN6F+EeZoEmm6s0dzI6AIfzrolibGRWNwgNmX7a/unbBJjoNcMpUF1NYKoxN19JQsm1gbbFvv8mZE10tQz6GfiB9z8TT2k6K4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Jakub Kicinski writes: > On Mon, 07 Apr 2025 18:53:28 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote= : >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index b7f13f087954bdccfe1e263d39a59bfd1d738ab6..6f9ef1634f75701ae0be146a= dd1ea2c11beb6e48 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -4248,4 +4248,25 @@ int arch_lock_shadow_stack_status(struct task_str= uct *t, unsigned long=20 > >> +static inline bool page_pool_page_is_pp(struct page *page) >> +{ >> +=09return false; >> +} >> +#endif >> + >> + > > extra empty line here > >> #endif /* _LINUX_MM_H */ >> diff --git a/include/net/page_pool/types.h b/include/net/page_pool/types= .h >> index 36eb57d73abc6cfc601e700ca08be20fb8281055..31e6c5c6724b1cffbf5ad253= 5b3eaee5dec54d9d 100644 >> --- a/include/net/page_pool/types.h >> +++ b/include/net/page_pool/types.h >> @@ -264,6 +264,7 @@ void page_pool_destroy(struct page_pool *pool); >> void page_pool_use_xdp_mem(struct page_pool *pool, void (*disconnect)(v= oid *), >> =09=09=09 const struct xdp_mem_info *mem); >> void page_pool_put_netmem_bulk(netmem_ref *data, u32 count); >> + > > and here Ugh, got sloppy when moving things around; sorry about that. Will respin. -Toke