From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D804C54FB3 for ; Mon, 26 May 2025 06:25:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F71D6B007B; Mon, 26 May 2025 02:25:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A87A6B0082; Mon, 26 May 2025 02:25:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BDD76B0083; Mon, 26 May 2025 02:25:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4ADF76B007B for ; Mon, 26 May 2025 02:25:57 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B7F871A033E for ; Mon, 26 May 2025 06:25:56 +0000 (UTC) X-FDA: 83484073512.03.DAC2D2A Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf06.hostedemail.com (Postfix) with ESMTP id 0B908180006 for ; Mon, 26 May 2025 06:25:52 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of lienze@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=lienze@kylinos.cn; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748240754; a=rsa-sha256; cv=none; b=3FOpbj1ganhdaXEPuQkuv1dQIwA43UJIMDT9UqmBuoMUrwii5d/iyk6UVc8K1LkLKBgQ0C NN+my2l20pluxDwoCaVnAbi4YfMpkWeHRKUHOq994DmzUUPbo6LqKhnrQnTljkM9bAV0iU bmqlmCJv3tCdjSqWlf0XQprYcSOrc/c= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of lienze@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=lienze@kylinos.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748240754; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ScvCYp63W1CGrJdYh5hrVdou+2Pl9OTUa3p0sZPqPaE=; b=ScLKwhy0BVxnSojI5cgdyTjiIO8TiupWsijkXEPu3yLKmgbSeGPj8tQRWLCbtahTD4NxR8 BtzYotKWzjzUPfLof3kAKy2s+9PinRWf233VhDE645qBnHP6zoVDrgV0496q3y6E+VPjAG rrtEESKn4FXyIhOf5LxLbjn/Vjhp03w= X-UUID: 40defaf639fa11f0b29709d653e92f7d-20250526 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:0ef67ac9-50ff-43d7-a514-de6e4e3b6474,IP:10, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-5 X-CID-INFO: VERSION:1.1.45,REQID:0ef67ac9-50ff-43d7-a514-de6e4e3b6474,IP:10,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:6493067,CLOUDID:0df382a171e0d4dcff09dddc0bf4a5bc,BulkI D:250525002921A3G68U33,BulkQuantity:1,Recheck:0,SF:17|19|24|44|64|66|78|80 |81|82|83|102|841,TC:nil,Content:0|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,B ulk:40,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR: 0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_FSI,TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD X-UUID: 40defaf639fa11f0b29709d653e92f7d-20250526 X-User: lienze@kylinos.cn Received: from kylin [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1241588134; Mon, 26 May 2025 14:25:44 +0800 From: Enze Li To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, enze.li@gmx.com Subject: Re: [PATCH] mm/damon: rename primitives to operations In-Reply-To: <20250524162910.67889-1-sj@kernel.org> (SeongJae Park's message of "Sat, 24 May 2025 09:29:10 -0700") References: <20250524162910.67889-1-sj@kernel.org> Date: Mon, 26 May 2025 14:25:40 +0800 Message-ID: <87o6vfj3bv.fsf@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0B908180006 X-Stat-Signature: dfbqaiftkj9nt1yo444bosh4aef4am4s X-Rspam-User: X-HE-Tag: 1748240752-551334 X-HE-Meta: U2FsdGVkX1+jcvGCuoBX8UpC38kZ5yNwplui13GZAXbxGgQrWEIQ/iP/N4NTVmGQSRxTm8Ww8dxEFH+PE6l2CATH6+LU0pj53UOksPjX2LvczJ8558Rbxw5r8Hd9ennQ2Yvldbhp6QdV9FD5aZwCQRhdr558KISfBKInmZG35uptpKQ9mwYJDomA/U79r3LdmTdT6WFYRinnBJq5ej9OLvARwEGZLtioqSBdOeRDN3hstvIol21dVmToe719h2fHbNaogg9P/1Zr6P8wLxEQZ+ArndpQKyU3iH9lLabtF+PGZnPXD6pvM2zV1lor2YejlfqEIkF0JvOKo4vMbDTFK8I6r8nLiIK1RKO+lEFQ6+GdNUIik+bdJmNIGWZw7PsiAXEVlMXdYk7CagPu2Rxj12d2+6LylTL2MKRvaR6LNeq75mRlxGnUpZjtwjHq7xx4zJn0xFQS2wMpjy8eKvpOOMIAsJ9Y5CGQHtfnPFwrn6BIjr2Ngfq/y3Y0zSKe/HwAQi7/hladkBi0XN5AMeuShuzvTSxoEdzN5dKfsSGi4gEZ9X2HuqMJFn5Pu6TVn2eKXPg2xJrlOHdql58qkNJS0vWW5Ohv4KzBjuIRee2ne+Xyo4sX0xsIfjfQ8phOYeV2OR02iGOnOQ+S7QZFdZmjYd32GXXeZvMEBtajloQ2iZ4+sl1H6uehPspRwh2/nao9VMSyKN5LL2wDUwZg8aYmHXei07BmAmXvgJdz+Heo8Iv/0cQALQeQA1+IP1Zr+kRw8EyeQUDWQL0xkNS+rOKQceAn8M7t9jAMdFETftigv1nM85ufXHD8q2IUrB59v7bJs8FvuNs61Kwp71xjrlXbHR/6fSoLYkXZDFRB3vQbHRfaDRIRAHe12iKBlVDasKtCYQ/zDQxhBwu83zbl2ETYYBY+veM/2p8V3PtEI9/tIbUH92F49h2G0KPzNghZAzUX432Dhx47gsBf3EGCmwB 7hU90OnP lrzLkMkcW7drnT4tIZ9fIMNyZSg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi SeongJae, On Sat, May 24 2025 at 09:29:10 AM -0700, SeongJae Park wrote: > Hi Enze, > > On Sat, 24 May 2025 20:55:36 +0800 Enze Li wrote: > >> The word 'primitive' is not explicit and has been deprecated in DAMON's >> context since commit f7d911c39cbb ("mm/damon: rename damon_primitives to >> damon_operations"). To make the code easier to be understand, this >> commit renames remaining 'primitives' to 'operations' in header comments >> of DAMON source files. > > Thank you for this patch! The description makes sense to me. > > The title makes me bit confused, though. By reading it, I was assuming this > patch is changing some code. But this is changing only comments. Could you > please make the title more clearly specify that? E.g., "fix outdated comments > for monitoring primitives"? > >> >> Fixes: f7d911c39cbb ("mm/damon: rename damon_primitives to damon_operations") >> Signed-off-by: Enze Li >> --- >> mm/damon/modules-common.c | 2 +- >> mm/damon/modules-common.h | 2 +- >> mm/damon/ops-common.c | 2 +- >> mm/damon/ops-common.h | 2 +- >> mm/damon/paddr.c | 2 +- >> mm/damon/sysfs-common.c | 2 +- >> mm/damon/sysfs-common.h | 2 +- >> mm/damon/vaddr.c | 2 +- >> 8 files changed, 8 insertions(+), 8 deletions(-) > > But, the term (primitives) on the comments of the files means the DAMON > monitoring primitives (old name of DAMON operations) only in {p,v}addr.c files. > On the comment of other files, the term means code for basic and common uses. > > Using 'Operations' term on the files look ok to me. But in the case, the > commit message may better to slightly be updated to clarify this. > > Just keeping those files to use 'Primitives' term, or using a more neutral > term, say, Code (e.g., Common Code for DAMON Modules) could also be options, in > my opinion. > > I have no strong preference among these three options. Please pick what you > prefer. Thanks for your suggestion. It seems to me that using 'Code' term is a reasonable choice. > > Could you please revise as abovely suggested and resend? I've sent a v2 to the current thread, many thanks for your review and suggestions! Please let me know if further adjustments are needed. BR, Enze > > > Thanks, > SJ > > [...]